Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

enhancement: return 400 on invalid size param (#735)

Guilherme Oenningc2bc84e1005d
diff --git a/app/handlers/images.go b/app/handlers/images.go
index c1e8b0254..44aac879f 100644
--- a/app/handlers/images.go
+++ b/app/handlers/images.go
@@ -29,7 +29,7 @@ func LetterAvatar() web.HandlerFunc {
size, err := c.QueryParamAsInt("size")
if err != nil {
- return c.Failure(err)
+ return c.BadRequest(web.Map{})
}
size = between(size, 50, 200)
@@ -60,7 +60,7 @@ func Gravatar() web.HandlerFunc {
size, err := c.QueryParamAsInt("size")
if err != nil {
- return c.Failure(err)
+ return c.BadRequest(web.Map{})
}
size = between(size, 50, 200)
@@ -131,7 +131,7 @@ func Favicon() web.HandlerFunc {
size, err := c.QueryParamAsInt("size")
if err != nil {
- return c.Failure(err)
+ return c.BadRequest(web.Map{})
}
size = between(size, 50, 200)
@@ -162,7 +162,7 @@ func ViewUploadedImage() web.HandlerFunc {
size, err := c.QueryParamAsInt("size")
if err != nil {
- return c.Failure(err)
+ return c.BadRequest(web.Map{})
}
size = between(size, 0, 2000)