Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

enhancement: reject API key from visitors (#494)

Guilherme Oenningc2c80d4a6bbe
diff --git a/app/middlewares/domain.go b/app/middlewares/domain.go
index 85c4c2702..48afca89d 100644
--- a/app/middlewares/domain.go
+++ b/app/middlewares/domain.go
@@ -139,6 +139,10 @@ func User() web.MiddlewareFunc {
}
return err
}
+
+ if !user.IsCollaborator() {
+ return c.HandleValidation(validate.Failed("API Key is invalid"))
+ }
}
}
diff --git a/app/middlewares/domain_test.go b/app/middlewares/domain_test.go
index a9c18a774..ca069cf0e 100644
--- a/app/middlewares/domain_test.go
+++ b/app/middlewares/domain_test.go
@@ -466,3 +466,22 @@ func TestUser_InvalidAPIKey(t *testing.T) {
Expect(status).Equals(http.StatusBadRequest)
Expect(query.String("errors[0].message")).Equals("API Key is invalid")
}
+
+func TestUser_ValidAPIKey_Visitor(t *testing.T) {
+ RegisterT(t)
+
+ server, services := mock.NewServer()
+ services.Users.SetCurrentUser(mock.AryaStark)
+ apiKey, _ := services.Users.RegenerateAPIKey()
+
+ server.Use(middlewares.User())
+ status, query := server.
+ OnTenant(mock.DemoTenant).
+ AddHeader("Authorization", fmt.Sprintf("Bearer %s", apiKey)).
+ ExecuteAsJSON(func(c web.Context) error {
+ return c.NoContent(http.StatusOK)
+ })
+
+ Expect(status).Equals(http.StatusBadRequest)
+ Expect(query.String("errors[0].message")).Equals("API Key is invalid")
+}