Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

fix: invalid post number should return a 404 and not a 500 (#589)

Peter Vermeulenccb077ae0779
diff --git a/app/cmd/routes.go b/app/cmd/routes.go
index 808402326..6d12a46e8 100644
--- a/app/cmd/routes.go
+++ b/app/cmd/routes.go
@@ -154,6 +154,7 @@ func routes(r *web.Engine) *web.Engine {
api.Get("/api/v1/posts", apiv1.SearchPosts())
api.Get("/api/v1/tags", apiv1.ListTags())
api.Get("/api/v1/posts/:number/comments", apiv1.ListComments())
+ api.Get("/api/v1/posts/:number", apiv1.GetPost())
//From this step, a User is required
api.Use(middlewares.IsAuthenticated())
diff --git a/app/handlers/apiv1/post.go b/app/handlers/apiv1/post.go
index c4bc958a7..5963294da 100644
--- a/app/handlers/apiv1/post.go
+++ b/app/handlers/apiv1/post.go
@@ -52,6 +52,23 @@ func CreatePost() web.HandlerFunc {
}
}
+// GetPost retrieves the existing post by number
+func GetPost() web.HandlerFunc {
+ return func(c web.Context) error {
+ number, err := c.ParamAsInt("number")
+ if err != nil {
+ return c.NotFound()
+ }
+
+ post, err := c.Services().Posts.GetByNumber(number)
+ if err != nil {
+ return c.Failure(err)
+ }
+
+ return c.Ok(post)
+ }
+}
+
// UpdatePost updates an existing post of current tenant
func UpdatePost() web.HandlerFunc {
return func(c web.Context) error {
@@ -120,7 +137,7 @@ func ListComments() web.HandlerFunc {
return func(c web.Context) error {
number, err := c.ParamAsInt("number")
if err != nil {
- return c.Failure(err)
+ return c.NotFound()
}
post, err := c.Services().Posts.GetByNumber(number)
@@ -228,7 +245,7 @@ func Unsubscribe() web.HandlerFunc {
func addOrRemove(c web.Context, addOrRemove func(post *models.Post, user *models.User) error) error {
number, err := c.ParamAsInt("number")
if err != nil {
- return c.Failure(err)
+ return c.NotFound()
}
post, err := c.Services().Posts.GetByNumber(number)
diff --git a/app/handlers/apiv1/post_test.go b/app/handlers/apiv1/post_test.go
index 487726e15..b564cfab4 100644
--- a/app/handlers/apiv1/post_test.go
+++ b/app/handlers/apiv1/post_test.go
@@ -43,6 +43,25 @@ func TestCreatePostHandler_WithoutTitle(t *testing.T) {
Expect(err).IsNotNil()
}
+func TestGetPostHandler(t *testing.T) {
+ RegisterT(t)
+
+ server, services := mock.NewServer()
+ services.SetCurrentTenant(mock.DemoTenant)
+ services.SetCurrentUser(mock.JonSnow)
+ post, _ := services.Posts.Add("My First Post", "Such an amazing description")
+
+ code, query := server.
+ OnTenant(mock.DemoTenant).
+ AsUser(mock.JonSnow).
+ AddParam("number", post.Number).
+ ExecuteAsJSON(apiv1.GetPost())
+
+ Expect(code).Equals(http.StatusOK)
+ Expect(query.String("title")).Equals("My First Post")
+ Expect(query.String("description")).Equals("Such an amazing description")
+}
+
func TestUpdatePostHandler_TenantStaff(t *testing.T) {
RegisterT(t)
diff --git a/app/handlers/post.go b/app/handlers/post.go
index f31431734..1e3b5161a 100644
--- a/app/handlers/post.go
+++ b/app/handlers/post.go
@@ -52,7 +52,7 @@ func PostDetails() web.HandlerFunc {
return func(c web.Context) error {
number, err := c.ParamAsInt("number")
if err != nil {
- return c.Failure(err)
+ return c.NotFound()
}
posts := c.Services().Posts