Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

use github login when name is empty (#88)

Guilherme Oenningd3847e1e7c6c
diff --git a/app/pkg/oauth/http.go b/app/pkg/oauth/http.go
index 0e0efdf62..2856e3076 100644
--- a/app/pkg/oauth/http.go
+++ b/app/pkg/oauth/http.go
@@ -119,5 +119,10 @@ func (p *HTTPService) GetProfile(authEndpoint string, provider string, code stri
return nil, fmt.Errorf("HTTP Get profile for %s failed with %s", provider, err)
}
+ //GitHub allows users to omit name, so we use their login
+ if strings.Trim(profile.Name, " ") == "" {
+ profile.Name = profile.Login
+ }
+
return profile, nil
}
diff --git a/app/pkg/oauth/oauth.go b/app/pkg/oauth/oauth.go
index 8c54c1325..913ed5c1c 100644
--- a/app/pkg/oauth/oauth.go
+++ b/app/pkg/oauth/oauth.go
@@ -18,6 +18,7 @@ const (
type UserProfile struct {
ID json.Number
Name string
+ Login string
Email string
}
diff --git a/wercker.yml b/wercker.yml
index c056b4906..f259f42da 100644
--- a/wercker.yml
+++ b/wercker.yml
@@ -114,7 +114,7 @@ deploy:
apk update && apk add openssh-client bash
- add-to-known_hosts:
hostname: fider.io
- fingerprint: a5:63:bd:0d:bf:19:28:c4:bc:ea:59:c2:60:4c:53:e0
+ fingerprint: MD5:a5:63:bd:0d:bf:19:28:c4:bc:ea:59:c2:60:4c:53:e0
type: rsa
- add-ssh-key:
keyname: CORE