Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

fix: remove title validation to support Chinese and Japanese (#614)

放為d811fe288363
diff --git a/app/actions/post.go b/app/actions/post.go
index d1bf9aa69..1bd01d084 100644
--- a/app/actions/post.go
+++ b/app/actions/post.go
@@ -1,8 +1,6 @@
package actions
import (
- "strings"
-
"github.com/gosimple/slug"
"github.com/getfider/fider/app"
@@ -33,7 +31,7 @@ func (input *CreateNewPost) Validate(user *models.User, services *app.Services)
if input.Model.Title == "" {
result.AddFieldFailure("title", "Title is required.")
- } else if len(input.Model.Title) < 10 || len(strings.Split(input.Model.Title, " ")) < 3 {
+ } else if len(input.Model.Title) < 10 {
result.AddFieldFailure("title", "Title needs to be more descriptive.")
}
@@ -79,7 +77,7 @@ func (input *UpdatePost) Validate(user *models.User, services *app.Services) *va
if input.Model.Title == "" {
result.AddFieldFailure("title", "Title is required.")
- } else if len(input.Model.Title) < 10 || len(strings.Split(input.Model.Title, " ")) < 3 {
+ } else if len(input.Model.Title) < 10 {
result.AddFieldFailure("title", "Title needs to be more descriptive.")
}
diff --git a/app/actions/post_test.go b/app/actions/post_test.go
index 36ca0aabc..525418d4d 100644
--- a/app/actions/post_test.go
+++ b/app/actions/post_test.go
@@ -20,11 +20,6 @@ func TestCreateNewPost_InvalidPostTitles(t *testing.T) {
" ",
"signup",
"My great great great great great great great great great great great great great great great great great post.",
- "my company",
- "my@company",
- "my.company",
- "my+company",
- "1234567890123456789012345678901234567890ABC",
"my GREAT post",
} {
action := &actions.CreateNewPost{Model: &models.NewPost{Title: title}}