Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

chore: remove experimental flag Experimental_SSR_SEO

goenningde447e01978b
diff --git a/.example.env b/.example.env
index 9b712fdc4..19c687960 100644
--- a/.example.env
+++ b/.example.env
@@ -11,8 +11,6 @@ LOG_SQL=true
LOG_FILE=false
LOG_FILE_OUTPUT=logs/output.log
-# EXPERIMENTAL_SSR_SEO=true
-
# MAINTENANCE=true
# MAINTENANCE_MESSAGE=Sorry, we're down for scheduled maintenance right now.
# MAINTENANCE_UNTIL=about 5 AM PDT
diff --git a/app/pkg/env/env.go b/app/pkg/env/env.go
index 46f15c3d7..bef0d9be1 100644
--- a/app/pkg/env/env.go
+++ b/app/pkg/env/env.go
@@ -40,7 +40,6 @@ type config struct {
HostDomain string `env:"HOST_DOMAIN,required"`
Locale string `env:"LOCALE,default=en"`
JWTSecret string `env:"JWT_SECRET,required"`
- Experimental_SSR_SEO bool `env:"EXPERIMENTAL_SSR_SEO,default=false"`
Database struct {
URL string `env:"DATABASE_URL,required"`
MaxIdleConns int `env:"DATABASE_MAX_IDLE_CONNS,default=2,strict"`
diff --git a/app/pkg/web/renderer.go b/app/pkg/web/renderer.go
index 54fd44d92..35264cbfc 100644
--- a/app/pkg/web/renderer.go
+++ b/app/pkg/web/renderer.go
@@ -56,7 +56,7 @@ type Renderer struct {
// NewRenderer creates a new Renderer
func NewRenderer() *Renderer {
reactRenderer, err := NewReactRenderer("ssr.js")
- if err != nil && env.Config.Experimental_SSR_SEO {
+ if err != nil {
panic(errors.Wrap(err, "failed to initialize SSR renderer"))
}
@@ -229,7 +229,7 @@ func (r *Renderer) Render(w io.Writer, statusCode int, templateName string, prop
}
// Only index.html template uses React, other templates are already SSR
- if env.Config.Experimental_SSR_SEO && ctx.Request.IsCrawler() && templateName == "index.html" {
+ if ctx.Request.IsCrawler() && templateName == "index.html" {
html, err := r.reactRenderer.Render(ctx.Request.URL, public)
if err != nil {
log.Errorf(ctx, "Failed to render react page: @{Error}", dto.Props{
diff --git a/app/pkg/web/renderer_test.go b/app/pkg/web/renderer_test.go
index dc5098aa1..42b3c3f9c 100644
--- a/app/pkg/web/renderer_test.go
+++ b/app/pkg/web/renderer_test.go
@@ -111,7 +111,6 @@ func TestRenderer_Home(t *testing.T) {
func TestRenderer_Home_SSR(t *testing.T) {
RegisterT(t)
- env.Config.Experimental_SSR_SEO = true
bus.AddHandler(func(ctx context.Context, q *query.ListActiveOAuthProviders) error {
return nil
})