Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

tooling: update to Go 1.13.3 (#781)

Guilherme Oenninge3ea1eb06578
diff --git a/.circleci/config.yml b/.circleci/config.yml
index 7d3cb8f0a..95d1b9d04 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1,7 +1,7 @@
version: 2
references:
builder: &builder
- getfider/circleci:0.0.20
+ getfider/circleci:0.0.21
workdir: &workdir
/go/src/github.com/getfider/fider
@@ -14,13 +14,13 @@ jobs:
- checkout
- restore_cache:
keys:
- - fider-v2-npm-{{ checksum "package-lock.json" }}
+ - fider-v3-npm-{{ checksum "package-lock.json" }}
- run:
name: npm install
command: if [ ! -d "./node_modules" ]; then npm ci; fi
- save_cache:
name: save node_modules cache
- key: fider-v2-npm-{{ checksum "package-lock.json" }}
+ key: fider-v3-npm-{{ checksum "package-lock.json" }}
paths:
- node_modules/
@@ -32,7 +32,7 @@ jobs:
- checkout
- restore_cache:
keys:
- - fider-v1-npm-{{ checksum "package-lock.json" }}
+ - fider-v3-npm-{{ checksum "package-lock.json" }}
- run: mage lint
- setup_remote_docker
- run: mage build:docker
@@ -85,7 +85,7 @@ jobs:
- checkout
- restore_cache:
keys:
- - fider-v1-npm-{{ checksum "package-lock.json" }}
+ - fider-v3-npm-{{ checksum "package-lock.json" }}
- run:
name: test
command: mage test:ui
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 25d53de53..d160ac31e 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -19,8 +19,8 @@ If you know these technologies or would like to learn them, lucky you! This is t
| Software | How to install | What is it used for |
|---|---|---|
-| Go 1.11+ | https://golang.org/ | To compile server side code |
-| Node.js 10+ | https://nodejs.org/ or run `nvm use` if you have nvm installed | To compile TypeScript and bundle all the client side code |
+| Go 1.13+ | https://golang.org/ | To compile server side code |
+| Node.js 12+ | https://nodejs.org/ or run `nvm use` if you have nvm installed | To compile TypeScript and bundle all the client side code |
| Docker | https://www.docker.com/ | To start local PostgreSQL instances |
| cosmtrek/air | `go get github.com/cosmtrek/air/cmd/air/` | Live reload for Go apps. When you change the code, it automatically recompiles the application |
| joho/godotenv | `go get github.com/joho/godotenv/cmd/godotenv/` | To load environment variables from a `.env` so that you don't have to change your machine environment variables |
diff --git a/app/pkg/errors/errors_test.go b/app/pkg/errors/errors_test.go
index 838dc2794..dece76419 100644
--- a/app/pkg/errors/errors_test.go
+++ b/app/pkg/errors/errors_test.go
@@ -89,7 +89,7 @@ runtime/debug.Stack`)
Expect(err.Error()).ContainsSubstring(`
github.com/getfider/fider/app/pkg/errors.Panicked`)
Expect(err.Error()).ContainsSubstring(`
-- github.com/getfider/fider/app/pkg/errors_test.TestPanicked:97 (app/pkg/errors/errors.go:40)
+- github.com/getfider/fider/app/pkg/errors_test.TestPanicked:84 (app/pkg/errors/errors.go:40)
- Boom!`)
}
}()