Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

fix: close http request on mailgun (#292)

Guilherme Oenninge5e79973e7b7
diff --git a/app/handlers/avatar.go b/app/handlers/avatar.go
index 5b00154a0..d5cb8798b 100644
--- a/app/handlers/avatar.go
+++ b/app/handlers/avatar.go
@@ -5,7 +5,6 @@ import (
"crypto/md5"
"fmt"
"image/png"
- "io"
"io/ioutil"
"net/http"
"strings"
@@ -37,8 +36,6 @@ func Avatar() web.HandlerFunc {
if err == nil {
return c.Blob(http.StatusOK, "image/png", bytes)
}
- } else {
- io.Copy(ioutil.Discard, resp.Body)
}
}
}
diff --git a/app/pkg/email/mailgun/mailgun.go b/app/pkg/email/mailgun/mailgun.go
index c1a8b3e9d..63c458825 100644
--- a/app/pkg/email/mailgun/mailgun.go
+++ b/app/pkg/email/mailgun/mailgun.go
@@ -99,6 +99,8 @@ func (s *Sender) BatchSend(templateName string, params email.Params, from string
s.logger.Errorf("Failed to send email")
return err
}
+
+ defer resp.Body.Close()
s.logger.Debugf("Email sent with response code %d.", resp.StatusCode)
return nil
}