Skip to content

armgit / fider

Public Imported from GitHub
0

Open platform to collect and prioritize feedback

fix: add log for missing oauth redirect url

goenningee6e83cfaada
diff --git a/app/handlers/oauth.go b/app/handlers/oauth.go
index c6baba096..959d24f6c 100644
--- a/app/handlers/oauth.go
+++ b/app/handlers/oauth.go
@@ -9,6 +9,7 @@ import (
"time"
"github.com/getfider/fider/app/models/cmd"
+ "github.com/getfider/fider/app/models/dto"
"github.com/getfider/fider/app/models/entity"
"github.com/getfider/fider/app/models/enum"
@@ -164,6 +165,11 @@ func OAuthCallback() web.HandlerFunc {
state := c.QueryParam("state")
parts := strings.Split(state, "|")
+ if parts[0] == "" {
+ log.Warnf(c, "Missing redirect URL in OAuth callback state for provider @{Provider}.", dto.Props{"Provider": provider})
+ return c.NotFound()
+ }
+
redirectURL, err := url.ParseRequestURI(parts[0])
if err != nil {
return c.Failure(err)