Open platform to collect and prioritize feedback
enhancement: add few basic http security headers (#334)
Guilherme Oenningf70ecbd2fb1f
diff --git a/app/middlewares/security.go b/app/middlewares/security.gonew file mode 100644index 000000000..71b83f416--- /dev/null+++ b/app/middlewares/security.go@@ -0,0 +1,17 @@+package middlewares++import (+ "github.com/getfider/fider/app/pkg/web"+)++// Secure adds web security related Http Headers to response+func Secure() web.MiddlewareFunc {+ return func(next web.HandlerFunc) web.HandlerFunc {+ return func(c web.Context) error {+ c.Response.Header().Add("X-XSS-Protection", "1; mode=block")+ c.Response.Header().Add("X-Content-Type-Options", "nosniff")+ c.Response.Header().Add("Referrer-Policy", "no-referrer-when-downgrade")+ return next(c)+ }+ }+}diff --git a/app/middlewares/security_test.go b/app/middlewares/security_test.gonew file mode 100644index 000000000..2ad64b805--- /dev/null+++ b/app/middlewares/security_test.go@@ -0,0 +1,26 @@+package middlewares_test++import (+ "net/http"+ "testing"++ "github.com/getfider/fider/app/middlewares"+ "github.com/getfider/fider/app/pkg/mock"+ "github.com/getfider/fider/app/pkg/web"+ . "github.com/onsi/gomega"+)++func TestSecure(t *testing.T) {+ RegisterTestingT(t)++ server, _ := mock.NewServer()+ server.Use(middlewares.Secure())+ status, response := server.Execute(func(c web.Context) error {+ return c.NoContent(http.StatusOK)+ })++ Expect(status).To(Equal(http.StatusOK))+ Expect(response.Header().Get("X-XSS-Protection")).To(Equal("1; mode=block"))+ Expect(response.Header().Get("X-Content-Type-Options")).To(Equal("nosniff"))+ Expect(response.Header().Get("Referrer-Policy")).To(Equal("no-referrer-when-downgrade"))+}diff --git a/routes.go b/routes.goindex 044a862e6..5ffdd0e65 100644--- a/routes.go+++ b/routes.go@@ -16,6 +16,7 @@ func GetMainEngine(settings *models.SystemSettings) *web.Engine {r.Worker().Use(middlewares.WorkerSetup(r.Worker().Logger()))+ r.Use(middlewares.Secure())r.Use(middlewares.Compress())assets := r.Group()