Open source personal finance application
fix(powersync): cascade local trns revert for rejected wallet/category inserts
Ilya Komichev72ac17a02b9e
diff --git a/app/app/plugins/powersync.client.ts b/app/app/plugins/powersync.client.tsindex 7edd68fa..5e91ac4a 100644--- a/app/app/plugins/powersync.client.ts+++ b/app/app/plugins/powersync.client.ts@@ -1,5 +1,5 @@import { connectPowerSync, disconnectPowerSync, forceResync, getPowerSyncDb } from '~~/services/powersync/db'-import { deleteRow } from '~~/services/powersync/mutations'+import { deleteRow, deleteTrnsReferencing } from '~~/services/powersync/mutations'import { setUploadErrorHandler } from '~~/services/powersync/uploadErrorHandler'import { planDivergence } from '~~/services/powersync/uploadReconcile'@@ -42,10 +42,17 @@ export default defineNuxtPlugin(() => {)}else if (plan.toRevert.length) {- // Rejected INSERT(s): delete the local rows to converge. Defer out of the uploadData- // call stack (setTimeout 0) so the new write transaction doesn't contend for the lock.- for (const { id, table } of plan.toRevert)- setTimeout(() => { void deleteRow(table, id) }, 0)+ // Rejected INSERT(s): delete the local rows to converge. A reverted wallet/category also+ // cascades to local trns referencing it, so no orphans survive. Defer out of the+ // uploadData call stack (setTimeout 0) so the new write transaction doesn't contend+ // for the lock.+ for (const { id, table } of plan.toRevert) {+ setTimeout(() => {+ void deleteRow(table, id)+ if (table === 'wallets' || table === 'categories')+ void deleteTrnsReferencing(table, id)+ }, 0)+ }showErrorToast('sync.errors.uploadReverted')}})diff --git a/app/services/powersync/mutations.ts b/app/services/powersync/mutations.tsindex 0ff1e1a0..69cc184a 100644--- a/app/services/powersync/mutations.ts+++ b/app/services/powersync/mutations.ts@@ -54,6 +54,19 @@ export async function deleteRow(table: string, id: string): Promise<void> {await db.execute(`DELETE FROM ${table} WHERE id = ?`, [id])}+/**+ * Delete local trns referencing a wallet/category. Used when a rejected wallet/category+ * INSERT is reverted, so optimistically-created trns don't survive as orphans. The deletes+ * are queued for upload too, converging the server if any of those trns reached it.+ */+export async function deleteTrnsReferencing(table: 'categories' | 'wallets', id: string): Promise<void> {+ const db = await getPowerSyncDb()+ if (table === 'wallets')+ await db.execute('DELETE FROM trns WHERE "walletId" = ? OR "expenseWalletId" = ? OR "incomeWalletId" = ?', [id, id, id])+ else+ await db.execute('DELETE FROM trns WHERE "categoryId" = ?', [id])+}+/** Upsert several rows in a single write transaction (e.g. wallet reordering). */export async function upsertRows(table: string, rows: { id: string, row: Record<string, unknown> }[]): Promise<void> {const db = await getPowerSyncDb()