Skip to content

Open source personal finance application

perf: remove unnecessary deepUnref from all persist operations

Ilya Komichevb986aefa5eb9
diff --git a/app/components/user/useUserStore.ts b/app/components/user/useUserStore.ts
index 50a68a2c..1174942c 100644
--- a/app/components/user/useUserStore.ts
+++ b/app/components/user/useUserStore.ts
@@ -1,6 +1,4 @@
import localforage from 'localforage'
-import { deepUnref } from 'vue-deepunref'
-
import type { CurrencyCode } from '~/components/currencies/types'
import type { LocaleSlug } from '~/components/locale/types'
@@ -69,7 +67,7 @@ export const useUserStore = defineStore('user', () => {
}
if (!isPersistBlocked())
- localforage.setItem(STORAGE_KEYS.user, deepUnref(user.value))
+ localforage.setItem(STORAGE_KEYS.user, user.value)
}
function persistUserSettings() {
diff --git a/app/composables/useStoreSync.ts b/app/composables/useStoreSync.ts
index f20a0d0e..dd213747 100644
--- a/app/composables/useStoreSync.ts
+++ b/app/composables/useStoreSync.ts
@@ -1,8 +1,6 @@
import type { ShallowRef } from 'vue'
import localforage from 'localforage'
-import { deepUnref } from 'vue-deepunref'
-
import type { EntityType } from '~/components/offline/types'
import { errorEmo, random, successEmo, warningEmo } from '~/assets/js/emo'
@@ -36,7 +34,7 @@ export function createDebouncedPersist<T>(storageKey: string) {
return useDebounceFn((values: T) => {
if (_persistBlocked)
return
- localforage.setItem(storageKey, deepUnref(values))
+ localforage.setItem(storageKey, values)
}, 300)
}
@@ -143,7 +141,7 @@ export function handleMutationResult<T>(opts: {
const remapped = { ...rest, [convexId]: item }
opts.items.value = remapped
if (!_persistBlocked)
- localforage.setItem(STORAGE_KEYS[opts.entity], deepUnref(remapped))
+ localforage.setItem(STORAGE_KEYS[opts.entity], remapped)
logger.log(`remapped ID: ${opts.id} → ${convexId}`)
return { convexId, localId: opts.id }
}
diff --git a/app/test-utils/setup-store.ts b/app/test-utils/setup-store.ts
index 3578cd03..a99e20b7 100644
--- a/app/test-utils/setup-store.ts
+++ b/app/test-utils/setup-store.ts
@@ -53,8 +53,6 @@ vi.stubGlobal('cleanupFrontendIds', <T>(data: Record<string, T>, pendingUpdates:
// ---------------------------------------------------------------------------
// 5. Common module mocks
// ---------------------------------------------------------------------------
-vi.mock('vue-deepunref', () => ({ deepUnref: (v: any) => v }))
-
vi.mock('~/components/demo/useDemo', () => ({
useDemo: () => ({ isDemo: { value: false } }),
}))
diff --git a/app/types/vue-deepunref.d.ts b/app/types/vue-deepunref.d.ts
deleted file mode 100644
index c18b4211..00000000
--- a/app/types/vue-deepunref.d.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-declare module 'vue-deepunref' {
- export function deepUnref<T>(value: T): T
-}