Skip to content

Open source personal finance application

fix(convex): validate baseCurrency and locale in userSettings.upsert

Ilya Komichevc2660e967cd5
diff --git a/convex/schema.ts b/convex/schema.ts
index ba871f8d..3884be6c 100644
--- a/convex/schema.ts
+++ b/convex/schema.ts
@@ -57,7 +57,7 @@ export default defineSchema({
userSettings: defineTable({
baseCurrency: v.string(),
- locale: v.optional(v.string()),
+ locale: v.optional(v.union(v.literal('en'), v.literal('ru'))),
userId: v.string(),
}).index('by_user', ['userId']),
diff --git a/convex/userSettings.ts b/convex/userSettings.ts
index a25b88e6..c5745d4d 100644
--- a/convex/userSettings.ts
+++ b/convex/userSettings.ts
@@ -20,11 +20,14 @@ export const get = query({
export const upsert = mutation({
args: {
baseCurrency: v.optional(v.string()),
- locale: v.optional(v.string()),
+ locale: v.optional(v.union(v.literal('en'), v.literal('ru'))),
},
handler: async (ctx, args) => {
const user = await requireAuthUser(ctx)
+ if (args.baseCurrency !== undefined && !args.baseCurrency.trim())
+ throw new Error('Base currency is required')
+
const existing = await ctx.db
.query('userSettings')
.withIndex('by_user', q => q.eq('userId', user._id))