Skip to content

Open source personal finance application

fix(convex): add numeric range validation for date, amount, creditLimit

Ilya Komichevd8ba2509f99f
diff --git a/convex/shared.ts b/convex/shared.ts
index b4fd33ff..8444a416 100644
--- a/convex/shared.ts
+++ b/convex/shared.ts
@@ -13,6 +13,22 @@ export function validateStringLength(value: string | undefined, maxLen: number,
throw new Error(`${fieldName} must be at most ${maxLen} characters`)
}
+/**
+ * Validate numeric field range. Throws if value is outside [min, max].
+ * Skips check when value is undefined (optional fields).
+ */
+export function validateNumberRange(value: number | undefined, min: number, max: number, fieldName: string) {
+ if (value !== undefined && (value < min || value > max))
+ throw new Error(`${fieldName} must be between ${min} and ${max}`)
+}
+
+// 2000-01-01 .. 2100-01-01 in ms
+export const DATE_MIN = 946_684_800_000
+export const DATE_MAX = 4_102_444_800_000
+
+export const AMOUNT_MAX = 1_000_000_000_000
+export const CREDIT_LIMIT_MAX = 1_000_000_000
+
/**
* Get authenticated user or return null (for queries).
*/
diff --git a/convex/trns.ts b/convex/trns.ts
index 9d1d7ca4..f741b71f 100644
--- a/convex/trns.ts
+++ b/convex/trns.ts
@@ -6,11 +6,12 @@ import type { MutationCtx } from './_generated/server'
import { internal } from './_generated/api'
import { mutation, query } from './_generated/server'
-import { getAuthUser, getOwnEntity, requireAuthUser, TrnType, validateStringLength } from './shared'
+import { AMOUNT_MAX, DATE_MAX, DATE_MIN, getAuthUser, getOwnEntity, requireAuthUser, TrnType, validateNumberRange, validateStringLength } from './shared'
import { addTrnToHash, fnv1aNum, removeTrnFromHash } from './trnsHash'
async function validateTrnFields(ctx: MutationCtx, args: Record<string, any>, userId: string) {
validateStringLength(args.desc, 500, 'Description')
+ validateNumberRange(args.date, DATE_MIN, DATE_MAX, 'Date')
if (args.type === TrnType.Transfer) {
if (args.categoryId && args.categoryId !== 'transfer')
@@ -23,6 +24,8 @@ async function validateTrnFields(ctx: MutationCtx, args: Record<string, any>, us
throw new Error('Transfer expense amount must be positive')
if (!args.incomeAmount || args.incomeAmount <= 0)
throw new Error('Transfer income amount must be positive')
+ validateNumberRange(args.expenseAmount, 0, AMOUNT_MAX, 'Expense amount')
+ validateNumberRange(args.incomeAmount, 0, AMOUNT_MAX, 'Income amount')
await Promise.all([
getOwnEntity(ctx, args.expenseWalletId as Id<'wallets'>, userId, 'Expense wallet not found'),
getOwnEntity(ctx, args.incomeWalletId as Id<'wallets'>, userId, 'Income wallet not found'),
@@ -31,6 +34,7 @@ async function validateTrnFields(ctx: MutationCtx, args: Record<string, any>, us
else {
if (!args.amount || args.amount <= 0)
throw new Error('Amount must be positive')
+ validateNumberRange(args.amount, 0, AMOUNT_MAX, 'Amount')
if (!args.walletId)
throw new Error('Wallet is required')
if (!args.categoryId)
diff --git a/convex/wallets.ts b/convex/wallets.ts
index cd45ae15..c94f86ff 100644
--- a/convex/wallets.ts
+++ b/convex/wallets.ts
@@ -2,7 +2,7 @@ import { v } from 'convex/values'
import { internal } from './_generated/api'
import { action, internalMutation, mutation, query } from './_generated/server'
-import { getAuthUser, getOwnEntity, requireAuthUser, validateStringLength, walletTypeValidator } from './shared'
+import { CREDIT_LIMIT_MAX, getAuthUser, getOwnEntity, requireAuthUser, validateNumberRange, validateStringLength, walletTypeValidator } from './shared'
import { removeTrnsFromHash } from './trnsHash'
export const list = query({
@@ -43,6 +43,7 @@ export const create = mutation({
validateStringLength(args.color, 50, 'Color')
validateStringLength(args.currency, 10, 'Currency')
validateStringLength(args.desc, 500, 'Description')
+ validateNumberRange(args.creditLimit, 0, CREDIT_LIMIT_MAX, 'Credit limit')
return await ctx.db.insert('wallets', {
...args,
isArchived: args.isArchived ?? false,
@@ -80,6 +81,7 @@ export const update = mutation({
validateStringLength(args.color, 50, 'Color')
validateStringLength(args.currency, 10, 'Currency')
validateStringLength(args.desc, 500, 'Description')
+ validateNumberRange(args.creditLimit, 0, CREDIT_LIMIT_MAX, 'Credit limit')
await getOwnEntity(ctx, id, user._id)
await ctx.db.patch(id, { ...args, updatedAt: Date.now() })
},