Open source personal finance application
fix: add rates fetch error handling, optimize category uniqueness check
Ilya Komichevded6d17330ea
diff --git a/convex/categories.ts b/convex/categories.tsindex 4d40c8a1..4e2ecea4 100644--- a/convex/categories.ts+++ b/convex/categories.ts@@ -21,11 +21,12 @@ async function validateParentId(ctx: MutationCtx, parentId: Id<'categories'> | 0}async function validateNameUniqueness(ctx: MutationCtx, name: string, parentId: Id<'categories'> | 0, userId: string, excludeId?: Id<'categories'>) {- const duplicates = await ctx.db+ const duplicate = await ctx.db.query('categories').withIndex('by_user_name_parent', q => q.eq('userId', userId).eq('name', name).eq('parentId', parentId))- .collect()- if (duplicates.some(c => c._id !== excludeId))+ .filter(q => excludeId ? q.neq(q.field('_id'), excludeId) : true)+ .first()+ if (duplicate)throw new Error('Category with this name already exists')}diff --git a/convex/rates.ts b/convex/rates.tsindex bb0e17a0..3b325753 100644--- a/convex/rates.ts+++ b/convex/rates.ts@@ -47,8 +47,13 @@ export const fetchAndSaveRates = internalAction({const res = await fetch(`https://openexchangerates.org/api/latest.json?app_id=${appId}`,)- const data = await res.json()+ if (!res.ok) {+ console.error(`Rates fetch failed: ${res.status} ${res.statusText}`)+ return+ }++ const data = await res.json()const today = new Date().toISOString().slice(0, 10)await ctx.runMutation(internal.rates.saveRates, {