Skip to content

Open source personal finance application

fix: remove duplicate filter branch in trns List, add orphan error handling

Ilya Komichevf32d82ad76bd
diff --git a/app/components/offline/replayHelpers.ts b/app/components/offline/replayHelpers.ts
index 70ec1f49..da7f4a88 100644
--- a/app/components/offline/replayHelpers.ts
+++ b/app/components/offline/replayHelpers.ts
@@ -279,7 +279,8 @@ export async function replayTrnOps(ops: OfflineOp[], remapIds: Map<string, strin
if (isTrnOrphaned(remapped, context.walletsItems, context.categoriesItems)) {
orphanCount++
- await actions.removeOfflineOp(op.entity, op.id)
+ try { await actions.removeOfflineOp(op.entity, op.id) }
+ catch (e) { logger.warn(`failed to remove orphan op ${op.entity}/${op.id}:`, e) }
continue
}
diff --git a/app/components/trns/List.vue b/app/components/trns/List.vue
index efe2afc6..21b6d575 100644
--- a/app/components/trns/List.vue
+++ b/app/components/trns/List.vue
@@ -98,9 +98,6 @@ const filteredByTypeIds = computed(() => {
if (filterBy.value === 'adjustment')
return trnsStore.items?.[id]?.categoryId === 'adjustment'
- if (filterBy.value === 'transfer')
- return trnsStore.items?.[id]?.type === selectedTypeFilter.value?.type
-
return trnsStore.items?.[id]?.type === selectedTypeFilter.value?.type
})
})