Skip to content

Open source personal finance application

feat(getRates): refactor

ilkomef90a8581bc65
diff --git a/services/rates/api.ts b/services/rates/api.ts
index f5395a4b..e358f5ac 100644
--- a/services/rates/api.ts
+++ b/services/rates/api.ts
@@ -1,10 +1,9 @@
import axios from 'axios'
-const serviceUrl = `https://openexchangerates.org/api/latest.json?app_id=${process.env.ratesApiKey}`
-
type Props = Record<string, string>
-export const getRatesOfUSD = async (): Promise<Props | false> => {
+export const getRatesOfUSD = async (apiKey: string): Promise<Props | false> => {
+ const serviceUrl = `https://openexchangerates.org/api/latest.json?app_id=${apiKey}`
const { data } = await axios.get(serviceUrl)
if (!data) {
diff --git a/store/currencies/actions.ts b/store/currencies/actions.ts
index 13f75be0..a45b1f54 100644
--- a/store/currencies/actions.ts
+++ b/store/currencies/actions.ts
@@ -1,6 +1,6 @@
import localforage from 'localforage'
import dayjs from 'dayjs'
-import { getRatesOfUSD } from '../../services/rates/api'
+import { getRatesOfUSD } from '~/services/rates/api'
import { getDataOnce, saveData } from '~/services/firebase/api'
export default {
@@ -16,7 +16,7 @@ export default {
// No rates for today
if (!ratesBasedOnUsd) {
- ratesBasedOnUsd = await getRatesOfUSD()
+ ratesBasedOnUsd = await getRatesOfUSD(this.$config.ratesApiKey)
if (!ratesBasedOnUsd)
return