Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

fix: add Number() coercion to prevent string concatenation in credit calculations (#2635)

devin-ai-integration[bot]01609f25c84f
diff --git a/apps/api/src/routes/shared.ts b/apps/api/src/routes/shared.ts
index 9d261d373..741d558d7 100644
--- a/apps/api/src/routes/shared.ts
+++ b/apps/api/src/routes/shared.ts
@@ -176,9 +176,11 @@ export function authMiddleware(
req.acuc = chunk ?? undefined;
if (chunk) {
req.account = {
+ // Use Number() to prevent string concatenation bugs
+ // (Postgres numeric columns may be returned as strings by Supabase)
remainingCredits: chunk.price_should_be_graceful
- ? chunk.remaining_credits + chunk.price_credits
- : chunk.remaining_credits,
+ ? Number(chunk.remaining_credits) + Number(chunk.price_credits)
+ : Number(chunk.remaining_credits),
};
}
next();
diff --git a/apps/api/src/services/billing/auto_charge.ts b/apps/api/src/services/billing/auto_charge.ts
index a7d838cc2..bff44b23e 100644
--- a/apps/api/src/services/billing/auto_charge.ts
+++ b/apps/api/src/services/billing/auto_charge.ts
@@ -354,14 +354,17 @@ async function _autoChargeScale(
return {
success: true,
message: "Auto-recharge successful",
+ // Use Number() to prevent string concatenation bugs
remainingCredits:
- (updatedChunk?.remaining_credits ?? chunk.remaining_credits) +
- price.credits,
+ Number(
+ updatedChunk?.remaining_credits ?? chunk.remaining_credits,
+ ) + Number(price.credits),
chunk: {
...(updatedChunk ?? chunk),
remaining_credits:
- (updatedChunk?.remaining_credits ?? chunk.remaining_credits) +
- price.credits,
+ Number(
+ updatedChunk?.remaining_credits ?? chunk.remaining_credits,
+ ) + Number(price.credits),
},
};
}
@@ -611,12 +614,13 @@ async function _autoChargeSelfServe(
return {
success: true,
message: "Auto-recharge successful",
+ // Use Number() to prevent string concatenation bugs
remainingCredits:
- chunk.remaining_credits + AUTO_RECHARGE_CREDITS,
+ Number(chunk.remaining_credits) + AUTO_RECHARGE_CREDITS,
chunk: {
...chunk,
remaining_credits:
- chunk.remaining_credits + AUTO_RECHARGE_CREDITS,
+ Number(chunk.remaining_credits) + AUTO_RECHARGE_CREDITS,
},
};
} else {
diff --git a/apps/api/src/services/billing/batch_billing.ts b/apps/api/src/services/billing/batch_billing.ts
index 8878c2145..227fb1858 100644
--- a/apps/api/src/services/billing/batch_billing.ts
+++ b/apps/api/src/services/billing/batch_billing.ts
@@ -329,9 +329,11 @@ async function supaBillTeam(
acuc
? {
...acuc,
- credits_used: acuc.credits_used + credits,
- adjusted_credits_used: acuc.adjusted_credits_used + credits,
- remaining_credits: acuc.remaining_credits - credits,
+ // Use Number() to prevent string concatenation bugs
+ credits_used: Number(acuc.credits_used) + credits,
+ adjusted_credits_used:
+ Number(acuc.adjusted_credits_used) + credits,
+ remaining_credits: Number(acuc.remaining_credits) - credits,
}
: null,
);
@@ -339,9 +341,11 @@ async function supaBillTeam(
acuc
? {
...acuc,
- credits_used: acuc.credits_used + credits,
- adjusted_credits_used: acuc.adjusted_credits_used + credits,
- remaining_credits: acuc.remaining_credits - credits,
+ // Use Number() to prevent string concatenation bugs
+ credits_used: Number(acuc.credits_used) + credits,
+ adjusted_credits_used:
+ Number(acuc.adjusted_credits_used) + credits,
+ remaining_credits: Number(acuc.remaining_credits) - credits,
}
: null,
);
diff --git a/apps/api/src/services/billing/credit_billing.ts b/apps/api/src/services/billing/credit_billing.ts
index 2f0638f9e..6436481b5 100644
--- a/apps/api/src/services/billing/credit_billing.ts
+++ b/apps/api/src/services/billing/credit_billing.ts
@@ -88,20 +88,26 @@ async function supaCheckTeamCredits(
};
}
+ // Ensure numeric types to prevent string concatenation bugs
+ // (Postgres numeric columns may be returned as strings by Supabase)
+ const adjustedCreditsUsed = Number(chunk.adjusted_credits_used);
+ const totalCreditsSum = Number(chunk.total_credits_sum ?? 100000000);
+ const priceCredits = Number(chunk.price_credits);
+ const chunkRemainingCredits = Number(chunk.remaining_credits);
+
const remainingCredits = chunk.price_should_be_graceful
- ? chunk.remaining_credits + chunk.price_credits
- : chunk.remaining_credits;
+ ? chunkRemainingCredits + priceCredits
+ : chunkRemainingCredits;
- const creditsWillBeUsed = chunk.adjusted_credits_used + credits;
+ const creditsWillBeUsed = adjustedCreditsUsed + credits;
// In case chunk.price_credits is undefined, set it to a large number to avoid mistakes
const totalPriceCredits = chunk.price_should_be_graceful
- ? (chunk.total_credits_sum ?? 100000000) + chunk.price_credits
- : (chunk.total_credits_sum ?? 100000000);
+ ? totalCreditsSum + priceCredits
+ : totalCreditsSum;
// Removal of + credits
- const creditUsagePercentage =
- chunk.adjusted_credits_used / (chunk.total_credits_sum ?? 100000000);
+ const creditUsagePercentage = adjustedCreditsUsed / totalCreditsSum;
let isAutoRechargeEnabled = false,
autoRechargeThreshold = 1000;