Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

fix(ci): scope secret to E2E step only, use non-secret flag for if check

Devin AI20b463f48d03
diff --git a/.github/workflows/test-php-sdk.yml b/.github/workflows/test-php-sdk.yml
index d77625eef..5db9858f4 100644
--- a/.github/workflows/test-php-sdk.yml
+++ b/.github/workflows/test-php-sdk.yml
@@ -19,7 +19,7 @@ jobs:
name: Build and Test
runs-on: blacksmith-4vcpu-ubuntu-2404
env:
- FIRECRAWL_API_KEY: ${{ secrets.FIRECRAWL_API_KEY }}
+ HAS_API_KEY: ${{ secrets.FIRECRAWL_API_KEY != '' }}
if: >-
github.event_name == 'workflow_dispatch' ||
github.event_name == 'pull_request' ||
@@ -64,6 +64,8 @@ jobs:
run: vendor/bin/pest --ci
- name: Run E2E tests
- if: env.FIRECRAWL_API_KEY != ''
+ if: env.HAS_API_KEY == 'true'
working-directory: ./apps/php-sdk
+ env:
+ FIRECRAWL_API_KEY: ${{ secrets.FIRECRAWL_API_KEY }}
run: vendor/bin/pest --ci --group=e2e