Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

chore(api): remove AUTUMN_CHECK_ENABLED flag (#3608)

firecrawl-spring[bot]4478a0fb7dc9
diff --git a/apps/api/src/config.ts b/apps/api/src/config.ts
index 1e93838ff..5d41241c7 100644
--- a/apps/api/src/config.ts
+++ b/apps/api/src/config.ts
@@ -52,8 +52,6 @@ const configSchema = z.object({
LLAMAPARSE_API_KEY: z.string().optional(),
STRIPE_SECRET_KEY: z.string().optional(),
AUTUMN_SECRET_KEY: z.string().optional(),
- AUTUMN_CHECK_ENABLED: z.string().optional(),
- AUTUMN_CHECK_EXPERIMENT_PERCENT: z.coerce.number().default(100),
AUTUMN_EXPERIMENT: z.string().optional(),
AUTUMN_EXPERIMENT_PERCENT: z.coerce.number().default(100),
AUTUMN_REQUEST_TRACK_EXPERIMENT: z.string().optional(),
diff --git a/apps/api/src/services/autumn/__tests__/autumn.service.test.ts b/apps/api/src/services/autumn/__tests__/autumn.service.test.ts
index eac84448b..78b9b6cbc 100644
--- a/apps/api/src/services/autumn/__tests__/autumn.service.test.ts
+++ b/apps/api/src/services/autumn/__tests__/autumn.service.test.ts
@@ -70,7 +70,6 @@ jest.mock("../../supabase", () => ({
jest.mock("../../../config", () => ({
config: {
- AUTUMN_CHECK_ENABLED: undefined,
AUTUMN_EXPERIMENT: "true",
AUTUMN_EXPERIMENT_PERCENT: 100,
AUTUMN_REQUEST_TRACK_EXPERIMENT: undefined,
@@ -102,24 +101,6 @@ function makeEntity(usage: number) {
return { balances: { CREDITS: { usage } } };
}
-function setAutumnConfig(
- overrides: {
- AUTUMN_CHECK_ENABLED?: string;
- AUTUMN_EXPERIMENT?: string;
- AUTUMN_EXPERIMENT_PERCENT?: number;
- AUTUMN_REQUEST_TRACK_EXPERIMENT?: string;
- AUTUMN_REQUEST_TRACK_EXPERIMENT_PERCENT?: number;
- } = {},
-) {
- config.AUTUMN_CHECK_ENABLED = overrides.AUTUMN_CHECK_ENABLED;
- config.AUTUMN_EXPERIMENT = overrides.AUTUMN_EXPERIMENT ?? "true";
- config.AUTUMN_EXPERIMENT_PERCENT = overrides.AUTUMN_EXPERIMENT_PERCENT ?? 100;
- config.AUTUMN_REQUEST_TRACK_EXPERIMENT =
- overrides.AUTUMN_REQUEST_TRACK_EXPERIMENT;
- config.AUTUMN_REQUEST_TRACK_EXPERIMENT_PERCENT =
- overrides.AUTUMN_REQUEST_TRACK_EXPERIMENT_PERCENT ?? 100;
-}
-
// ---------------------------------------------------------------------------
// Test setup
// ---------------------------------------------------------------------------
@@ -128,7 +109,10 @@ beforeEach(() => {
jest.clearAllMocks();
autumnClientRef = mockAutumnClient;
supabaseStubData = { data: { org_id: "org-1" }, error: null };
- setAutumnConfig({ AUTUMN_CHECK_ENABLED: undefined });
+ config.AUTUMN_EXPERIMENT = "true";
+ config.AUTUMN_EXPERIMENT_PERCENT = 100;
+ config.AUTUMN_REQUEST_TRACK_EXPERIMENT = undefined;
+ config.AUTUMN_REQUEST_TRACK_EXPERIMENT_PERCENT = 100;
mockCheck.mockResolvedValue({
allowed: true,
customerId: "org-1",
@@ -370,7 +354,6 @@ describe("lockCredits", () => {
describe("checkCredits", () => {
it("returns null when autumnClient is null", async () => {
autumnClientRef = null;
- config.AUTUMN_CHECK_ENABLED = "true";
const svc = makeService();
const result = await svc.checkCredits({ teamId: "team-1", value: 10 });
expect(result).toBeNull();
@@ -378,7 +361,6 @@ describe("checkCredits", () => {
});
it("returns allowed and remaining on happy path without a lock", async () => {
- config.AUTUMN_CHECK_ENABLED = "true";
mockCheck.mockResolvedValue({
allowed: true,
customerId: "org-1",
@@ -407,7 +389,6 @@ describe("checkCredits", () => {
});
it("returns allowed false with remaining 0 when balance is null", async () => {
- config.AUTUMN_CHECK_ENABLED = "true";
mockCheck.mockResolvedValue({
allowed: false,
customerId: "org-1",
@@ -563,10 +544,6 @@ describe("orgBucket", () => {
});
describe("isAutumnEnabled", () => {
- afterEach(() => {
- setAutumnConfig({ AUTUMN_CHECK_ENABLED: undefined });
- });
-
it("returns true when experiment is enabled and percent is 100", () => {
expect(isAutumnEnabled()).toBe(true);
});
@@ -596,32 +573,14 @@ describe("isAutumnEnabled", () => {
});
describe("isAutumnCheckEnabled", () => {
- afterEach(() => {
- setAutumnConfig({ AUTUMN_CHECK_ENABLED: undefined });
- });
-
- it("returns false when AUTUMN_CHECK_ENABLED is not 'true'", () => {
- config.AUTUMN_CHECK_ENABLED = undefined;
- expect(isAutumnCheckEnabled()).toBe(false);
- });
-
- it("returns false when Autumn experiment is disabled", () => {
- config.AUTUMN_CHECK_ENABLED = "true";
+ it("mirrors AUTUMN_EXPERIMENT", () => {
+ expect(isAutumnCheckEnabled()).toBe(true);
config.AUTUMN_EXPERIMENT = undefined;
expect(isAutumnCheckEnabled()).toBe(false);
});
-
- it("returns true only when both check flag and experiment are enabled", () => {
- config.AUTUMN_CHECK_ENABLED = "true";
- expect(isAutumnCheckEnabled()).toBe(true);
- });
});
describe("isAutumnRequestTrackEnabled", () => {
- afterEach(() => {
- setAutumnConfig({ AUTUMN_REQUEST_TRACK_EXPERIMENT: undefined });
- });
-
it("returns false when request tracking flag is not 'true'", () => {
expect(isAutumnRequestTrackEnabled()).toBe(false);
});
@@ -633,10 +592,6 @@ describe("isAutumnRequestTrackEnabled", () => {
});
describe("experiment gate on lockCredits", () => {
- afterEach(() => {
- setAutumnConfig();
- });
-
it("lockCredits returns null when experiment is disabled", async () => {
config.AUTUMN_EXPERIMENT = undefined;
const svc = makeService();
diff --git a/apps/api/src/services/autumn/autumn.service.ts b/apps/api/src/services/autumn/autumn.service.ts
index a33d82b38..3e3c109bb 100644
--- a/apps/api/src/services/autumn/autumn.service.ts
+++ b/apps/api/src/services/autumn/autumn.service.ts
@@ -65,11 +65,7 @@ export function isAutumnEnabled(orgId?: string): boolean {
export function isAutumnCheckEnabled(orgId?: string): boolean {
if (orgId && AUTUMN_BYPASS_ORG_IDS.has(orgId)) return true;
- if (config.AUTUMN_CHECK_ENABLED !== "true") return false;
- if (config.AUTUMN_EXPERIMENT !== "true") return false;
- const percent = config.AUTUMN_CHECK_EXPERIMENT_PERCENT ?? 100;
- if (!orgId || percent >= 100) return true;
- return orgBucket(orgId) < percent;
+ return config.AUTUMN_EXPERIMENT === "true";
}
export function isAutumnRequestTrackEnabled(orgId?: string): boolean {