Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

fix(api): never auto-confirm email recipients of new monitors (#5650)

tomsideguide63003a2e01df
diff --git a/apps/api/src/services/monitoring/types.ts b/apps/api/src/services/monitoring/types.ts
index 341a19a47..ee1b339c0 100644
--- a/apps/api/src/services/monitoring/types.ts
+++ b/apps/api/src/services/monitoring/types.ts
@@ -144,7 +144,7 @@ const monitorNotificationInner = z
email: z
.strictObject({
enabled: z.boolean().optional().default(false),
- recipients: z.array(z.email()).max(25).optional().default([]),
+ recipients: z.array(z.email().max(320)).max(25).optional().default([]),
includeDiffs: z.boolean().optional().default(false),
})
.optional(),
diff --git a/apps/api/src/services/notification/monitoring_email.test.ts b/apps/api/src/services/notification/monitoring_email.test.ts
index e9c34bc21..60064b709 100644
--- a/apps/api/src/services/notification/monitoring_email.test.ts
+++ b/apps/api/src/services/notification/monitoring_email.test.ts
@@ -640,13 +640,14 @@ describe("sendMonitoringEmailSummary", () => {
row: fakeRecipient("[email protected]", "confirmed", "legacy"),
});
- const result = await sendMonitoringEmailSummary(
- buildArgs({
- emailEnabled: true,
- recipients: ["[email protected]"],
- pages: [{ status: "changed" }],
- }),
- );
+ const args = buildArgs({
+ emailEnabled: true,
+ recipients: ["[email protected]"],
+ pages: [{ status: "changed" }],
+ });
+ args.monitor.created_at = "2026-01-01T00:00:00Z";
+
+ const result = await sendMonitoringEmailSummary(args);
expect(result.attempted).toBe(true);
expect(result.recipients).toEqual(["[email protected]"]);
expect(mockEnsureRecipient).toHaveBeenCalledWith({
diff --git a/apps/api/src/services/notification/monitoring_email.ts b/apps/api/src/services/notification/monitoring_email.ts
index d4d253ded..7279a3fea 100644
--- a/apps/api/src/services/notification/monitoring_email.ts
+++ b/apps/api/src/services/notification/monitoring_email.ts
@@ -23,6 +23,8 @@ const logger = _logger.child({ module: "monitoring-email" });
const FROM_ADDRESS = "Firecrawl <[email protected]>";
const REPLY_TO_ADDRESS = "[email protected]";
+// Monitors created after email opt-in shipped always have recipient rows.
+const EMAIL_OPT_IN_CUTOFF = Date.parse("2026-06-01T00:00:00Z");
type MonitoringEmailPage = {
url: string;
@@ -400,7 +402,10 @@ async function resolveSendableRecipients(
// as confirmed so existing alerts keep flowing without a DB backfill.
// Partial-row monitors keep strict gating — missing addresses stay
// pending rather than getting auto-confirmed.
- if (rows.length === 0) {
+ if (
+ rows.length === 0 &&
+ Date.parse(monitor.created_at) < EMAIL_OPT_IN_CUTOFF
+ ) {
const legacyRows = await Promise.all(
explicitConfigured.map(async email => {
const { row } = await ensureMonitorEmailRecipient({