Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥
TypeScript aiai-agentsai-crawlerai-scrapingai-searchcrawlerdata-extractionhtml-to-markdownllmmarkdownscraperscrapingweb-crawlerweb-dataweb-data-extractionweb-scraperweb-scrapingweb-searchwebscraping
fix: address cubic review - safe error interpolation and non-vacuous enum tests
Devin AI69c113a04505
diff --git a/apps/elixir-sdk/lib/firecrawl/error.ex b/apps/elixir-sdk/lib/firecrawl/error.exindex b20d8af68..7fbdb5964 100644--- a/apps/elixir-sdk/lib/firecrawl/error.ex+++ b/apps/elixir-sdk/lib/firecrawl/error.ex@@ -17,7 +17,12 @@ defmodule Firecrawl.Error do@impl truedef message(%__MODULE__{status: status, body: body}) when is_map(body) do- error_msg = body["error"] || body["message"] || inspect(body)+ error_msg =+ case body["error"] || body["message"] do+ msg when is_binary(msg) -> msg+ _ -> inspect(body)+ end+"Firecrawl API error (HTTP #{status}): #{error_msg}"enddiff --git a/apps/elixir-sdk/test/firecrawl_test.exs b/apps/elixir-sdk/test/firecrawl_test.exsindex 88009c03a..72f6a9d14 100644--- a/apps/elixir-sdk/test/firecrawl_test.exs+++ b/apps/elixir-sdk/test/firecrawl_test.exs@@ -103,7 +103,9 @@ defmodule FirecrawlTest doretry: false)- assert {:error, _} = result+ assert {:error, err} = result+ refute match?(%NimbleOptions.ValidationError{}, err),+ "Expected connection error, got validation error: #{inspect(err)}"endtest "accepts string values for enum params (sitemap)" do@@ -117,7 +119,9 @@ defmodule FirecrawlTest doretry: false)- assert {:error, _} = result+ assert {:error, err} = result+ refute match?(%NimbleOptions.ValidationError{}, err),+ "Expected connection error, got validation error: #{inspect(err)}"endtest "non-bang returns {:error, %Firecrawl.Error{}} for API errors" do