Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

feat(api): enhance integration proxy with additional endpoints (#3523)

Erik Engervall6fa35b7f5deb
diff --git a/apps/api/src/lib/admin-integration-integrations-proxy.ts b/apps/api/src/lib/admin-integration-integrations-proxy.ts
index aba5d1b6d..c898f9f67 100644
--- a/apps/api/src/lib/admin-integration-integrations-proxy.ts
+++ b/apps/api/src/lib/admin-integration-integrations-proxy.ts
@@ -1,12 +1,6 @@
import type { Request, Response } from "express";
import { logger } from "./logger";
-const FIRECRAWL_INTEGRATIONS_ORIGIN = "https://integrations.firecrawl.dev";
-const DEFAULT_PROXY_TIMEOUT_MS = 60_000;
-
-/** Partner route for POST /admin/integration/rotate-api-key */
-const PARTNER_ROTATE_UPSTREAM_PATH = "/partner/v1/api-keys/rotate";
-
/**
* Same contract as firecrawl-integrations `ResponseErrorPayload` (`src/errors/response-error.ts`).
* Allowed `error.code` values are the `ExternalErrorCode` union in `src/errors/service-error.ts`;
@@ -20,19 +14,19 @@ type IntegrationsResponseErrorPayload = {
};
};
-/**
- * Proxies POST `/admin/integration/rotate-api-key` to `https://integrations.firecrawl.dev`.
- * JSON responses (success or error) are passed through with the upstream status. Upstream errors follow
- * firecrawl-integrations `ResponseErrorPayload` (`error: { code, message, data? }`).
- */
-export async function handleIntegrationAdminRotateProxy(
+async function proxyPartnerIntegrationPost(
req: Request,
res: Response,
+ upstreamPath:
+ | "/partner/v1/accounts"
+ | "/partner/v1/api-keys/validate"
+ | "/partner/v1/api-keys/rotate",
+ route: "create-user" | "validate-api-key" | "rotate-api-key",
): Promise<void> {
- const url = `${FIRECRAWL_INTEGRATIONS_ORIGIN}${PARTNER_ROTATE_UPSTREAM_PATH}`;
+ const url = `https://integrations.firecrawl.dev${upstreamPath}`;
const log = logger.child({
module: "admin-integration-integrations-proxy",
- route: "rotate-api-key",
+ route,
});
const headers: Record<string, string> = {
@@ -62,7 +56,7 @@ export async function handleIntegrationAdminRotateProxy(
method: "POST",
headers,
body,
- signal: AbortSignal.timeout(DEFAULT_PROXY_TIMEOUT_MS),
+ signal: AbortSignal.timeout(60_000),
});
} catch (error) {
log.error("firecrawl-integrations proxy fetch failed", { error, url });
@@ -95,3 +89,51 @@ export async function handleIntegrationAdminRotateProxy(
res.status(upstream.status).send(text);
}
+
+/**
+ * Proxies POST `/admin/integration/create-user` to integrations
+ * `POST /partner/v1/accounts`. JSON responses pass through with upstream status.
+ */
+export async function handleIntegrationAdminCreateUserProxy(
+ req: Request,
+ res: Response,
+): Promise<void> {
+ await proxyPartnerIntegrationPost(
+ req,
+ res,
+ "/partner/v1/accounts",
+ "create-user",
+ );
+}
+
+/**
+ * Proxies POST `/admin/integration/validate-api-key` to integrations
+ * `POST /partner/v1/api-keys/validate`. JSON responses pass through with upstream status.
+ */
+export async function handleIntegrationAdminValidateProxy(
+ req: Request,
+ res: Response,
+): Promise<void> {
+ await proxyPartnerIntegrationPost(
+ req,
+ res,
+ "/partner/v1/api-keys/validate",
+ "validate-api-key",
+ );
+}
+
+/**
+ * Proxies POST `/admin/integration/rotate-api-key` to integrations
+ * `POST /partner/v1/api-keys/rotate`. JSON responses pass through with upstream status.
+ */
+export async function handleIntegrationAdminRotateProxy(
+ req: Request,
+ res: Response,
+): Promise<void> {
+ await proxyPartnerIntegrationPost(
+ req,
+ res,
+ "/partner/v1/api-keys/rotate",
+ "rotate-api-key",
+ );
+}
diff --git a/apps/api/src/routes/admin.ts b/apps/api/src/routes/admin.ts
index 36caed540..bddd88f30 100644
--- a/apps/api/src/routes/admin.ts
+++ b/apps/api/src/routes/admin.ts
@@ -15,10 +15,12 @@ import {
} from "../controllers/v0/admin/metrics";
import { realtimeSearchController } from "../controllers/v2/f-search";
import { concurrencyQueueBackfillController } from "../controllers/v0/admin/concurrency-queue-backfill";
-import { integCreateUserController } from "../controllers/v0/admin/create-user";
-import { integValidateApiKeyController } from "../controllers/v0/admin/validate-api-key";
import { crawlMonitorController } from "../controllers/v0/admin/crawl-monitor";
-import { handleIntegrationAdminRotateProxy } from "../lib/admin-integration-integrations-proxy";
+import {
+ handleIntegrationAdminCreateUserProxy,
+ handleIntegrationAdminRotateProxy,
+ handleIntegrationAdminValidateProxy,
+} from "../lib/admin-integration-integrations-proxy";
import { RateLimiterMode } from "../types";
export const adminRouter = express.Router();
@@ -87,14 +89,19 @@ adminRouter.post(
wrap(crawlMonitorController),
);
+// TODO: Remove dangling partner admin controller implementations (routes now proxy to
+// firecrawl-integrations — see `lib/admin-integration-integrations-proxy.ts`):
+// - `controllers/v0/admin/create-user.ts` (`integCreateUserController`)
+// - `controllers/v0/admin/validate-api-key.ts` (`integValidateApiKeyController`)
+// - `controllers/v0/admin/rotate-api-key.ts` (`integRotateApiKeyController`)
adminRouter.post(
`/admin/integration/create-user`,
- wrap(integCreateUserController),
+ wrap(handleIntegrationAdminCreateUserProxy),
);
adminRouter.post(
`/admin/integration/validate-api-key`,
- wrap(integValidateApiKeyController),
+ wrap(handleIntegrationAdminValidateProxy),
);
adminRouter.post(