Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

fix: handle ZodError in v1/search controller catch block (#2926)

Abimael Martell774a2ef68299
diff --git a/apps/api/src/__tests__/snips/v1/lib.ts b/apps/api/src/__tests__/snips/v1/lib.ts
index 72ed02213..d531348d5 100644
--- a/apps/api/src/__tests__/snips/v1/lib.ts
+++ b/apps/api/src/__tests__/snips/v1/lib.ts
@@ -410,7 +410,7 @@ export async function extract(
// Search API
// =========================================
-async function searchRaw(body: SearchRequestInput, identity: Identity) {
+export async function searchRaw(body: SearchRequestInput, identity: Identity) {
return await request(TEST_API_URL)
.post("/v1/search")
.set("Authorization", `Bearer ${identity.apiKey}`)
diff --git a/apps/api/src/__tests__/snips/v1/search.test.ts b/apps/api/src/__tests__/snips/v1/search.test.ts
index ff8e07355..a7956292e 100644
--- a/apps/api/src/__tests__/snips/v1/search.test.ts
+++ b/apps/api/src/__tests__/snips/v1/search.test.ts
@@ -1,5 +1,5 @@
import { describeIf, HAS_PROXY, HAS_SEARCH, TEST_PRODUCTION } from "../lib";
-import { search, idmux, Identity } from "./lib";
+import { search, searchRaw, idmux, Identity } from "./lib";
let identity: Identity;
@@ -81,6 +81,23 @@ describeIf(TEST_PRODUCTION || HAS_SEARCH || HAS_PROXY)("Search tests", () => {
60000,
);
+ it.concurrent(
+ "returns 400 for limit over 100",
+ async () => {
+ const raw = await searchRaw(
+ {
+ query: "firecrawl",
+ limit: 200,
+ } as any,
+ identity,
+ );
+
+ expect(raw.statusCode).toBe(400);
+ expect(raw.body.success).toBe(false);
+ },
+ 60000,
+ );
+
it.concurrent(
"country defaults to undefined when location is set",
async () => {
diff --git a/apps/api/src/__tests__/snips/v2/scrape.test.ts b/apps/api/src/__tests__/snips/v2/scrape.test.ts
index 438f7eb48..d3c2c9601 100644
--- a/apps/api/src/__tests__/snips/v2/scrape.test.ts
+++ b/apps/api/src/__tests__/snips/v2/scrape.test.ts
@@ -139,6 +139,22 @@ describe("Scrape tests", () => {
);
});
+ it.concurrent(
+ "returns 400 for invalid URL",
+ async () => {
+ const raw = await scrapeRaw(
+ {
+ url: "not-a-valid-url",
+ } as any,
+ identity,
+ );
+
+ expect(raw.statusCode).toBe(400);
+ expect(raw.body.success).toBe(false);
+ },
+ scrapeTimeout,
+ );
+
// TEMP: domain broken
// it.concurrent("works with Punycode domains", async () => {
// await scrape({
diff --git a/apps/api/src/controllers/v1/search.ts b/apps/api/src/controllers/v1/search.ts
index 88f322937..f96ffaedd 100644
--- a/apps/api/src/controllers/v1/search.ts
+++ b/apps/api/src/controllers/v1/search.ts
@@ -15,6 +15,7 @@ import { logger as _logger } from "../../lib/logger";
import type { Logger } from "winston";
import { ScrapeJobTimeoutError } from "../../lib/error";
import { captureExceptionWithZdrCheck } from "../../services/sentry";
+import { z } from "zod";
import { executeSearch } from "../../search/execute";
import {
DocumentWithCostTracking,
@@ -252,6 +253,15 @@ export async function searchController(
return res.status(200).json(responseData);
} catch (error) {
+ if (error instanceof z.ZodError) {
+ logger.warn("Invalid request body", { error: error.issues });
+ return res.status(400).json({
+ success: false,
+ error: "Invalid request body",
+ details: error.issues,
+ });
+ }
+
if (error instanceof ScrapeJobTimeoutError) {
return res.status(408).json({
success: false,