Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

fix(rust-sdk): address cubic review feedback and fix cargo fmt

Devin AI782169f7f255
diff --git a/README.md b/README.md
index eb818202d..5225c56ee 100644
--- a/README.md
+++ b/README.md
@@ -661,6 +661,7 @@ Add the dependency:
```toml
[dependencies]
firecrawl = "2"
+tokio = { version = "1", features = ["macros", "rt-multi-thread"] }
```
```rust
use firecrawl::{Client, ScrapeOptions, Format, CrawlOptions};
diff --git a/apps/rust-sdk/src/batch_scrape.rs b/apps/rust-sdk/src/batch_scrape.rs
index 2b2fef680..6a6ad8f35 100644
--- a/apps/rust-sdk/src/batch_scrape.rs
+++ b/apps/rust-sdk/src/batch_scrape.rs
@@ -311,11 +311,13 @@ impl Client {
JobStatus::Failed => {
return Err(FirecrawlError::JobFailed(
"Batch scrape job failed".to_string(),
+ JobStatus::Failed,
));
}
JobStatus::Cancelled => {
return Err(FirecrawlError::JobFailed(
"Batch scrape job was cancelled".to_string(),
+ JobStatus::Cancelled,
));
}
}
diff --git a/apps/rust-sdk/src/crawl.rs b/apps/rust-sdk/src/crawl.rs
index c9639b6ac..f849b0922 100644
--- a/apps/rust-sdk/src/crawl.rs
+++ b/apps/rust-sdk/src/crawl.rs
@@ -316,11 +316,13 @@ impl Client {
JobStatus::Failed => {
return Err(FirecrawlError::JobFailed(
"Crawl job failed".to_string(),
+ JobStatus::Failed,
));
}
JobStatus::Cancelled => {
return Err(FirecrawlError::JobFailed(
"Crawl job was cancelled".to_string(),
+ JobStatus::Cancelled,
));
}
}
diff --git a/apps/rust-sdk/src/error.rs b/apps/rust-sdk/src/error.rs
index 0f991503e..98e91fa80 100644
--- a/apps/rust-sdk/src/error.rs
+++ b/apps/rust-sdk/src/error.rs
@@ -38,8 +38,8 @@ pub enum FirecrawlError {
ResponseParseError(serde_json::Error),
#[error("{0} failed: {1}")]
APIError(String, FirecrawlAPIError),
- #[error("Job failed: {0}")]
- JobFailed(String),
+ #[error("Job failed: {0} (status: {1:?})")]
+ JobFailed(String, crate::types::JobStatus),
#[error("Misuse: {0}")]
Misuse(String),
}
diff --git a/apps/rust-sdk/src/scrape.rs b/apps/rust-sdk/src/scrape.rs
index 2625c47bf..84e51405c 100644
--- a/apps/rust-sdk/src/scrape.rs
+++ b/apps/rust-sdk/src/scrape.rs
@@ -103,6 +103,8 @@ pub enum ParserConfig {
#[serde(rename = "type")]
parser_type: String,
#[serde(skip_serializing_if = "Option::is_none")]
+ mode: Option<String>,
+ #[serde(skip_serializing_if = "Option::is_none")]
max_pages: Option<u32>,
},
}