Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥
TypeScript aiai-agentsai-crawlerai-scrapingai-searchcrawlerdata-extractionhtml-to-markdownllmmarkdownscraperscrapingweb-crawlerweb-dataweb-data-extractionweb-scraperweb-scrapingweb-searchwebscraping
feat(api): open the team-skills proxy routes to every team (#5279)
Developers Digest7e2049b3fa6f
diff --git a/apps/api/src/__tests__/routes/exchange-connectors.routes.test.ts b/apps/api/src/__tests__/routes/exchange-connectors.routes.test.tsindex 3bba0c51e..381dd53d0 100644--- a/apps/api/src/__tests__/routes/exchange-connectors.routes.test.ts+++ b/apps/api/src/__tests__/routes/exchange-connectors.routes.test.ts@@ -184,6 +184,37 @@ describe("Alexandria connector routes on the Exchange proxy", () => {expect(mocks.upstreamFetch).not.toHaveBeenCalled();});+ it.each([+ ["get", "/exchange/team-skills", "/v1/team-skills"],+ ["post", "/exchange/team-skills", "/v1/team-skills"],+ ["patch", "/exchange/team-skills/item-1", "/v1/team-skills/item-1"],+ ["delete", "/exchange/team-skills/item-1", "/v1/team-skills/item-1"],+ [+ "get",+ "/exchange/team-skills/references?q=fred",+ "/v1/team-skills/references?q=fred",+ ],+ ] as const)(+ "forwards %s %s for any team, without granting connectors",+ async (method, path, upstreamPath) => {+ keyResolvesAs({});+ let req = request(app)+ [method](path)+ .set("authorization", `Bearer ${KEY}`);+ if (method !== "get" && method !== "delete")+ req = req.send({ name: "Digest" });+ const response = await req;+ expect(response.status).toBe(200);+ expect(mocks.upstreamFetch).toHaveBeenCalledTimes(1);+ const { url, init } = upstream();+ expect(url).toBe(`https://exchange.test${upstreamPath}`);+ expect(init.headers).toMatchObject({+ "x-exchange-team-id": "team-connectors",+ });+ expect(init.headers).not.toHaveProperty("x-exchange-connectors");+ },+ );+it("never forwards a caller's own x-exchange-connectors header", async () => {keyResolvesAs({});// A route open without the flag: the header must still not reach Exchange.diff --git a/apps/api/src/routes/exchange.ts b/apps/api/src/routes/exchange.tsindex e203447c6..f7bf3f16d 100644--- a/apps/api/src/routes/exchange.ts+++ b/apps/api/src/routes/exchange.ts@@ -253,25 +253,26 @@ exchangeRouter.delete(wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS)),);+// Every team may list, read and write its own skills; Exchange scopes them by the stamped team.exchangeRouter.get("/team-skills{/*path}",authMiddleware(RateLimiterMode.Labs),- wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS)),+ wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS, { requiresRetrieveFlag: false })),);exchangeRouter.post("/team-skills{/*path}",authMiddleware(RateLimiterMode.Labs),- wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS)),+ wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS, { requiresRetrieveFlag: false })),);exchangeRouter.patch("/team-skills{/*path}",authMiddleware(RateLimiterMode.Labs),- wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS)),+ wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS, { requiresRetrieveFlag: false })),);exchangeRouter.delete("/team-skills{/*path}",authMiddleware(RateLimiterMode.Labs),- wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS)),+ wrap(exchangeProxy(ANALYTICS_TIMEOUT_MS, { requiresRetrieveFlag: false })),);exchangeRouter.post(