Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

feat(api): accept objective in Alexandria feedback (#4877)

Nicolas9892f0182a1b
diff --git a/apps/api/src/__tests__/snips/v2/alexandria-feedback.test.ts b/apps/api/src/__tests__/snips/v2/alexandria-feedback.test.ts
index b902f12ca..226df7d6d 100644
--- a/apps/api/src/__tests__/snips/v2/alexandria-feedback.test.ts
+++ b/apps/api/src/__tests__/snips/v2/alexandria-feedback.test.ts
@@ -72,6 +72,7 @@ describeIf(TEST_PRODUCTION)("Alexandria session feedback", () => {
requested_host: "sam.gov",
requested_functionality: body.requestedWebsite.requestedFunctionality,
rationale: body.rationale,
+ objective: null,
origin: "api",
integration: null,
schema_version: 2,
@@ -112,8 +113,10 @@ describeIf(TEST_PRODUCTION)("Alexandria session feedback", () => {
why: "The second page request timed out.",
},
];
+ const objective = "Build a list of open federal IT contracts to bid on.";
const response = await submit({
...body,
+ objective,
providerFeedback,
capabilityFeedback,
integration: "cli",
@@ -125,6 +128,7 @@ describeIf(TEST_PRODUCTION)("Alexandria session feedback", () => {
await feedbackRows(feedbackId);
expect(parent).toMatchObject({
rationale: body.rationale,
+ objective,
integration: "cli",
});
expect(providers).toEqual(
@@ -172,6 +176,12 @@ describeIf(TEST_PRODUCTION)("Alexandria session feedback", () => {
expect(response.body.feedbackErrorCode).toBe("INVALID_BODY");
});
+ it("rejects a blank objective", async () => {
+ const response = await submit({ ...body, objective: " " });
+ expect(response.statusCode).toBe(400);
+ expect(response.body.feedbackErrorCode).toBe("INVALID_BODY");
+ });
+
it("requires requested functionality for a new capability request", async () => {
const response = await submit({
...body,
diff --git a/apps/api/src/controllers/v2/feedback/alexandria-schema.ts b/apps/api/src/controllers/v2/feedback/alexandria-schema.ts
index 5f0a5ae9e..d77953ca6 100644
--- a/apps/api/src/controllers/v2/feedback/alexandria-schema.ts
+++ b/apps/api/src/controllers/v2/feedback/alexandria-schema.ts
@@ -47,6 +47,8 @@ export const alexandriaFeedbackSchema = z
requestedFunctionality: detail,
}),
rationale: detail,
+ // Optional so clients released before the field keep working.
+ objective: detail.optional(),
providerFeedback: z.array(providerFeedback).max(20).optional(),
capabilityFeedback: z.array(capabilityFeedback).max(20).optional(),
origin: z.string().trim().min(1).max(100).default("api"),
diff --git a/apps/api/src/controllers/v2/feedback/alexandria.integration.test.ts b/apps/api/src/controllers/v2/feedback/alexandria.integration.test.ts
index be8a3efdb..2adb76b6d 100644
--- a/apps/api/src/controllers/v2/feedback/alexandria.integration.test.ts
+++ b/apps/api/src/controllers/v2/feedback/alexandria.integration.test.ts
@@ -28,6 +28,7 @@ CREATE TABLE alexandria_feedback (
requested_host text GENERATED ALWAYS AS (lower(substring(requested_url from '^[A-Za-z][A-Za-z0-9+.-]*://(?:[^@/?#]*@)?([^/?#:]+)'))) STORED,
requested_functionality text NOT NULL,
rationale text NOT NULL,
+ objective text,
origin text,
integration text,
schema_version integer NOT NULL DEFAULT 2,
@@ -142,6 +143,7 @@ suite("Alexandria feedback HTTP and PostgreSQL persistence", () => {
requested_functionality:
minimal.requestedWebsite.requestedFunctionality,
rationale: minimal.rationale,
+ objective: null,
origin: "api",
integration: null,
schema_version: 2,
@@ -183,8 +185,10 @@ suite("Alexandria feedback HTTP and PostgreSQL persistence", () => {
why: "The second page request timed out.",
},
];
+ const objective = "Build a list of open federal IT contracts to bid on.";
const response = await submit({
...minimal,
+ objective,
providerFeedback,
capabilityFeedback,
integration: "cli",
@@ -192,13 +196,14 @@ suite("Alexandria feedback HTTP and PostgreSQL persistence", () => {
expect(response.status).toBe(200);
const feedbackId = response.body.feedbackId;
const parent = await pool.query(
- "SELECT rating, rationale, integration FROM alexandria_feedback WHERE id = $1",
+ "SELECT rating, rationale, objective, integration FROM alexandria_feedback WHERE id = $1",
[feedbackId],
);
expect(parent.rows).toEqual([
{
rating: minimal.rating,
rationale: minimal.rationale,
+ objective,
integration: "cli",
},
]);
diff --git a/apps/api/src/controllers/v2/feedback/alexandria.test.ts b/apps/api/src/controllers/v2/feedback/alexandria.test.ts
index 82a7072d7..d9648d691 100644
--- a/apps/api/src/controllers/v2/feedback/alexandria.test.ts
+++ b/apps/api/src/controllers/v2/feedback/alexandria.test.ts
@@ -102,6 +102,7 @@ it.each(["good", "partial", "bad"])(
requested_functionality:
minimal.requestedWebsite.requestedFunctionality,
rationale: minimal.rationale,
+ objective: null,
origin: "api",
integration: null,
schema_version: 2,
@@ -112,6 +113,19 @@ it.each(["good", "partial", "bad"])(
},
);
+it("records the trimmed objective behind the session", async () => {
+ const response = await submit({
+ ...minimal,
+ objective: " Build a list of open federal IT contracts to bid on. ",
+ });
+ expect(response.status).toBe(200);
+ expect(parentRows()).toEqual([
+ expect.objectContaining({
+ objective: "Build a list of open federal IT contracts to bid on.",
+ }),
+ ]);
+});
+
it.each(["endpoint", "rating", "requestedWebsite", "rationale"])(
"requires %s",
async field => {
@@ -179,6 +193,9 @@ it.each([
{ requestedVertical: "government" },
{ rationale: " " },
{ rationale: "x".repeat(2001) },
+ { objective: " " },
+ { objective: "x".repeat(2001) },
+ { objective: ["Find contracts"] },
{ rating: true },
{ jobId },
{ endpoint: "search", jobId },
diff --git a/apps/api/src/controllers/v2/feedback/alexandria.ts b/apps/api/src/controllers/v2/feedback/alexandria.ts
index 9b10bc772..4881fa3fe 100644
--- a/apps/api/src/controllers/v2/feedback/alexandria.ts
+++ b/apps/api/src/controllers/v2/feedback/alexandria.ts
@@ -95,6 +95,7 @@ export async function recordAlexandriaFeedback(
requested_url: body.requestedWebsite.url,
requested_functionality: body.requestedWebsite.requestedFunctionality,
rationale: body.rationale,
+ objective: body.objective ?? null,
origin: body.origin,
integration: body.integration ?? null,
schema_version: 2,
diff --git a/apps/api/src/db/schema/public.ts b/apps/api/src/db/schema/public.ts
index 4a4717a35..9351bd555 100644
--- a/apps/api/src/db/schema/public.ts
+++ b/apps/api/src/db/schema/public.ts
@@ -674,6 +674,7 @@ export const alexandria_feedback = pgTable(
),
requested_functionality: text("requested_functionality").notNull(),
rationale: text("rationale").notNull(),
+ objective: text("objective"),
origin: text("origin"),
integration: text("integration"),
schema_version: integer("schema_version").notNull().default(2),