Skip to content

Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥

fix(api/search): honor includeDomains by dropping site: parens (#4100)

firecrawl-spring[bot]aa85f190acff
diff --git a/apps/api/src/__tests__/lib/search-query-builder.test.ts b/apps/api/src/__tests__/lib/search-query-builder.test.ts
index 0922c76af..ae909f828 100644
--- a/apps/api/src/__tests__/lib/search-query-builder.test.ts
+++ b/apps/api/src/__tests__/lib/search-query-builder.test.ts
@@ -111,13 +111,24 @@ describe("Search Query Builder", () => {
expect(result.categoryMap.size).toBe(0);
});
- it("should add include domain filters", () => {
+ it("should add include domain filters without a parenthesized group", () => {
+ // Bare `site:` operators (no wrapping parens): some search backends drop
+ // a parenthesized `(site:...)` group, which would leak off-domain results.
const result = buildSearchQuery("web scraping", undefined, {
includeDomains: ["firecrawl.dev", "docs.firecrawl.dev"],
});
expect(result.query).toBe(
- "web scraping (site:firecrawl.dev OR site:docs.firecrawl.dev)",
+ "web scraping site:firecrawl.dev OR site:docs.firecrawl.dev",
);
+ expect(result.query).not.toContain("(");
+ expect(result.categoryMap.size).toBe(0);
+ });
+
+ it("should add a single include domain filter without parens or OR", () => {
+ const result = buildSearchQuery("web scraping", undefined, {
+ includeDomains: ["linkedin.com"],
+ });
+ expect(result.query).toBe("web scraping site:linkedin.com");
expect(result.categoryMap.size).toBe(0);
});
@@ -145,7 +156,7 @@ describe("Search Query Builder", () => {
includeDomains: ["firecrawl.dev"],
});
expect(result.query).toBe(
- "web scraping (site:github.com) (site:firecrawl.dev)",
+ "web scraping (site:github.com) site:firecrawl.dev",
);
expect(result.categoryMap.get("github.com")).toBe("github");
});
diff --git a/apps/api/src/lib/search-query-builder.ts b/apps/api/src/lib/search-query-builder.ts
index 8f1b2797b..8a25aa1a1 100644
--- a/apps/api/src/lib/search-query-builder.ts
+++ b/apps/api/src/lib/search-query-builder.ts
@@ -102,9 +102,11 @@ export function buildSearchQuery(
const includeDomains = domainOptions.includeDomains ?? [];
const excludeDomains = domainOptions.excludeDomains ?? [];
+ // Bare `site:` operators, not a parenthesized group: some backends don't
+ // parse `(site:foo.com)` and drop the filter, leaking off-domain results.
const includeFilter =
includeDomains.length > 0
- ? " (" + includeDomains.map(domain => `site:${domain}`).join(" OR ") + ")"
+ ? " " + includeDomains.map(domain => `site:${domain}`).join(" OR ")
: "";
const excludeFilter =
excludeDomains.length > 0