Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥
TypeScript aiai-agentsai-crawlerai-scrapingai-searchcrawlerdata-extractionhtml-to-markdownllmmarkdownscraperscrapingweb-crawlerweb-dataweb-data-extractionweb-scraperweb-scrapingweb-searchwebscraping
fix(api): reject self-hosted scrape interact clearly
Yufeng Heacd70669af25
diff --git a/apps/api/src/controllers/v2/__tests__/scrape-browser.test.ts b/apps/api/src/controllers/v2/__tests__/scrape-browser.test.tsnew file mode 100644index 000000000..4d88c1da5--- /dev/null+++ b/apps/api/src/controllers/v2/__tests__/scrape-browser.test.ts@@ -0,0 +1,104 @@+import type { Response } from "express";+import { vi } from "vitest";+import { config } from "../../../config";+import { supabaseGetScrapeById } from "../../../lib/supabase-jobs";+import { scrapeInteractController } from "../scrape-browser";+import type { RequestWithAuth } from "../types";++vi.mock("uuid", () => ({+ v7: vi.fn(() => "session-123"),+}));++vi.mock("../../../lib/supabase-jobs", () => ({+ supabaseGetScrapeById: vi.fn(),+}));++vi.mock("../../../lib/browser-sessions", () => ({+ insertBrowserSession: vi.fn(),+ getBrowserSession: vi.fn(),+ updateBrowserSessionActivity: vi.fn(() => Promise.resolve()),+ updateBrowserSessionCreditsUsed: vi.fn(() => Promise.resolve()),+ updateBrowserSessionScrapeId: vi.fn(() => Promise.resolve()),+ claimBrowserSessionDestroyed: vi.fn(),+ invalidateActiveBrowserSessionCount: vi.fn(() => Promise.resolve()),+ getBrowserSessionFromScrape: vi.fn(),+ markBrowserSessionUsedPrompt: vi.fn(() => Promise.resolve()),+ didBrowserSessionUsePrompt: vi.fn(),+ clearBrowserSessionPromptFlag: vi.fn(() => Promise.resolve()),+}));++vi.mock("../../../lib/concurrency-limit", () => ({+ getConcurrencyLimitActiveJobsCount: vi.fn(),+ pushConcurrencyLimitActiveJob: vi.fn(() => Promise.resolve()),+ removeConcurrencyLimitActiveJob: vi.fn(() => Promise.resolve()),+}));++vi.mock("../../../lib/scrape-interact/browser-service-client", () => ({+ browserServiceRequest: vi.fn(),+ BrowserServiceError: class BrowserServiceError extends Error {+ status = 500;+ },+}));++vi.mock("../../../lib/scrape-interact/browser-agent", () => ({+ executePromptViaBrowserAgent: vi.fn(),+ executeCodeViaBrowserSession: vi.fn(),+}));++vi.mock("../../../lib/browser-session-activity", () => ({+ enqueueBrowserSessionActivity: vi.fn(),+}));++vi.mock("../../../services/billing/credit_billing", () => ({+ billTeam: vi.fn(() => Promise.resolve()),+}));++vi.mock("../../../services/logging/log_job", () => ({+ logRequest: vi.fn(),+}));++vi.mock("../../../services/autumn/autumn.service", () => ({+ autumnService: {+ checkCredits: vi.fn(),+ },+}));++describe("scrapeInteractController", () => {+ const previousUseDbAuthentication = config.USE_DB_AUTHENTICATION;++ const buildRes = () =>+ ({+ status: vi.fn().mockReturnThis(),+ json: vi.fn(),+ }) as unknown as Response;++ beforeEach(() => {+ vi.clearAllMocks();+ });++ afterEach(() => {+ config.USE_DB_AUTHENTICATION = previousUseDbAuthentication;+ });++ it("rejects self-hosted scrape interact before querying Supabase", async () => {+ config.USE_DB_AUTHENTICATION = false;++ const req = {+ params: { jobId: "scrape-123" },+ body: { prompt: "click the first result" },+ auth: { team_id: "team-123" },+ acuc: {},+ } as RequestWithAuth<{ jobId: string }, any, any>;+ const res = buildRes();++ await scrapeInteractController(req, res);++ expect(supabaseGetScrapeById).not.toHaveBeenCalled();+ expect(res.status).toHaveBeenCalledWith(501);+ expect(res.json).toHaveBeenCalledWith({+ success: false,+ error:+ "Scrape interact requires stored scrape context and is not available when database authentication is disabled.",+ });+ });+});diff --git a/apps/api/src/controllers/v2/scrape-browser.ts b/apps/api/src/controllers/v2/scrape-browser.tsindex 4decfde35..eb9129b64 100644--- a/apps/api/src/controllers/v2/scrape-browser.ts+++ b/apps/api/src/controllers/v2/scrape-browser.ts@@ -144,6 +144,14 @@ export async function scrapeInteractController(// --- Validate scrape ownership ---+ if (config.USE_DB_AUTHENTICATION !== true) {+ return res.status(501).json({+ success: false,+ error:+ "Scrape interact requires stored scrape context and is not available when database authentication is disabled.",+ });+ }+const scrape = (await supabaseGetScrapeById(scrapeId,)) as ScrapeContextRow | null;