Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥
TypeScript aiai-agentsai-crawlerai-scrapingai-searchcrawlerdata-extractionhtml-to-markdownllmmarkdownscraperscrapingweb-crawlerweb-dataweb-data-extractionweb-scraperweb-scrapingweb-searchwebscraping
fix(elixir-sdk): return error tuple from parse_file/3 instead of raising
Devin AIb59ac6f93b08
diff --git a/apps/elixir-sdk/lib/firecrawl.ex b/apps/elixir-sdk/lib/firecrawl.exindex b38318ce7..ba32d0d28 100644--- a/apps/elixir-sdk/lib/firecrawl.ex+++ b/apps/elixir-sdk/lib/firecrawl.ex@@ -130,6 +130,29 @@ defmodule Firecrawl doEnum.join([first | Enum.map(rest, &String.capitalize/1)])end+ defp fetch_file_field(file, key) do+ case Keyword.fetch(file, key) do+ {:ok, _value} = ok -> ok+ :error -> {:error, %ArgumentError{message: "missing required file field: #{key}"}}+ end+ end++ defp validate_filename(filename) do+ if is_binary(filename) and filename != "" do+ :ok+ else+ {:error, %ArgumentError{message: "filename cannot be empty"}}+ end+ end++ defp validate_data(data) do+ if is_nil(data) do+ {:error, %ArgumentError{message: "file data cannot be empty"}}+ else+ :ok+ end+ end+@doc """Cancel an agent job@@ -950,19 +973,13 @@ defmodule Firecrawl do"""@spec parse_file(keyword(), keyword(), keyword()) :: response()def parse_file(file, params \\ [], opts \\ []) do- with {:ok, params} <- NimbleOptions.validate(params, @parse_file_schema) do- filename = Keyword.fetch!(file, :filename)- data = Keyword.fetch!(file, :data)+ with {:ok, params} <- NimbleOptions.validate(params, @parse_file_schema),+ {:ok, filename} <- fetch_file_field(file, :filename),+ :ok <- validate_filename(filename),+ {:ok, data} <- fetch_file_field(file, :data),+ :ok <- validate_data(data) docontent_type = Keyword.get(file, :content_type)- if not is_binary(filename) or filename == "" do- raise ArgumentError, "filename cannot be empty"- end-- if is_nil(data) do- raise ArgumentError, "file data cannot be empty"- end-file_part =case content_type donil -> {data, filename: filename}diff --git a/apps/elixir-sdk/test/firecrawl_test.exs b/apps/elixir-sdk/test/firecrawl_test.exsindex f6c6b6daa..acc996900 100644--- a/apps/elixir-sdk/test/firecrawl_test.exs+++ b/apps/elixir-sdk/test/firecrawl_test.exs@@ -124,22 +124,24 @@ defmodule FirecrawlTest do"Expected connection error, got validation error: #{inspect(err)}"end- test "parse_file raises ArgumentError when filename is empty" do+ test "parse_file returns error tuple when filename is empty" doApplication.put_env(:firecrawl, :api_key, "test-key")on_exit(fn -> Application.delete_env(:firecrawl, :api_key) end)- assert_raise ArgumentError, ~r/filename cannot be empty/, fn ->- Firecrawl.parse_file([filename: "", data: "x"])- end+ assert {:error, %ArgumentError{message: msg}} =+ Firecrawl.parse_file([filename: "", data: "x"])++ assert msg =~ "filename cannot be empty"end- test "parse_file raises ArgumentError when data is nil" do+ test "parse_file returns error tuple when data is nil" doApplication.put_env(:firecrawl, :api_key, "test-key")on_exit(fn -> Application.delete_env(:firecrawl, :api_key) end)- assert_raise ArgumentError, ~r/file data cannot be empty/, fn ->- Firecrawl.parse_file([filename: "doc.pdf", data: nil])- end+ assert {:error, %ArgumentError{message: msg}} =+ Firecrawl.parse_file([filename: "doc.pdf", data: nil])++ assert msg =~ "file data cannot be empty"endtest "parse_file rejects unknown options" do