Supercharge your AI agents with data from the web and beyond. Building the library for superintelligence. 🔥
TypeScript aiai-agentsai-crawlerai-scrapingai-searchcrawlerdata-extractionhtml-to-markdownllmmarkdownscraperscrapingweb-crawlerweb-dataweb-data-extractionweb-scraperweb-scrapingweb-searchwebscraping
fix(billing): source unverified agent-key cap from Autumn, not ACUC (#3870)
firecrawl-spring[bot]ea63cd925c77
diff --git a/apps/api/src/__tests__/routes/check-credits-middleware.test.ts b/apps/api/src/__tests__/routes/check-credits-middleware.test.tsindex 64e08acca..56789bbac 100644--- a/apps/api/src/__tests__/routes/check-credits-middleware.test.ts+++ b/apps/api/src/__tests__/routes/check-credits-middleware.test.ts@@ -8,6 +8,10 @@ vi.mock("../../services/autumn/autumn.service", () => ({CREDITS_FEATURE_ID: "CREDITS",}));+vi.mock("../../services/autumn/usage", () => ({+ getTeamBalance: vi.fn(),+}));+vi.mock("../../lib/http-metrics", () => ({httpRequestDurationSeconds: { observe: vi.fn() },getRoutePattern: vi.fn(() => "/v1/crawl"),@@ -29,10 +33,14 @@ vi.mock("geoip-country", () => ({ lookup: vi.fn(() => null) }));import { checkCreditsMiddleware } from "../../routes/shared";import { autumnService } from "../../services/autumn/autumn.service";+import { getTeamBalance } from "../../services/autumn/usage";const checkCreditsMock = autumnService.checkCredits as MockedFunction<typeof autumnService.checkCredits>;+const getTeamBalanceMock = getTeamBalance as MockedFunction<+ typeof getTeamBalance+>;function buildReq(overrides: any = {}): any {return {@@ -104,3 +112,63 @@ describe("checkCreditsMiddleware – Autumn overage handling", () => {expect(req.body.limit).toBe(5);});});++describe("checkCreditsMiddleware – unverified agent-key 50-credit cap", () => {+ beforeEach(() => {+ vi.clearAllMocks();+ });++ function buildUnverifiedReq(overrides: any = {}) {+ return buildReq({+ acuc: {+ adjusted_credits_used: 0,+ _agentSponsor: {+ status: "pending",+ verification_deadline: new Date(+ Date.now() + 86_400_000,+ ).toISOString(),+ },+ },+ ...overrides,+ });+ }++ it("blocks with 402 when Autumn usage has reached the 50-credit cap", async () => {+ getTeamBalanceMock.mockResolvedValue({ usage: 50 } as any);++ const req = buildUnverifiedReq();+ const { res } = await runMiddleware(req);++ expect(res.status).toHaveBeenCalledWith(402);+ expect(res.json).toHaveBeenCalledWith(+ expect.objectContaining({+ error: "unverified_credit_limit_reached",+ credits_used: 50,+ }),+ );+ // The main Autumn credit check must not run once the cap is hit.+ expect(checkCreditsMock).not.toHaveBeenCalled();+ });++ it("allows the request when Autumn usage is under the cap", async () => {+ getTeamBalanceMock.mockResolvedValue({ usage: 10 } as any);+ checkCreditsMock.mockResolvedValue({ allowed: true, remaining: 100 });++ const req = buildUnverifiedReq();+ const { res, nextErr } = await runMiddleware(req);++ expect(res.status).not.toHaveBeenCalled();+ expect(nextErr).toBeUndefined();+ expect(req.agentIndexOnly).toBe(true);+ });++ it("fails open (does not block) when the Autumn balance lookup throws", async () => {+ getTeamBalanceMock.mockRejectedValue(new Error("autumn down"));+ checkCreditsMock.mockResolvedValue({ allowed: true, remaining: 100 });++ const req = buildUnverifiedReq();+ const { res } = await runMiddleware(req);++ expect(res.status).not.toHaveBeenCalled();+ });+});diff --git a/apps/api/src/routes/shared.ts b/apps/api/src/routes/shared.tsindex c205eb085..f3c02ab1d 100644--- a/apps/api/src/routes/shared.ts+++ b/apps/api/src/routes/shared.ts@@ -28,6 +28,7 @@ import {autumnService,CREDITS_FEATURE_ID,} from "../services/autumn/autumn.service";+import { getTeamBalance } from "../services/autumn/usage";export function checkCreditsMiddleware(_minimum?: number,@@ -70,16 +71,33 @@ export function checkCreditsMiddleware(});}- // Enforce 50-credit cap for unverified agent keys+ // Enforce 50-credit cap for unverified agent keys. Autumn is the+ // source of truth for credit usage now (not ACUC.adjusted_credits_used):+ // getTeamBalance().usage is the team's credits used this period. If+ // Autumn is unavailable we fail open (skip the cap), matching the+ // Autumn-outage behavior of the main credit check below.const UNVERIFIED_CREDIT_LIMIT = 50;- if (req.acuc.adjusted_credits_used >= UNVERIFIED_CREDIT_LIMIT) {+ let unverifiedCreditsUsed: number | null = null;+ try {+ const balance = await getTeamBalance(req.auth.team_id);+ unverifiedCreditsUsed = balance?.usage ?? 0;+ } catch (balanceError) {+ logger.warn(+ "Failed to fetch Autumn balance for unverified agent-key cap; failing open",+ { error: balanceError, teamId: req.auth.team_id },+ );+ }+ if (+ unverifiedCreditsUsed !== null &&+ unverifiedCreditsUsed >= UNVERIFIED_CREDIT_LIMIT+ ) {return res.status(402).json({success: false,error: "unverified_credit_limit_reached",message:"This agent key has used its 50 unverified credits. Ask the account holder to confirm the key to unlock full access.",credit_limit: UNVERIFIED_CREDIT_LIMIT,- credits_used: req.acuc.adjusted_credits_used,+ credits_used: unverifiedCreditsUsed,sponsor_status: "pending",login_url: "https://firecrawl.dev/signin",upgrade_url: "https://firecrawl.dev/pricing",