Skip to content

Firefly III: a personal finances manager

Remove mago analyse, fix update check.

James Cole091f264f3eef
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 8e85e4be45..8c2b4b61ab 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -177,7 +177,7 @@ jobs:
rm -rf vendor composer.lock
composer update --no-scripts --no-plugins -q
mago format || true
- mago analyze --reporting-format=github || true
+ # mago analyze --reporting-format=github || true
sudo chown -R runner:docker resources/lang
.ci/phpcs.sh || true
- name: Calculate variables
diff --git a/app/Services/FireflyIIIOrg/Update/GitHubUpdateRequest.php b/app/Services/FireflyIIIOrg/Update/GitHubUpdateRequest.php
index 5b6ebcbc20..3b83be7cff 100644
--- a/app/Services/FireflyIIIOrg/Update/GitHubUpdateRequest.php
+++ b/app/Services/FireflyIIIOrg/Update/GitHubUpdateRequest.php
@@ -63,12 +63,12 @@ class GitHubUpdateRequest implements UpdateRequestInterface
// if current version is "develop", compare date.
if (str_contains($currentVersion, 'develop')) {
Log::debug(sprintf('Compare with current version "%s", built on %s', $currentVersion, $currentBuild->format('Y-m-d H:i')));
- if ($currentBuild->gt($newest['published_at'])) {
+ if ($currentBuild->lt($newest['published_at'])) {
Log::debug(sprintf('Current build %s is older than newest build %s, so a new release is available.', $currentBuild->format('Y-m-d H:i'), $newest['published_at']->format('Y-m-d H:i')));
$response->setNewVersionAvailable(true);
return $response;
}
- if ($currentBuild->lt($newest['published_at'])) {
+ if ($currentBuild->gt($newest['published_at'])) {
Log::debug(sprintf('Current build %s is newer than newest build %s, so NO new release is available.', $currentBuild->format('Y-m-d H:i'), $newest['published_at']->format('Y-m-d H:i')));
$response->setNewVersionAvailable(false);
return $response;