Skip to content

Firefly III: a personal finances manager

Fix https://github.com/firefly-iii/firefly-iii/issues/12757

James Cole22518bfa02c4
diff --git a/changelog.md b/changelog.md
index f9274afdd3..5973faa4dd 100644
--- a/changelog.md
+++ b/changelog.md
@@ -3,6 +3,11 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).
+## v6.7.2 - 2026-09-16
+
+### Fixed
+- #12757
+
## v6.7.1 - 2026-09-15
<!-- summary: This release introduces a new layout and fixes many bugs and security issues. -->
diff --git a/public/v1/js/ff/list/groups.js b/public/v1/js/ff/list/groups.js
index 7d8f0f81a9..fc7d2b38a3 100644
--- a/public/v1/js/ff/list/groups.js
+++ b/public/v1/js/ff/list/groups.js
@@ -22,8 +22,8 @@ var count = 0;
$(document).ready(function () {
updateListButtons();
- $('.clone-transaction').click(cloneTransaction);
- $('.clone-transaction-and-edit').click(cloneTransactionAndEdit);
+ $('.clone-transaction').on('click', cloneTransaction);
+ $('.clone-transaction-and-edit').on('click', cloneTransactionAndEdit);
});
@@ -147,11 +147,10 @@ function updateActionButtons() {
}
function cloneTransaction(e) {
+ e.preventDefault();
var button = $(e.currentTarget);
var groupId = parseInt(button.data('id'));
-
$.post(cloneGroupUrl, {
- _token: token,
id: groupId
}).done(function (data) {
// lame but it works
@@ -163,6 +162,7 @@ function cloneTransaction(e) {
}
function cloneTransactionAndEdit(e) {
+ e.preventDefault();
var button = $(e.currentTarget);
var groupId = parseInt(button.data('id'));
diff --git a/resources/views/components/lists/groups-large.blade.php b/resources/views/components/lists/groups-large.blade.php
index 958f24d52e..a01597bace 100644
--- a/resources/views/components/lists/groups-large.blade.php
+++ b/resources/views/components/lists/groups-large.blade.php
@@ -90,8 +90,8 @@
<ul class="dropdown-menu" aria-labelledby="group_menu_{{ $group['id'] }}">
<li><a class="dropdown-item" href="{{ route('transactions.edit', [$group['id']]) }}?_from={{ urlencode($FF3_FROM) }}"><span class="bi bi-pencil"></span> {{ __('firefly.edit') }}</a></li>
<li><a class="dropdown-item" href="{{ route('transactions.delete', [$group['id']]) }}?_from={{ urlencode($FF3_FROM) }}"><span class="text-danger bi bi-trash"></span> {{ __('firefly.delete') }}</a></li>
- <li><a class="dropdown-item" href="#" data-id="{{ $group['id'] }}" class="clone-transaction"><span class="bi bi-copy"></span> {{ __('firefly.clone') }}</a></li>
- <li><a class="dropdown-item" href="#" data-id="{{ $group['id'] }}" class="clone-transaction-and-edit"><span class="bi bi-copy"></span> {{ __('firefly.clone_and_edit') }}</a></li>
+ <li><a class="dropdown-item clone-transaction" href="#" data-id="{{ $group['id'] }}"><span class="bi bi-copy"></span> {{ __('firefly.clone') }}</a></li>
+ <li><a class="dropdown-item clone-transaction-and-edit" href="#" data-id="{{ $group['id'] }}"><span class="bi bi-copy"></span> {{ __('firefly.clone_and_edit') }}</a></li>
</ul>
</div>
</td>
@@ -191,8 +191,8 @@
<li><a class="dropdown-item" href="{{ route('transactions.delete', [$group['id']]) }}?_from={{ urlencode($FF3_FROM) }}"><span class="text-danger bi bi-trash"></span> {{ __('firefly.delete') }}</a></li>
@endif
@if($transaction['transaction_type_type'] !== 'Reconciliation' and $transaction['transaction_type_type'] !== 'Opening balance' and $transaction['transaction_type_type'] !== 'Liability credit')
- <li><a class="dropdown-item" href="#" data-id="{{ $group['id'] }}" class="clone-transaction"><span class="bi bi-copy"></span> {{ __('firefly.clone') }}</a></li>
- <li><a class="dropdown-item" href="#" data-id="{{ $group['id'] }}" class="clone-transaction-and-edit"><span class="bi bi-copy"></span> {{ __('firefly.clone_and_edit') }}</a></li>
+ <li><a class="dropdown-item clone-transaction" href="#" data-id="{{ $group['id'] }}"><span class="bi bi-copy"></span> {{ __('firefly.clone') }}</a></li>
+ <li><a class="dropdown-item clone-transaction-and-edit" href="#" data-id="{{ $group['id'] }}"><span class="bi bi-copy"></span> {{ __('firefly.clone_and_edit') }}</a></li>
<li><a class="dropdown-item" href="{{ route('rules.create-from-journal', [$transaction['transaction_journal_id']]) }}"><span class="bi bi-shuffle"></span> {{ __('firefly.create_rule_from_transaction') }}</a></li>
@endif
</ul>
@@ -253,3 +253,10 @@
</tr>
</tfoot>
</table>
+@section('scripts')
+ @parent
+ <script nonce="{{ $JS_NONCE }}">
+ var cloneGroupUrl = '{{ route('transactions.clone') }}';
+ var cloneAndEditUrl = '{{ route('transactions.clone') }}?redirect=edit';
+ </script>
+ @endsection
diff --git a/resources/views/search/index.blade.php b/resources/views/search/index.blade.php
index 2e2dc5eaab..fa9609851b 100644
--- a/resources/views/search/index.blade.php
+++ b/resources/views/search/index.blade.php
@@ -137,8 +137,6 @@
var searchQuery = "{!! escape_for_js($fullQuery) !!}";
var searchUrl = "{{ route('search.search') }}?page={{ $page }}";
var searchPage = {{ $page }};
- var cloneGroupUrl = '{{ route('transactions.clone') }}';
- var cloneAndEditUrl = '{{ route('transactions.clone') }}?redirect=edit';
</script>
{{-- required for groups.twig --}}
<script type="text/javascript" src="v1/js/ff/list/groups.js?v={{ $FF_BUILD_TIME }}" nonce="{{ $JS_NONCE }}"></script>
diff --git a/resources/views/transactions/index.blade.php b/resources/views/transactions/index.blade.php
index ba0975066e..c7bc3817ec 100644
--- a/resources/views/transactions/index.blade.php
+++ b/resources/views/transactions/index.blade.php
@@ -109,8 +109,6 @@
{{-- required for groups.twig --}}
<script type="text/javascript" nonce="{{ $JS_NONCE }}">
var showAll = @if(is_countable($periods) && count($periods) > 0) false @else true @endif;
- var cloneGroupUrl = '{{ route('transactions.clone') }}';
- var cloneAndEditUrl = '{{ route('transactions.clone') }}?redirect=edit';
var categoryChartUrl = '{{ route('chart.transactions.categories', [$objectType, $start->format('Y-m-d'), $end->format('Y-m-d')]) }}';
var budgetChartUrl = '{{ route('chart.transactions.budgets', [$start->format('Y-m-d'), $end->format('Y-m-d')]) }}';
var destinationChartUrl = '{{ route('chart.transactions.destinationAccounts', [$objectType, $start->format('Y-m-d'), $end->format('Y-m-d')]) }}';
diff --git a/resources/views/transactions/show.blade.php b/resources/views/transactions/show.blade.php
index 5a4cef5954..bfe73cf8ed 100644
--- a/resources/views/transactions/show.blade.php
+++ b/resources/views/transactions/show.blade.php
@@ -560,8 +560,6 @@
<script type="text/javascript" nonce="{{ $JS_NONCE }}">
var modalDialogURL = '{{ route('transactions.link.modal', ['%JOURNAL%']) }}';
var groupURL = '{{ route('transactions.show',['%GROUP%']) }}';
- var cloneGroupUrl = '{{ route('transactions.clone') }}';
- var cloneAndEditUrl = '{{ route('transactions.clone') }}?redirect=edit';
var switchLinkUrl = '{{ route('transactions.link.switch') }}';
</script>