Firefly III: a personal finances manager
PHP accountingbudgetbudgetingbudgetscash-flowcashflowcredit-carddockerexpensesfinancefinancesfinanciallinuxmoneypaycheckpersonal-financephpphp7
Expand policy
James Coleb58d04f765b3
diff --git a/.github/security.md b/.github/security.mdindex 2fda91e7ba..d45fb246aa 100644--- a/.github/security.md+++ b/.github/security.md@@ -19,7 +19,7 @@ a security issue. Without an attack path, no dice.## Perceived security issues that are exempt from reporting-Due to a large number of irrelevant, noisy and uninformed AI-generated security advisories coming my way, reporting+Due to a large number of irrelevant, noisy and uninformed AI-generated security advisories coming the team's, reportingany the following security issues may result in a permanent ban from the Firefly III organization on GitHub.1. Any SSRF or DNS/hostname issues in any user provided URL field (webhooks, ntfy, SimpleFIN, Slack). It's by design@@ -33,6 +33,10 @@ also clear out other user's cached data. Purging deleted records may also removereferred to **non-existing** functions, templates and files. Including line numbers and code excerpts. Validate yourfindings before you report them to me.+In addition, please note that there are some well-known false positives that many models report as a vulnerability,+while in fact they are not. If you report one of these, you may be ignored now and in the future. Naturally, we will+not disclose them in this policy.+## Supported versionsOnly the latest Firefly III release is maintained. Applicable fixes, including security fixes, will not be backported todiff --git a/app/Api/V1/Controllers/Models/TransactionCurrency/UpdateController.php b/app/Api/V1/Controllers/Models/TransactionCurrency/UpdateController.phpindex 2ef137b8d3..2ba7f5c620 100644--- a/app/Api/V1/Controllers/Models/TransactionCurrency/UpdateController.php+++ b/app/Api/V1/Controllers/Models/TransactionCurrency/UpdateController.php@@ -89,7 +89,6 @@ final class UpdateController extends Controller/** @var CurrencyTransformer $transformer */$transformer = app(CurrencyTransformer::class);- $transformer->setParameters($this->parameters);$resource = new Item($currency, $transformer, 'currencies');diff --git a/app/Http/Controllers/Auth/TwoFactorController.php b/app/Http/Controllers/Auth/TwoFactorController.phpindex 3a71f8b254..6ad725caf4 100644--- a/app/Http/Controllers/Auth/TwoFactorController.php+++ b/app/Http/Controllers/Auth/TwoFactorController.php@@ -35,6 +35,7 @@ use Illuminate\Contracts\View\Factory;use Illuminate\Contracts\View\View;use Illuminate\Http\RedirectResponse;use Illuminate\Http\Request;+use Illuminate\Support\Facades\Auth;use Illuminate\Support\Facades\Log;use PragmaRX\Google2FALaravel\Support\Authenticator;use Psr\Container\ContainerExceptionInterface;@@ -89,6 +90,13 @@ final class TwoFactorController extends ControllerLog::channel('audit')->info(sprintf('User "%s" has had %d failed MFA attempts.', $user->email, $counter));event(new UserKeepsFailingMFA($user, $counter));}+ if($counter > 20) {+ // if the user keeps failing MFA, log them out.+ Log::channel('audit')->info(sprintf('User "%s" has had %d failed MFA attempts. Logging them out.', $user->email, $counter));+ Auth::guard()->logout();+ $request->session()->invalidate();+ $request->session()->regenerateToken();+ }unset($user);}