Skip to content

Firefly III: a personal finances manager

Fix var

James Colef44bf65fafa5
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 1c18188d80..aff7875aac 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -8,9 +8,10 @@ on:
required: true
default: 'develop'
quick:
+ type: boolean
description: 'Skip most checks. true or false'
required: true
- default: 'false'
+ default: false
phpversion:
description: 'PHP version'
required: true
@@ -35,7 +36,7 @@ jobs:
env:
version: ${{ github.event_name == 'schedule' && 'develop' || inputs.version }}
- quick: ${{ inputs.quick || 'false' }}
+ quick: ${{ inputs.quick || false }}
- name: Checkout
uses: actions/checkout@v7
with:
@@ -79,12 +80,12 @@ jobs:
php-version: ${{ github.event.inputs.phpversion || '8.5' }}
extensions: mbstring, intl, zip, bcmath
- name: Lint PHP
- if: ${{ inputs.quick != 'true' }}
+ if: ${{ inputs.quick != true }}
run: |
- if [[ "$quick" == "true" ]]; then
+ if [[ "$quick" == true ]]; then
echo "Will NOT run PHP lint"
fi
- if [[ "$quick" == "false" ]]; then
+ if [[ "$quick" == false ]]; then
echo "Will run PHP lint!"
php_lint_file()
{
@@ -107,10 +108,10 @@ jobs:
fi
fi
env:
- quick: ${{ inputs.quick || 'false' }}
+ quick: ${{ inputs.quick || false }}
- name: Code cleanup
id: code-cleanup
- if: ${{ inputs.quick != 'true' }}
+ if: ${{ inputs.quick != true }}
uses: JC5/firefly-iii-dev@main
with:
action: 'ff3:code'
@@ -124,8 +125,11 @@ jobs:
# install all packages etc.
rm -rf vendor composer.lock
composer update --no-scripts -q
+ if [[ "$quick" == false ]]; then
+ echo 'Will NOT run Mago Format, will not Lint, will not run PHPStan'
+ fi
- if [[ "$quick" == "false" ]]; then
+ if [[ "$quick" == false ]]; then
# format code.
echo "Will now run Mago Format"
./vendor/bin/mago format
@@ -142,7 +146,7 @@ jobs:
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- quick: ${{ inputs.quick || 'false' }}
+ quick: ${{ inputs.quick || false }}
- name: Lint Blade templates
run: |
if [[ "$quick" == "false" ]]; then
@@ -152,7 +156,7 @@ jobs:
rm .env
fi
env:
- quick: ${{ inputs.quick || 'false' }}
+ quick: ${{ inputs.quick || false }}
- name: Crowdin action
uses: crowdin/github-action@v2
with: