Skip to content

Firefly III: a personal finances manager

Fix https://github.com/firefly-iii/firefly-iii/issues/12401

James Colefaa532ec4698
diff --git a/app/Http/Requests/BillStoreRequest.php b/app/Http/Requests/BillStoreRequest.php
index 17ab1c55e1..e9810b0632 100644
--- a/app/Http/Requests/BillStoreRequest.php
+++ b/app/Http/Requests/BillStoreRequest.php
@@ -69,8 +69,8 @@ class BillStoreRequest extends FormRequest
{
return [
'name' => ['required', 'min:1', 'max:255', 'uniqueObjectForUser:bills,name'],
- 'amount_min' => ['required', new IsValidPositiveAmount()],
- 'amount_max' => ['required', new IsValidPositiveAmount()],
+ 'amount_min' => ['required', new IsValidPositiveAmount(),'lte:amount_max'],
+ 'amount_max' => ['required', new IsValidPositiveAmount(), 'gte:amount_min'],
'transaction_currency_id' => ['required', 'exists:transaction_currencies,id'],
'date' => ['required', 'date'],
'notes' => ['min:1', 'max:32768', 'nullable'],
diff --git a/app/Http/Requests/BillUpdateRequest.php b/app/Http/Requests/BillUpdateRequest.php
index 195e00b9e0..40eccb1711 100644
--- a/app/Http/Requests/BillUpdateRequest.php
+++ b/app/Http/Requests/BillUpdateRequest.php
@@ -73,8 +73,8 @@ class BillUpdateRequest extends FormRequest
return [
'name' => sprintf('required|min:1|max:255|uniqueObjectForUser:bills,name,%d', $bill->id),
- 'amount_min' => ['required', new IsValidPositiveAmount()],
- 'amount_max' => ['required', new IsValidPositiveAmount()],
+ 'amount_min' => ['required', new IsValidPositiveAmount(),'lte:amount_max'],
+ 'amount_max' => ['required', new IsValidPositiveAmount(), 'gte:amount_min'],
'transaction_currency_id' => ['required', 'exists:transaction_currencies,id'],
'date' => ['required', 'date'],
'bill_end_date' => ['nullable', 'date'],