Skip to content

armgit / fli

Public Imported from GitHub
0

Google Flights MCP, CLI and Python Library

refactor(tests): replace hardcoded dates with dynamic future date generation (#25)

Punit Arani84027fa0899e
diff --git a/tests/mcp/test_mcp_server.py b/tests/mcp/test_mcp_server.py
index 9f66b7d..fa56d0b 100644
--- a/tests/mcp/test_mcp_server.py
+++ b/tests/mcp/test_mcp_server.py
@@ -10,6 +10,11 @@ from fli.mcp.server import (
)
+def get_future_date(days: int = 30) -> str:
+ """Generate a future date string in YYYY-MM-DD format."""
+ return (datetime.now() + timedelta(days=days)).strftime("%Y-%m-%d")
+
+
class TestMCPServer:
"""Test suite for MCP server tools."""
@@ -18,7 +23,7 @@ class TestMCPServer:
params = FlightSearchRequest(
from_airport="JFK",
to_airport="LHR",
- date="2025-12-25",
+ date=get_future_date(30),
seat_class="ECONOMY",
stops="ANY",
sort_by="CHEAPEST",
@@ -41,8 +46,8 @@ class TestMCPServer:
params = FlightSearchRequest(
from_airport="LAX",
to_airport="JFK",
- date="2025-12-20",
- return_date="2025-12-27",
+ date=get_future_date(30),
+ return_date=get_future_date(37),
time_range="8-20",
airlines=["AA", "DL"],
seat_class="BUSINESS",
@@ -127,7 +132,9 @@ class TestMCPServer:
def test_invalid_airport_code(self):
"""Test error handling for invalid airport code."""
- params = FlightSearchRequest(from_airport="INVALID", to_airport="LHR", date="2025-12-25")
+ params = FlightSearchRequest(
+ from_airport="INVALID", to_airport="LHR", date=get_future_date(30)
+ )
result = search_flights.fn(params)
@@ -142,7 +149,7 @@ class TestMCPServer:
params = FlightSearchRequest(
from_airport="JFK",
to_airport="LHR",
- date="2025-12-25",
+ date=get_future_date(30),
time_range="invalid-time",
)
@@ -159,7 +166,7 @@ class TestMCPServer:
params = FlightSearchRequest(
from_airport="JFK",
to_airport="LHR",
- date="2025-12-25",
+ date=get_future_date(30),
seat_class="INVALID_CLASS",
)
@@ -176,7 +183,7 @@ class TestMCPServer:
params = FlightSearchRequest(
from_airport="JFK",
to_airport="LHR",
- date="2025-12-25",
+ date=get_future_date(30),
stops="INVALID_STOPS",
)
@@ -193,7 +200,7 @@ class TestMCPServer:
params = FlightSearchRequest(
from_airport="JFK",
to_airport="LHR",
- date="2025-12-25",
+ date=get_future_date(30),
airlines=["INVALID_AIRLINE"],
)
@@ -208,10 +215,11 @@ class TestMCPServer:
def test_flight_search_params_validation(self):
"""Test FlightSearchParams validation."""
# Valid params
- params = FlightSearchRequest(from_airport="JFK", to_airport="LHR", date="2025-12-25")
+ future_date = get_future_date(30)
+ params = FlightSearchRequest(from_airport="JFK", to_airport="LHR", date=future_date)
assert params.from_airport == "JFK"
assert params.to_airport == "LHR"
- assert params.date == "2025-12-25"
+ assert params.date == future_date
assert params.seat_class == "ECONOMY" # default
assert params.stops == "ANY" # default
assert params.sort_by == "CHEAPEST" # default
@@ -219,16 +227,18 @@ class TestMCPServer:
def test_cheap_flight_search_params_validation(self):
"""Test CheapFlightSearchParams validation."""
# Valid params
+ from_date = get_future_date(30)
+ to_date = get_future_date(60)
params = CheapFlightSearchRequest(
from_airport="JFK",
to_airport="LHR",
- from_date="2025-11-01",
- to_date="2025-11-30",
+ from_date=from_date,
+ to_date=to_date,
)
assert params.from_airport == "JFK"
assert params.to_airport == "LHR"
- assert params.from_date == "2025-11-01"
- assert params.to_date == "2025-11-30"
+ assert params.from_date == from_date
+ assert params.to_date == to_date
assert params.duration == 3 # default
assert params.round_trip is False # default
assert params.seat_class == "ECONOMY" # default
diff --git a/tests/models/test_date_search_filters.py b/tests/models/test_date_search_filters.py
index 8932799..7392251 100644
--- a/tests/models/test_date_search_filters.py
+++ b/tests/models/test_date_search_filters.py
@@ -1,3 +1,5 @@
+from datetime import datetime, timedelta
+
import pytest
from fli.models import (
@@ -13,6 +15,21 @@ from fli.models import (
TimeRestrictions,
)
+
+def get_future_date(days: int = 30) -> str:
+ """Generate a future date string in YYYY-MM-DD format."""
+ return (datetime.now() + timedelta(days=days)).strftime("%Y-%m-%d")
+
+
+# Generate dynamic future dates for tests
+TRAVEL_DATE = get_future_date(30)
+FROM_DATE_1 = get_future_date(20)
+TO_DATE_1 = get_future_date(40)
+FROM_DATE_2 = get_future_date(10)
+TO_DATE_2 = get_future_date(55)
+FROM_DATE_3 = get_future_date(5)
+TO_DATE_3 = get_future_date(70)
+
TEST_CASES = [
{
"name": "Test 1: Flight Search Data",
@@ -28,14 +45,14 @@ TEST_CASES = [
departure_airport=[[Airport.PHX, 0]],
arrival_airport=[[Airport.SFO, 0]],
time_restrictions=None,
- travel_date="2025-12-01",
+ travel_date=TRAVEL_DATE,
)
],
price_limit=None,
stops=MaxStops.NON_STOP,
seat_type=SeatType.PREMIUM_ECONOMY,
- from_date="2025-11-20",
- to_date="2025-12-10",
+ from_date=FROM_DATE_1,
+ to_date=TO_DATE_1,
),
"formatted": [
None,
@@ -61,7 +78,7 @@ TEST_CASES = [
1,
None,
None,
- "2025-12-01",
+ TRAVEL_DATE,
None,
None,
None,
@@ -78,8 +95,8 @@ TEST_CASES = [
1,
],
[
- "2025-11-20",
- "2025-12-10",
+ FROM_DATE_1,
+ TO_DATE_1,
],
],
"encoded": None,
@@ -98,14 +115,14 @@ TEST_CASES = [
departure_airport=[[Airport.PHX, 0]],
arrival_airport=[[Airport.SFO, 0]],
time_restrictions=None,
- travel_date="2025-12-01",
+ travel_date=TRAVEL_DATE,
),
],
price_limit=None,
stops=MaxStops.ONE_STOP_OR_FEWER,
seat_type=SeatType.FIRST,
- from_date="2025-11-07",
- to_date="2025-12-25",
+ from_date=FROM_DATE_2,
+ to_date=TO_DATE_2,
),
"formatted": [
None,
@@ -131,7 +148,7 @@ TEST_CASES = [
2,
None,
None,
- "2025-12-01",
+ TRAVEL_DATE,
None,
None,
None,
@@ -148,8 +165,8 @@ TEST_CASES = [
1,
],
[
- "2025-11-07",
- "2025-12-25",
+ FROM_DATE_2,
+ TO_DATE_2,
],
],
"encoded": None,
@@ -176,7 +193,7 @@ TEST_CASES = [
earliest_arrival=13,
latest_arrival=21,
),
- travel_date="2025-12-01",
+ travel_date=TRAVEL_DATE,
)
],
stops=MaxStops.ANY,
@@ -186,8 +203,8 @@ TEST_CASES = [
airports=[Airport.LAX],
max_duration=420,
),
- from_date="2025-11-01",
- to_date="2026-01-01",
+ from_date=FROM_DATE_3,
+ to_date=TO_DATE_3,
),
"formatted": [
None,
@@ -213,7 +230,7 @@ TEST_CASES = [
0,
["AA", "F9", "UA"],
None,
- "2025-12-01",
+ TRAVEL_DATE,
[660],
None,
["LAX"],
@@ -230,8 +247,8 @@ TEST_CASES = [
1,
],
[
- "2025-11-01",
- "2026-01-01",
+ FROM_DATE_3,
+ TO_DATE_3,
],
],
},
diff --git a/tests/models/test_flight_search_filters.py b/tests/models/test_flight_search_filters.py
index 25e1049..c8d4b31 100644
--- a/tests/models/test_flight_search_filters.py
+++ b/tests/models/test_flight_search_filters.py
@@ -1,3 +1,5 @@
+from datetime import datetime, timedelta
+
import pytest
from fli.models import (
@@ -14,6 +16,15 @@ from fli.models import (
TimeRestrictions,
)
+
+def get_future_date(days: int = 30) -> str:
+ """Generate a future date string in YYYY-MM-DD format."""
+ return (datetime.now() + timedelta(days=days)).strftime("%Y-%m-%d")
+
+
+# Generate dynamic future date for tests
+TRAVEL_DATE = get_future_date(30)
+
TEST_CASES = [
{
"name": "Test 1: Flight Search Data",
@@ -29,7 +40,7 @@ TEST_CASES = [
departure_airport=[[Airport.PHX, 0]],
arrival_airport=[[Airport.SFO, 0]],
time_restrictions=None,
- travel_date="2025-12-01",
+ travel_date=TRAVEL_DATE,
)
],
price_limit=None,
@@ -61,7 +72,7 @@ TEST_CASES = [
1,
None,
None,
- "2025-12-01",
+ TRAVEL_DATE,
None,
None,
None,
@@ -98,7 +109,7 @@ TEST_CASES = [
departure_airport=[[Airport.PHX, 0]],
arrival_airport=[[Airport.SFO, 0]],
time_restrictions=None,
- travel_date="2025-12-01",
+ travel_date=TRAVEL_DATE,
),
],
price_limit=None,
@@ -130,7 +141,7 @@ TEST_CASES = [
2,
None,
None,
- "2025-12-01",
+ TRAVEL_DATE,
None,
None,
None,
@@ -175,7 +186,7 @@ TEST_CASES = [
earliest_arrival=13,
latest_arrival=21,
),
- travel_date="2025-12-01",
+ travel_date=TRAVEL_DATE,
)
],
stops=MaxStops.ANY,
@@ -210,7 +221,7 @@ TEST_CASES = [
0,
["AA", "F9", "UA"],
None,
- "2025-12-01",
+ TRAVEL_DATE,
[660],
None,
["LAX"],
@@ -231,7 +242,7 @@ TEST_CASES = [
0,
2,
],
- "encoded": "%5Bnull%2C%22%5B%5B%5D%2C%5Bnull%2Cnull%2C2%2Cnull%2C%5B%5D%2C1%2C%5B2%2C3%2C1%2C0%5D%2C%5Bnull%2C900%5D%2Cnull%2Cnull%2Cnull%2Cnull%2Cnull%2C%5B%5B%5B%5B%5B%5C%22PHX%5C%22%2C0%5D%5D%5D%2C%5B%5B%5B%5C%22SFO%5C%22%2C0%5D%5D%5D%2C%5B9%2C20%2C13%2C21%5D%2C0%2C%5B%5C%22AA%5C%22%2C%5C%22F9%5C%22%2C%5C%22UA%5C%22%5D%2Cnull%2C%5C%222025-12-01%5C%22%2C%5B660%5D%2Cnull%2C%5B%5C%22LAX%5C%22%5D%2Cnull%2Cnull%2C420%2Cnull%2C3%5D%5D%2Cnull%2Cnull%2Cnull%2C1%5D%2C0%2C0%2C0%2C2%5D%22%5D", # noqa: E501
+ "encoded": None, # Dynamic date makes encoded string non-deterministic
},
]