Skip to content

armgit / floci

Public Imported from GitHub
0

Light, fluffy, and always free - The AWS Local Emulator alternative

feat(cloudtrail): support empty lookup events (#1603)

Jason van Zyl2cca03bf25a4
diff --git a/src/main/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailJsonHandler.java b/src/main/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailJsonHandler.java
index f6375cbf2e..746639493c 100644
--- a/src/main/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailJsonHandler.java
+++ b/src/main/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailJsonHandler.java
@@ -35,6 +35,7 @@ public class CloudTrailJsonHandler {
case "DeleteTrail" -> deleteTrail(request, region);
case "GetTrailStatus" -> getTrailStatus(request, region);
case "PutEventSelectors" -> putEventSelectors(request, region);
+ case "LookupEvents" -> lookupEvents(request, region);
default -> throw new AwsException("UnsupportedOperation",
"Operation " + action + " is not supported.", 400);
};
@@ -102,6 +103,12 @@ public class CloudTrailJsonHandler {
return Response.ok(mapper.createObjectNode()).build();
}
+ private Response lookupEvents(JsonNode request, String region) {
+ ObjectNode response = mapper.createObjectNode();
+ response.putArray("Events");
+ return Response.ok(response).build();
+ }
+
private ObjectNode trailNode(CloudTrailTrail trail) {
ObjectNode node = mapper.createObjectNode();
node.put("Name", trail.getName());
diff --git a/src/test/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailIntegrationTest.java b/src/test/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailIntegrationTest.java
index 795d0eb0e8..10c5396e92 100644
--- a/src/test/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailIntegrationTest.java
+++ b/src/test/java/io/github/hectorvent/floci/services/cloudtrail/CloudTrailIntegrationTest.java
@@ -165,6 +165,26 @@ class CloudTrailIntegrationTest {
.statusCode(200);
}
+ @Test
+ void lookupEventsReturnsEmptyEventPage() {
+ given()
+ .header("X-Amz-Target", TARGET_PREFIX + "LookupEvents")
+ .contentType(CONTENT_TYPE)
+ .body("""
+ {
+ "LookupAttributes": [
+ {"AttributeKey": "EventName", "AttributeValue": "CreateBucket"}
+ ],
+ "MaxResults": 10
+ }
+ """)
+ .when()
+ .post("/")
+ .then()
+ .statusCode(200)
+ .body("Events", hasSize(0));
+ }
+
@Test
void trailProvisioningLifecycleWorksWithBucketNotificationsAndQueuePolicy() {
String bucket = "cloudtrail-audit-feed-bucket";