Light, fluffy, and always free - The AWS Local Emulator alternative
fix(kinesis): handle minimum partition key hash (#2950)
Niels Kootstra30b8f88467ee
diff --git a/src/main/java/io/github/hectorvent/floci/services/kinesis/KinesisService.java b/src/main/java/io/github/hectorvent/floci/services/kinesis/KinesisService.javaindex 72b4ba42d3..d4807bceb8 100644--- a/src/main/java/io/github/hectorvent/floci/services/kinesis/KinesisService.java+++ b/src/main/java/io/github/hectorvent/floci/services/kinesis/KinesisService.java@@ -766,7 +766,7 @@ public class KinesisService implements ResourceProvider {private KinesisShard selectShard(KinesisStream stream, String partitionKey) {// Simple hash-based shard selection among ALL shards, then resolve to open one- int index = Math.abs(partitionKey.hashCode()) % stream.getShards().size();+ int index = (int) (Math.abs((long) partitionKey.hashCode()) % stream.getShards().size());KinesisShard shard = stream.getShards().get(index);// If closed, find the first open child (simplified)diff --git a/src/test/java/io/github/hectorvent/floci/services/kinesis/KinesisIntegrationTest.java b/src/test/java/io/github/hectorvent/floci/services/kinesis/KinesisIntegrationTest.javaindex 7e025ceb4b..92e1ef55f1 100644--- a/src/test/java/io/github/hectorvent/floci/services/kinesis/KinesisIntegrationTest.java+++ b/src/test/java/io/github/hectorvent/floci/services/kinesis/KinesisIntegrationTest.java@@ -765,6 +765,53 @@ class KinesisIntegrationTest {.body("Records.size()", equalTo(0));}+ @Test+ @Order(43)+ void putRecordAcceptsPartitionKeyWithMinimumHashCode() {+ given()+ .header("X-Amz-Target", "Kinesis_20131202.CreateStream")+ .contentType(KINESIS_CONTENT_TYPE)+ .body("""+ {"StreamName": "minimum-hash-partition-key-test", "ShardCount": 3}+ """)+ .when().post("/").then().statusCode(200);++ given()+ .header("X-Amz-Target", "Kinesis_20131202.PutRecord")+ .contentType(KINESIS_CONTENT_TYPE)+ .body("""+ {"StreamName": "minimum-hash-partition-key-test", "Data": "dGVzdA==", "PartitionKey": "polygenelubricants"}+ """)+ .when()+ .post("/")+ .then()+ .statusCode(200);+ }++ @Test+ @Order(44)+ void putRecordPreservesShardForNegativeHashCode() {+ given()+ .header("X-Amz-Target", "Kinesis_20131202.CreateStream")+ .contentType(KINESIS_CONTENT_TYPE)+ .body("""+ {"StreamName": "negative-hash-partition-key-test", "ShardCount": 3}+ """)+ .when().post("/").then().statusCode(200);++ given()+ .header("X-Amz-Target", "Kinesis_20131202.PutRecord")+ .contentType(KINESIS_CONTENT_TYPE)+ .body("""+ {"StreamName": "negative-hash-partition-key-test", "Data": "dGVzdA==", "PartitionKey": "negative-hash"}+ """)+ .when()+ .post("/")+ .then()+ .statusCode(200)+ .body("ShardId", equalTo("shardId-000000000002"));+ }+// --- AT_TIMESTAMP iterator coverage ---private String atTimestampCreateStream(String name) {