Skip to content

armgit / floci

Public Imported from GitHub
0

Light, fluffy, and always free - The AWS Local Emulator alternative

feat(cloudformation): provision CloudWatch metric alarms (#1371)

Hector Ventura6004e57c2913
diff --git a/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java b/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java
index 9923f143cb..2576ec4ae1 100644
--- a/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java
+++ b/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java
@@ -17,6 +17,9 @@ import io.github.hectorvent.floci.services.dynamodb.model.TableDefinition;
import io.github.hectorvent.floci.services.ecr.EcrService;
import io.github.hectorvent.floci.services.ecr.model.Repository;
import io.github.hectorvent.floci.services.cloudwatch.logs.CloudWatchLogsService;
+import io.github.hectorvent.floci.services.cloudwatch.metrics.CloudWatchMetricsService;
+import io.github.hectorvent.floci.services.cloudwatch.metrics.model.Dimension;
+import io.github.hectorvent.floci.services.cloudwatch.metrics.model.MetricAlarm;
import io.github.hectorvent.floci.services.ec2.Ec2Service;
import io.github.hectorvent.floci.services.kinesis.KinesisService;
import io.github.hectorvent.floci.services.ec2.model.Tag;
@@ -142,6 +145,7 @@ public class CloudFormationResourceProvisioner {
private final EksService eksService;
private final CloudWatchLogsService logsService;
private final KinesisService kinesisService;
+ private final CloudWatchMetricsService cloudWatchMetricsService;
@Inject
public CloudFormationResourceProvisioner(S3Service s3Service, SqsService sqsService,
@@ -167,7 +171,8 @@ public class CloudFormationResourceProvisioner {
RdsService rdsService,
EksService eksService,
CloudWatchLogsService logsService,
- KinesisService kinesisService) {
+ KinesisService kinesisService,
+ CloudWatchMetricsService cloudWatchMetricsService) {
this.s3Service = s3Service;
this.sqsService = sqsService;
this.snsService = snsService;
@@ -196,6 +201,7 @@ public class CloudFormationResourceProvisioner {
this.eksService = eksService;
this.logsService = logsService;
this.kinesisService = kinesisService;
+ this.cloudWatchMetricsService = cloudWatchMetricsService;
}
/**
@@ -318,6 +324,8 @@ public class CloudFormationResourceProvisioner {
case "AWS::Logs::LogGroup" -> provisionLogGroup(resource, properties, engine, region, accountId, stackName);
case "AWS::Kinesis::Stream" ->
provisionKinesisStream(resource, properties, engine, region, stackName);
+ case "AWS::CloudWatch::Alarm" ->
+ provisionCloudWatchAlarm(resource, properties, engine, region, stackName);
default -> {
if (resourceType != null && resourceType.startsWith("Custom::")) {
provisionCustomResource(resource, properties, engine, region, accountId, stackName);
@@ -411,6 +419,8 @@ public class CloudFormationResourceProvisioner {
case "AWS::EKS::Cluster" -> eksService.deleteCluster(physicalId);
case "AWS::Logs::LogGroup" -> logsService.deleteLogGroup(physicalId, region);
case "AWS::Kinesis::Stream" -> kinesisService.deleteStream(physicalId, region);
+ case "AWS::CloudWatch::Alarm" ->
+ cloudWatchMetricsService.deleteAlarms(List.of(physicalId), region);
default -> LOG.debugv("Skipping delete of unsupported resource type: {0}", resourceType);
}
} catch (Exception e) {
@@ -641,6 +651,70 @@ public class CloudFormationResourceProvisioner {
r.getAttributes().put("Arn", stream.getStreamArn());
}
+ // ── CloudWatch ──────────────────────────────────────────────────────────────
+
+ private void provisionCloudWatchAlarm(StackResource r, JsonNode props, CloudFormationTemplateEngine engine,
+ String region, String stackName) {
+ String name = resolveOptional(props, "AlarmName", engine);
+ if (name == null || name.isBlank()) {
+ name = generatePhysicalName(stackName, r.getLogicalId(), 255, false);
+ }
+
+ MetricAlarm alarm = new MetricAlarm();
+ alarm.setAlarmName(name);
+ alarm.setAlarmDescription(resolveOptional(props, "AlarmDescription", engine));
+ alarm.setMetricName(resolveOptional(props, "MetricName", engine));
+ alarm.setNamespace(resolveOptional(props, "Namespace", engine));
+ alarm.setStatistic(resolveOptional(props, "Statistic", engine));
+ alarm.setUnit(resolveOptional(props, "Unit", engine));
+ alarm.setComparisonOperator(resolveOptional(props, "ComparisonOperator", engine));
+ alarm.setPeriod(parseIntProp(props, "Period", engine, 60));
+ alarm.setEvaluationPeriods(parseIntProp(props, "EvaluationPeriods", engine, 1));
+ alarm.setDatapointsToAlarm(parseIntProp(props, "DatapointsToAlarm", engine, alarm.getEvaluationPeriods()));
+ String threshold = resolveOptional(props, "Threshold", engine);
+ if (threshold != null && !threshold.isBlank()) {
+ try {
+ alarm.setThreshold(Double.parseDouble(threshold.trim()));
+ } catch (NumberFormatException ignored) {
+ // leave default
+ }
+ }
+ String treatMissing = resolveOptional(props, "TreatMissingData", engine);
+ if (treatMissing != null && !treatMissing.isBlank()) {
+ alarm.setTreatMissingData(treatMissing);
+ }
+ String actionsEnabled = resolveOptional(props, "ActionsEnabled", engine);
+ alarm.setActionsEnabled(actionsEnabled == null || Boolean.parseBoolean(actionsEnabled));
+
+ if (props != null && props.has("Dimensions") && props.get("Dimensions").isArray()) {
+ List<Dimension> dimensions = new ArrayList<>();
+ for (JsonNode dim : props.get("Dimensions")) {
+ dimensions.add(new Dimension(engine.resolve(dim.path("Name")), engine.resolve(dim.path("Value"))));
+ }
+ alarm.setDimensions(dimensions);
+ }
+ addAlarmActions(props, "AlarmActions", engine, alarm.getAlarmActions());
+ addAlarmActions(props, "OKActions", engine, alarm.getOkActions());
+ addAlarmActions(props, "InsufficientDataActions", engine, alarm.getInsufficientDataActions());
+
+ cloudWatchMetricsService.putMetricAlarm(alarm, region);
+ // Ref returns the alarm name; Fn::GetAtt Arn returns the alarm ARN.
+ r.setPhysicalId(name);
+ r.getAttributes().put("Arn", alarm.getAlarmArn());
+ }
+
+ private void addAlarmActions(JsonNode props, String field, CloudFormationTemplateEngine engine,
+ List<String> target) {
+ if (props != null && props.has(field) && props.get(field).isArray()) {
+ for (JsonNode action : props.get(field)) {
+ String resolved = engine.resolve(action);
+ if (resolved != null && !resolved.isBlank()) {
+ target.add(resolved);
+ }
+ }
+ }
+ }
+
private void provisionEc2Instance(StackResource r, JsonNode props, CloudFormationTemplateEngine engine,
String region) {
String imageId = resolveOptional(props, "ImageId", engine);
diff --git a/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationCloudWatchAlarmIntegrationTest.java b/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationCloudWatchAlarmIntegrationTest.java
new file mode 100644
index 0000000000..dad33b0698
--- /dev/null
+++ b/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationCloudWatchAlarmIntegrationTest.java
@@ -0,0 +1,88 @@
+package io.github.hectorvent.floci.services.cloudformation;
+
+import io.quarkus.test.junit.QuarkusTest;
+import org.junit.jupiter.api.Test;
+
+import static io.restassured.RestAssured.given;
+import static org.hamcrest.Matchers.containsString;
+
+/**
+ * End-to-end check that CloudFormation provisions an AWS::CloudWatch::Alarm for real (into
+ * CloudWatchMetricsService) rather than stubbing it. Alarms are metadata (no container), so the
+ * test is Docker-free. CloudWatch is the Query API (form-encoded request, XML response).
+ */
+@QuarkusTest
+class CloudFormationCloudWatchAlarmIntegrationTest {
+
+ private static final String CFN_AUTH =
+ "AWS4-HMAC-SHA256 Credential=test/20260205/us-east-1/cloudformation/aws4_request";
+ private static final String CW_AUTH =
+ "AWS4-HMAC-SHA256 Credential=test/20260205/us-east-1/monitoring/aws4_request";
+
+ @Test
+ void createStackProvisionsAlarmVisibleToCloudWatch() {
+ String suffix = Long.toString(System.nanoTime(), 36);
+ String alarmName = "cfn-alarm-" + suffix;
+ String stackName = "cfn-cw-alarm-stack-" + suffix;
+
+ String template = """
+ {
+ "Resources": {
+ "Alarm": {
+ "Type": "AWS::CloudWatch::Alarm",
+ "Properties": {
+ "AlarmName": "%s",
+ "Namespace": "AWS/EC2",
+ "MetricName": "CPUUtilization",
+ "Statistic": "Average",
+ "Period": 300,
+ "EvaluationPeriods": 2,
+ "Threshold": 80,
+ "ComparisonOperator": "GreaterThanThreshold"
+ }
+ }
+ },
+ "Outputs": {
+ "AlarmArn": {"Value": {"Fn::GetAtt": ["Alarm", "Arn"]}}
+ }
+ }
+ """.formatted(alarmName);
+
+ given()
+ .contentType("application/x-www-form-urlencoded")
+ .header("Authorization", CFN_AUTH)
+ .formParam("Action", "CreateStack")
+ .formParam("StackName", stackName)
+ .formParam("TemplateBody", template)
+ .when()
+ .post("/")
+ .then()
+ .statusCode(200);
+
+ // Stack completes and Fn::GetAtt(Alarm, Arn) resolves to the real alarm ARN.
+ given()
+ .contentType("application/x-www-form-urlencoded")
+ .header("Authorization", CFN_AUTH)
+ .formParam("Action", "DescribeStacks")
+ .formParam("StackName", stackName)
+ .when()
+ .post("/")
+ .then()
+ .statusCode(200)
+ .body(containsString("<StackStatus>CREATE_COMPLETE</StackStatus>"))
+ .body(containsString(":alarm:" + alarmName));
+
+ // The alarm really exists in CloudWatch.
+ given()
+ .contentType("application/x-www-form-urlencoded")
+ .header("Authorization", CW_AUTH)
+ .formParam("Action", "DescribeAlarms")
+ .formParam("AlarmNames.member.1", alarmName)
+ .when()
+ .post("/")
+ .then()
+ .statusCode(200)
+ .body(containsString(alarmName))
+ .body(containsString("CPUUtilization"));
+ }
+}
diff --git a/src/test/java/io/github/hectorvent/floci/services/cloudformation/CustomResourceProvisionerTest.java b/src/test/java/io/github/hectorvent/floci/services/cloudformation/CustomResourceProvisionerTest.java
index 1613d0d707..7558937dc5 100644
--- a/src/test/java/io/github/hectorvent/floci/services/cloudformation/CustomResourceProvisionerTest.java
+++ b/src/test/java/io/github/hectorvent/floci/services/cloudformation/CustomResourceProvisionerTest.java
@@ -48,7 +48,7 @@ class CustomResourceProvisionerTest {
provisioner = new CloudFormationResourceProvisioner(
null, null, null, null, lambdaService, null, null, null, null, null,
- null, null, null, null, null, null, mapper, store, endpoint, null, null, null, null, null, null, null, null, null);
+ null, null, null, null, null, null, mapper, store, endpoint, null, null, null, null, null, null, null, null, null, null);
}
private CloudFormationTemplateEngine engine() {
diff --git a/src/test/java/io/github/hectorvent/floci/services/cloudformation/RdsCfnProvisionerTest.java b/src/test/java/io/github/hectorvent/floci/services/cloudformation/RdsCfnProvisionerTest.java
index 06149c49ae..546dbda62d 100644
--- a/src/test/java/io/github/hectorvent/floci/services/cloudformation/RdsCfnProvisionerTest.java
+++ b/src/test/java/io/github/hectorvent/floci/services/cloudformation/RdsCfnProvisionerTest.java
@@ -44,7 +44,7 @@ class RdsCfnProvisionerTest {
null, null, null, null, null, null,
mapper,
null, null, null, null, null, null, null,
- rdsService, null, null, null);
+ rdsService, null, null, null, null);
}
private CloudFormationTemplateEngine engine() {