Skip to content

armgit / floci

Public Imported from GitHub
0

Light, fluffy, and always free - The AWS Local Emulator alternative

test(ecs): check container definition and service fields on read-back (#4535)

Aymen JAMAAOUI81ec0cc68a44
diff --git a/src/test/java/io/github/hectorvent/floci/services/ecs/EcsFargateTaskDefinitionIntegrationTest.java b/src/test/java/io/github/hectorvent/floci/services/ecs/EcsFargateTaskDefinitionIntegrationTest.java
index 469970c161..18d6945d33 100644
--- a/src/test/java/io/github/hectorvent/floci/services/ecs/EcsFargateTaskDefinitionIntegrationTest.java
+++ b/src/test/java/io/github/hectorvent/floci/services/ecs/EcsFargateTaskDefinitionIntegrationTest.java
@@ -115,6 +115,38 @@ class EcsFargateTaskDefinitionIntegrationTest {
.body("taskDefinition.containerDefinitions[1].dependsOn[0].condition", equalTo("SUCCESS"));
}
+ @Test
+ void registerTaskDefinitionRoundTripsSidecarMembersTogether() {
+ register("{\"family\":\"fargate-sidecar-members\",\"requiresCompatibilities\":[\"FARGATE\"],"
+ + "\"networkMode\":\"awsvpc\",\"cpu\":\"256\",\"memory\":\"1024\","
+ + "\"volumes\":[{\"name\":\"tmp\"}],"
+ + "\"containerDefinitions\":["
+ + "{\"name\":\"sidecar\",\"image\":\"busybox\",\"essential\":false,"
+ + "\"user\":\"1000\",\"readonlyRootFilesystem\":true},"
+ + "{\"name\":\"app\",\"image\":\"busybox\",\"essential\":true,"
+ + "\"user\":\"65532\",\"readonlyRootFilesystem\":true,"
+ + "\"mountPoints\":[{\"sourceVolume\":\"tmp\",\"containerPath\":\"/tmp\",\"readOnly\":false}],"
+ + "\"volumesFrom\":[{\"sourceContainer\":\"sidecar\",\"readOnly\":true}],"
+ + "\"dependsOn\":[{\"containerName\":\"sidecar\",\"condition\":\"START\"}],"
+ + "\"repositoryCredentials\":{\"credentialsParameter\":\"arn:aws:secretsmanager:us-east-1:"
+ + "000000000000:secret:dummy\"}}]}", 200);
+
+ call("DescribeTaskDefinition", "{\"taskDefinition\":\"fargate-sidecar-members\"}", 200)
+ .then()
+ .body("taskDefinition.containerDefinitions[0].user", equalTo("1000"))
+ .body("taskDefinition.containerDefinitions[0].readonlyRootFilesystem", equalTo(true))
+ .body("taskDefinition.containerDefinitions[1].user", equalTo("65532"))
+ .body("taskDefinition.containerDefinitions[1].readonlyRootFilesystem", equalTo(true))
+ .body("taskDefinition.containerDefinitions[1].mountPoints", hasSize(1))
+ .body("taskDefinition.containerDefinitions[1].volumesFrom", hasSize(1))
+ .body("taskDefinition.containerDefinitions[1].volumesFrom[0].sourceContainer", equalTo("sidecar"))
+ .body("taskDefinition.containerDefinitions[1].volumesFrom[0].readOnly", equalTo(true))
+ .body("taskDefinition.containerDefinitions[1].dependsOn[0].containerName", equalTo("sidecar"))
+ .body("taskDefinition.containerDefinitions[1].dependsOn[0].condition", equalTo("START"))
+ .body("taskDefinition.containerDefinitions[1].repositoryCredentials.credentialsParameter",
+ containsString("secret:dummy"));
+ }
+
@Test
void registerTaskDefinitionReportsRegistrationMetadata() {
Response response = register(fargateTaskDefinition("fargate-registered-at", ""), 200);
diff --git a/src/test/java/io/github/hectorvent/floci/services/ecs/EcsLoadBalancersIntegrationTest.java b/src/test/java/io/github/hectorvent/floci/services/ecs/EcsLoadBalancersIntegrationTest.java
index fab49bf455..1885216fd5 100644
--- a/src/test/java/io/github/hectorvent/floci/services/ecs/EcsLoadBalancersIntegrationTest.java
+++ b/src/test/java/io/github/hectorvent/floci/services/ecs/EcsLoadBalancersIntegrationTest.java
@@ -78,6 +78,25 @@ class EcsLoadBalancersIntegrationTest {
.body("services[0].loadBalancers[0].targetGroupArn", equalTo(tgArn));
}
+ @Test
+ void describeServicesReturnsHealthCheckGracePeriodWithLoadBalancers() {
+ seedClusterAndTaskDef("lb-cluster-7", "lb-td-7");
+ String tgArn = "arn:aws:elasticloadbalancing:us-east-1:000000000000:targetgroup/lbtg7/jkl012";
+ call("CreateService", "{\"cluster\":\"lb-cluster-7\",\"serviceName\":\"lb-svc-7\","
+ + "\"taskDefinition\":\"lb-td-7\",\"desiredCount\":1,"
+ + "\"healthCheckGracePeriodSeconds\":45,"
+ + "\"loadBalancers\":[{\"targetGroupArn\":\"" + tgArn + "\","
+ + "\"containerName\":\"web\",\"containerPort\":8080}]}");
+
+ given().contentType(CT).header("X-Amz-Target", TARGET + "DescribeServices")
+ .body("{\"cluster\":\"lb-cluster-7\",\"services\":[\"lb-svc-7\"]}")
+ .when().post("/")
+ .then().statusCode(200)
+ .body("services[0].healthCheckGracePeriodSeconds", equalTo(45))
+ .body("services[0].loadBalancers", hasSize(1))
+ .body("services[0].loadBalancers[0].targetGroupArn", equalTo(tgArn));
+ }
+
@Test
void createServiceWithoutLoadBalancersOmitsField() {
seedClusterAndTaskDef("lb-cluster-3", "lb-td-3");