Light, fluffy, and always free - The AWS Local Emulator alternative
ci: cap open PRs at 4 with drafts and 2 ready for review (#5283)
Hector Venturad1fc2654a94d
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.mdindex a6eab3c487..cd14d32a83 100644--- a/.github/pull_request_template.md+++ b/.github/pull_request_template.md@@ -19,7 +19,7 @@- [ ] `./mvnw test` passes locally- [ ] New or updated integration test added- [ ] Commit messages follow [Conventional Commits](https://www.conventionalcommits.org/)-- [ ] I have no more than 2 open, non-draft pull requests in this repository (maintainers and dependency bots are exempt).+- [ ] I have no more than 2 open, non-draft pull requests and no more than 4 open pull requests in total (drafts included) in this repository (maintainers and dependency bots are exempt).<!-- First PR here? Your CI checks wait for a maintainer to approve them before they run — that's GitHub's gate on first-time contributors, not a problem with your PR. --><!-- Questions, or want feedback on an approach before going further? Join us on Slack: https://join.slack.com/t/floci/shared_invite/zt-3tjn02s3q-A00kEjJ1cZxsg_imTfy6Cw -->diff --git a/.github/workflows/pr-limit.yml b/.github/workflows/pr-limit.ymlindex 4441d9cb94..642ad82611 100644--- a/.github/workflows/pr-limit.yml+++ b/.github/workflows/pr-limit.yml@@ -6,6 +6,8 @@ name: PR Limit## pull_request_target gives the token write access on fork PRs. Neither this workflow# nor the reusable one checks out or runs PR code; they only call the GitHub API.+# contents: write is needed only for converting a PR back to a draft (the GitHub API+# refuses the token without it). Never add a checkout of the PR head here.on:pull_request_target:@@ -23,6 +25,7 @@ on:default: truepermissions:+ contents: writeissues: writepull-requests: writediff --git a/CONTRIBUTING.md b/CONTRIBUTING.mdindex 4f93559eea..d3c4dfb5df 100644--- a/CONTRIBUTING.md+++ b/CONTRIBUTING.md@@ -257,18 +257,18 @@ update path.3. CI runs tests automatically. All checks must pass before merge.4. Keep PRs focused: one feature or fix per PR.5. Reference any related issues in the PR description.-6. Keep at most **2 open, non-draft PRs** at a time: see [Pull Request Limits and Review Bandwidth](#pull-request-limits-and-review-bandwidth).+6. Keep at most **4 open PRs**, drafts included, and at most **2 of them ready for review**: see [Pull Request Limits and Review Bandwidth](#pull-request-limits-and-review-bandwidth).Docker images are built on contributor PRs only for the compatibility suite (`.github/workflows/compatibility.yml`, on changes under `src/**` and the compat test trees) and are never published, so merging to `main` is always cheap.### Pull Request Limits and Review Bandwidth-To make sure every contribution gets a thorough, high-quality review in a reasonable time, we ask contributors to keep **no more than 2 open, non-draft pull requests** at any time in this repository.+To make sure every contribution gets a thorough, high-quality review in a reasonable time, we ask contributors to keep **no more than 4 open pull requests**, drafts included, at any time in this repository, and **no more than 2 of them ready for review**.- **Why this policy exists:** maintainer review time is limited. Capping concurrent open PRs prevents review backlogs, reduces context switching, and keeps PR cycle times short for everyone.- **Dependent work:** if your work depends on a PR that has not been merged yet, build on that branch or note the dependency in the discussion instead of opening separate, uncoordinated PRs.-- **Draft PRs:** drafts do not count against the limit. Mark a draft as ready for review only when you have review capacity available.-- **How it is applied:** a bot labels your 3rd and later open pull requests `over-pr-limit` with a reminder. Starting **2026-10-08**, from your 5th open pull request onward, new ones are closed automatically. Your branch and commits are kept, and you can reopen the PR once one of your other PRs is merged or closed. Maintainers and dependency bots are not counted.+- **Draft PRs:** drafts do not count against the limit of 2 ready pull requests, but they do count toward the total of 4. You can have, for example, 2 ready and 2 drafts, or 1 ready and 3 drafts. Use drafts for work in progress, not as a queue of finished changes waiting for a review slot, and mark a draft as ready for review only when you have review capacity available.+- **How it is applied:** a bot turns a pull request back into a draft if it would be your 3rd ready for review, and closes a pull request opened while you already have 4 open, drafts included. Your branch and commits are always kept: mark the draft ready again once one of your ready pull requests is merged, closed or turned into a draft, and reopen a closed pull request once you have fewer than 4 open. Maintainers and dependency bots are not counted.Once your current pull requests are reviewed, merged, or closed, you are welcome to open new ones!diff --git a/docs/contributing.md b/docs/contributing.mdindex dd7232d4ec..90c0fe9597 100644--- a/docs/contributing.md+++ b/docs/contributing.md@@ -122,7 +122,7 @@ add or change, and leave unrelated cleanups for their own PR.- [ ] Commit messages follow Conventional Commits- [ ] Code follows the style rules above-Please keep **no more than 2 open, non-draft pull requests** at a time. A bot labels your 3rd and later open PRs `over-pr-limit`, and starting 2026-10-08 it closes new ones from your 5th onward. See [CONTRIBUTING.md](https://github.com/floci-io/floci/blob/main/CONTRIBUTING.md#pull-request-limits-and-review-bandwidth) for details.+Please keep **no more than 4 open pull requests**, drafts included, and **no more than 2 of them ready for review**. A bot turns a 3rd ready PR back into a draft and closes new ones opened while you already have 4 open. See [CONTRIBUTING.md](https://github.com/floci-io/floci/blob/main/CONTRIBUTING.md#pull-request-limits-and-review-bandwidth) for details.## Releases