Skip to content

armgit / floci

Public Imported from GitHub
0

Light, fluffy, and always free - The AWS Local Emulator alternative

fix: preserve Firehose compression format in CloudFormation (#2406)

Abarnaa Sree Nebd4a078d391
diff --git a/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java b/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java
index a4d06edcb4..69c0ac5e8f 100644
--- a/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java
+++ b/src/main/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationResourceProvisioner.java
@@ -2032,6 +2032,10 @@ public class CloudFormationResourceProvisioner {
: (props != null ? props.get("S3DestinationConfiguration") : null);
if (s3Node != null && !s3Node.isNull()) {
s3 = new DeliveryStreamDescription.S3Destination();
+
+ s3.setCompressionFormat(
+ blankToNull(engine.resolve(s3Node.path("CompressionFormat")))
+ );
s3.setBucketArn(blankToNull(engine.resolve(s3Node.path("BucketARN"))));
s3.setPrefix(blankToNull(engine.resolve(s3Node.path("Prefix"))));
if (s3Node.has("BufferingHints")) {
diff --git a/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationFirehoseIntegrationTest.java b/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationFirehoseIntegrationTest.java
index a32a24b772..5eb7fab6e4 100644
--- a/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationFirehoseIntegrationTest.java
+++ b/src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationFirehoseIntegrationTest.java
@@ -1,13 +1,13 @@
package io.github.hectorvent.floci.services.cloudformation;
+import static org.hamcrest.Matchers.containsString;
+import org.junit.jupiter.api.Test;
+
import io.quarkus.test.junit.QuarkusTest;
import io.restassured.RestAssured;
+import static io.restassured.RestAssured.given;
import io.restassured.config.EncoderConfig;
import io.restassured.http.ContentType;
-import org.junit.jupiter.api.Test;
-
-import static io.restassured.RestAssured.given;
-import static org.hamcrest.Matchers.containsString;
/**
* End-to-end check that CloudFormation provisions an AWS::KinesisFirehose::DeliveryStream for real
@@ -39,7 +39,8 @@ class CloudFormationFirehoseIntegrationTest {
"S3DestinationConfiguration": {
"BucketARN": "arn:aws:s3:::my-firehose-bucket",
"RoleARN": "arn:aws:iam::000000000000:role/firehose-role",
- "Prefix": "logs/"
+ "Prefix": "logs/",
+ "CompressionFormat": "GZIP"
}
}
}
@@ -86,6 +87,7 @@ class CloudFormationFirehoseIntegrationTest {
.post("/")
.then()
.statusCode(200)
- .body(containsString(streamName));
+ .body(containsString(streamName))
+ .body(containsString("GZIP"));
}
}