A modern platform for visual, flexible, and extensible graph-based investigations. For cybersecurity analysts and investigators.
fix(frontend): resolve react-hooks/refs
dextmorgn2ea9db54d38d
diff --git a/flowsint-app/src/components/analyses/editor/extensions/image/components/image-view-block.tsx b/flowsint-app/src/components/analyses/editor/extensions/image/components/image-view-block.tsxindex cad68066..ed195283 100644--- a/flowsint-app/src/components/analyses/editor/extensions/image/components/image-view-block.tsx+++ b/flowsint-app/src/components/analyses/editor/extensions/image/components/image-view-block.tsx@@ -68,9 +68,16 @@ export const ImageViewBlock: React.FC<NodeViewProps> = ({const aspectRatio = imageState.naturalSize.width / imageState.naturalSize.heightconst maxWidth = MAX_HEIGHT * aspectRatio- const containerMaxWidth = containerRef.current- ? parseFloat(getComputedStyle(containerRef.current).getPropertyValue('--editor-width'))- : Infinity+ // Reading the DOM (getComputedStyle) during render isn't safe — measure+ // after mount instead. containerRef.current is null on the first render,+ // so Infinity is the correct starting value regardless.+ const [containerMaxWidth, setContainerMaxWidth] = React.useState(Infinity)+ React.useLayoutEffect(() => {+ if (!containerRef.current) return+ setContainerMaxWidth(+ parseFloat(getComputedStyle(containerRef.current).getPropertyValue('--editor-width'))+ )+ })const { isLink, onView, onDownload, onCopy, onCopyLink, onRemoveImg } = useImageActions({editor,diff --git a/flowsint-app/src/components/sketches/details-panel/details-panel.tsx b/flowsint-app/src/components/sketches/details-panel/details-panel.tsxindex 5bd9567e..f8486c40 100644--- a/flowsint-app/src/components/sketches/details-panel/details-panel.tsx+++ b/flowsint-app/src/components/sketches/details-panel/details-panel.tsx@@ -561,6 +561,10 @@ const DetailsPanel = memo(() => {canEdit ? (<Switchchecked={value}+ // handlePropertyBlur reads formDataRef.current, but only ever runs+ // from this onCheckedChange callback (a real event handler) — never+ // during render. The lint rule can't see that from here.+ // eslint-disable-next-line react-hooks/refsonCheckedChange={(checked) => handlePropertyBlur(key, checked)}className="scale-75"/>diff --git a/flowsint-app/src/components/sketches/graph/components/graph-main.tsx b/flowsint-app/src/components/sketches/graph/components/graph-main.tsxindex 8ccd944f..b805b276 100644--- a/flowsint-app/src/components/sketches/graph/components/graph-main.tsx+++ b/flowsint-app/src/components/sketches/graph/components/graph-main.tsx@@ -1,5 +1,12 @@import { useGraphStore } from '@/stores/graph-store'-import React, { useRef, useCallback, useMemo, SetStateAction, Dispatch } from 'react'+import React, {+ useRef,+ useCallback,+ useMemo,+ useLayoutEffect,+ SetStateAction,+ Dispatch+} from 'react'import GraphViewer from '../index'import NodeContextMenu from '../context-menu/node-context-menu'import BackgroundContextMenu from '../context-menu/background-context-menu'@@ -128,7 +135,9 @@ const GraphMain = () => {// Stable ref so ForceGraph2D always calls the latest versionconst bgClickRef = useRef(handleBackgroundClick)- bgClickRef.current = handleBackgroundClick+ useLayoutEffect(() => {+ bgClickRef.current = handleBackgroundClick+ })const stableBackgroundClick = useCallback((event?: MouseEvent) => {bgClickRef.current(event)}, [])diff --git a/flowsint-app/src/components/sketches/graph/hooks/use-link-creation.ts b/flowsint-app/src/components/sketches/graph/hooks/use-link-creation.tsindex a1d90390..865cbc06 100644--- a/flowsint-app/src/components/sketches/graph/hooks/use-link-creation.ts+++ b/flowsint-app/src/components/sketches/graph/hooks/use-link-creation.ts@@ -1,4 +1,4 @@-import { useCallback, useRef, useState } from 'react'+import { useCallback, useLayoutEffect, useRef, useState } from 'react'import { useGraphStore } from '@/stores/graph-store'import { sketchService } from '@/api/sketch-service'import { toast } from 'sonner'@@ -20,7 +20,9 @@ const INITIAL_STATE: LinkCreationState = {export const useLinkCreation = (sketchId?: string) => {const [state, setState] = useState<LinkCreationState>(INITIAL_STATE)const stateRef = useRef(state)- stateRef.current = state+ useLayoutEffect(() => {+ stateRef.current = state+ })const [shiftHeld, setShiftHeld] = useState(false)diff --git a/flowsint-app/src/components/sketches/graph/index.tsx b/flowsint-app/src/components/sketches/graph/index.tsxindex 77bfb4c5..d71831a6 100644--- a/flowsint-app/src/components/sketches/graph/index.tsx+++ b/flowsint-app/src/components/sketches/graph/index.tsx@@ -1,4 +1,4 @@-import React, { useCallback, useMemo, useEffect, useState, useRef } from 'react'+import React, { useCallback, useMemo, useEffect, useLayoutEffect, useState, useRef } from 'react'import { useShallow } from 'zustand/react/shallow'import ForceGraph2D from 'react-force-graph-2d'import { useGraphControls } from '@/stores/graph-controls-store'@@ -383,16 +383,19 @@ const GraphViewer: React.FC<GraphViewerProps> = ({// Render context: created once per frame, shared across all node/link render calls.// Invalidated when dependencies change or when the canvas transform changes between frames.- const rcRef = useRef<{ rc: RenderContext | null; depsVersion: number; frameKey: string }>({+ const rcRef = useRef<{ rc: RenderContext | null; frameKey: string }>({rc: null,- depsVersion: 0,frameKey: ''})- // Increment version whenever render context deps change to force recreation- const rcDepsVersion = useMemo(() => {- rcRef.current.depsVersion++- return rcRef.current.depsVersion+ // Bumped whenever render context deps change, to force cache invalidation in+ // getOrCreateRC below even when globalScale alone doesn't. This used to be a+ // ref mutated straight in a useMemo body — invalid (refs can't be written+ // during render) and only worked by accident. Real state + a layout effect+ // gets the same "one value per deps change" behavior the correct way.+ const [rcDepsVersion, setRcDepsVersion] = useState(0)+ useLayoutEffect(() => {+ setRcDepsVersion((v) => v + 1)// eslint-disable-next-line react-hooks/exhaustive-deps}, [highlightNodes, highlightLinks, selectedEdges, theme])diff --git a/flowsint-app/src/components/templates/template-editor.tsx b/flowsint-app/src/components/templates/template-editor.tsxindex 4a4175c4..cf020f5b 100644--- a/flowsint-app/src/components/templates/template-editor.tsx+++ b/flowsint-app/src/components/templates/template-editor.tsx@@ -1,4 +1,4 @@-import { useState, useCallback, useMemo, useEffect, useRef } from 'react'+import { useState, useCallback, useMemo, useEffect, useLayoutEffect, useRef } from 'react'import { useMutation, useQueryClient } from '@tanstack/react-query'import { useNavigate } from '@tanstack/react-router'import { parse as parseYaml, stringify as stringifyYaml } from 'yaml'@@ -117,7 +117,9 @@ export function TemplateEditor({ templateId, initialContent, importedYaml }: Temconst paramKeys = Object.keys(templateParams)const stateRef = useRef({ hasErrors, hasChanges, data: validationResult.data, content })- stateRef.current = { hasErrors, hasChanges, data: validationResult.data, content }+ useLayoutEffect(() => {+ stateRef.current = { hasErrors, hasChanges, data: validationResult.data, content }+ })const createMutation = useMutation({mutationFn: (data: TemplateData) =>diff --git a/flowsint-app/src/components/use-confirm-dialog.tsx b/flowsint-app/src/components/use-confirm-dialog.tsxindex 998f10f9..f257f2d1 100644--- a/flowsint-app/src/components/use-confirm-dialog.tsx+++ b/flowsint-app/src/components/use-confirm-dialog.tsx@@ -14,6 +14,7 @@ import React, {type ReactNode,useCallback,useContext,+ useLayoutEffect,useRef,useState} from 'react'@@ -62,12 +63,18 @@ function ConfirmDialogWithContext() {const { confirmRef } = useContext(ConfirmContext)- confirmRef.current = (dialogProps: ConfirmProps) =>- new Promise<boolean>((resolve) => {- setProps(dialogProps)- setOpen(true)- resolveRef.current = resolve- })+ const confirm = useCallback(+ (dialogProps: ConfirmProps) =>+ new Promise<boolean>((resolve) => {+ setProps(dialogProps)+ setOpen(true)+ resolveRef.current = resolve+ }),+ []+ )+ useLayoutEffect(() => {+ confirmRef.current = confirm+ }, [confirmRef, confirm])const onConfirm = () => {resolveRef.current(true)diff --git a/flowsint-app/src/hooks/use-paste-listener.ts b/flowsint-app/src/hooks/use-paste-listener.tsindex 7b580844..f7df80b8 100644--- a/flowsint-app/src/hooks/use-paste-listener.ts+++ b/flowsint-app/src/hooks/use-paste-listener.ts@@ -1,4 +1,4 @@-import { useCallback, useEffect, useRef } from 'react'+import { useCallback, useEffect, useLayoutEffect, useRef } from 'react'export type ClipboardPayload =| { type: 'text'; text: string }@@ -49,7 +49,9 @@ export function usePasteListener(handlers: PasteHandlers, options: UsePasteListeconst { global = false, preventDefault = false } = optionsconst handlersRef = useRef(handlers)- handlersRef.current = handlers+ useLayoutEffect(() => {+ handlersRef.current = handlers+ })const listener = useCallback((event: ClipboardEvent | React.ClipboardEvent) => {