Skip to content

A modern platform for visual, flexible, and extensible graph-based investigations. For cybersecurity analysts and investigators.

fix(app): proper backend hydration when optimistic insert

dextmorgn79089f7a2d95
diff --git a/flowsint-app/src/components/sketches/add-item-dialog.tsx b/flowsint-app/src/components/sketches/add-item-dialog.tsx
index 0abea67e..69daa878 100644
--- a/flowsint-app/src/components/sketches/add-item-dialog.tsx
+++ b/flowsint-app/src/components/sketches/add-item-dialog.tsx
@@ -32,11 +32,9 @@ export default function AddItemDialog() {
const setOpenFormDialog = useGraphStore((state) => state.setOpenFormDialog)
const addNode = useGraphStore((state) => state.addNode)
const addEdge = useGraphStore((state) => state.addEdge)
- const replaceNodeId = useGraphStore((state) => state.replaceNodeId)
+ const replaceNode = useGraphStore((state) => state.replaceNode)
const setActiveTab = useLayoutStore((state) => state.setActiveTab)
const setImportModalOpen = useGraphSettingsStore((s) => s.setImportModalOpen)
- const regenerateLayout = useGraphControls((s) => s.regenerateLayout)
- const currentLayoutType = useGraphControls((s) => s.currentLayoutType)
const getViewportCenter = useGraphControls((s) => s.getViewportCenter)
const { id: sketch_id } = useParams({ strict: false })
@@ -148,10 +146,8 @@ export default function AddItemDialog() {
sketch_id as string,
JSON.stringify(newNode)
)
- if (newNodeResponse.node && replaceNodeId) {
- // Replace the temporary ID with the real ID from the API
- replaceNodeId(tempId, newNodeResponse.node.id)
- // If we have a related node, create the edge with the real ID
+ if (newNodeResponse.node && replaceNode) {
+ replaceNode(tempId, newNodeResponse.node.data)
if (relatedNodeToAdd && tempEdgeId) {
const relationPayload = {
source: relatedNodeToAdd.id,
diff --git a/flowsint-app/src/components/sketches/background-context-menu.tsx b/flowsint-app/src/components/sketches/background-context-menu.tsx
index b50c65c3..0543dfe2 100644
--- a/flowsint-app/src/components/sketches/background-context-menu.tsx
+++ b/flowsint-app/src/components/sketches/background-context-menu.tsx
@@ -131,7 +131,7 @@ export default function BackgroundContextMenu({
{
loading: `Deleting ${selectedNodes.length} node(s)...`,
success: 'Nodes deleted successfully.',
- error: 'Failed to delete selectedNodes.'
+ error: 'Failed to delete selected nodes.'
}
)
}, [selectedNodes, confirm, removeNodes, clearSelectedNodes, sketchId])
diff --git a/flowsint-app/src/components/sketches/selected-items-panel.tsx b/flowsint-app/src/components/sketches/selected-items-panel.tsx
index 82c352e0..0a95ca79 100644
--- a/flowsint-app/src/components/sketches/selected-items-panel.tsx
+++ b/flowsint-app/src/components/sketches/selected-items-panel.tsx
@@ -116,7 +116,7 @@ const ActionBar = () => {
{
loading: `Deleting ${selectedNodes.length} node(s)...`,
success: 'Nodes deleted successfully.',
- error: 'Failed to delete selectedNodes.'
+ error: 'Failed to delete selected nodes.'
}
)
}, [selectedNodes, confirm, removeNodes, clearSelectedNodes, sketchId])
diff --git a/flowsint-app/src/stores/graph-store.ts b/flowsint-app/src/stores/graph-store.ts
index 9fc67bea..128577f9 100644
--- a/flowsint-app/src/stores/graph-store.ts
+++ b/flowsint-app/src/stores/graph-store.ts
@@ -19,7 +19,7 @@ interface GraphState {
updateGraphData: (nodes: GraphNode[], edges: GraphEdge[]) => void
updateNode: (nodeId: string, updates: Partial<NodeData>) => void
updateEdge: (edgeId: string, updates: Partial<GraphEdge>) => void
- replaceNodeId: (oldId: string, newId: string) => void
+ replaceNode: (oldId: string, newData: NodeData) => void
reset: () => void
// === Selection & Current ===
@@ -188,19 +188,19 @@ export const useGraphStore = create<GraphState>()(
set({ edges: updatedEdges, filteredNodes, filteredEdges })
},
- replaceNodeId: (oldId, newId) => {
+ replaceNode: (oldId, newData) => {
const { nodes, edges, filters, currentNode } = get()
// Update the node's ID and data.id
const updatedNodes = nodes.map((node) =>
- node.id === oldId ? { ...node, id: newId, data: { ...node.data, id: newId } } : node
+ node.id === oldId ? { ...node, id: newData.id, data: newData } : node
)
// Update all edges that reference this node
const updatedEdges = edges.map((edge) => {
if (edge.source === oldId) {
- return { ...edge, source: newId }
+ return { ...edge, source: newData.id }
}
if (edge.target === oldId) {
- return { ...edge, target: newId }
+ return { ...edge, target: newData.id }
}
return edge
})
@@ -208,7 +208,7 @@ export const useGraphStore = create<GraphState>()(
const filteredEdges = computeFilteredEdges(updatedEdges, filteredNodes)
// Update currentNode if it matches the old ID
const updatedCurrentNode = currentNode?.id === oldId
- ? { ...currentNode, id: newId, data: { ...currentNode.data, id: newId } }
+ ? { ...currentNode, id: newData.id, data: newData }
: currentNode
set({ nodes: updatedNodes, edges: updatedEdges, filteredNodes, filteredEdges, currentNode: updatedCurrentNode })
},