Skip to content

A modern platform for visual, flexible, and extensible graph-based investigations. For cybersecurity analysts and investigators.

chore: wire flowsint-app into make lint/lint-fix

dextmorgn88828c5f884c
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 2243f556..db2422ca 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -11,7 +11,7 @@ Run the checks for whatever you touched, not just the file you think is affected
From the repo root:
```bash
-make lint # ruff format --check + ruff check, whole repo
+make lint # ruff format --check + ruff check (whole repo) + frontend prettier/eslint check
make typecheck # mypy, ratcheted to files this branch touches vs origin/main
```
@@ -21,16 +21,14 @@ Then, for whichever package(s) you changed:
cd <package> && uv run pytest -q
```
-`make lint-fix` applies ruff's safe autofixes if `make lint` complains.
+`make lint-fix` applies ruff's safe autofixes, plus `yarn format`/`yarn lint` for the frontend, if `make lint` complains.
### Frontend (`flowsint-app`)
-From `flowsint-app/`:
+`make lint`/`make lint-fix` from the repo root already cover prettier + eslint for `flowsint-app`. The rest, from `flowsint-app/`:
```bash
npx tsc --noEmit # types
-npx eslint <files you touched> # lint must be 0 errors (warnings are fine)
-npx prettier --check <files> # format (--write to fix)
npx vitest run # unit tests
yarn build # full build
```
diff --git a/Makefile b/Makefile
index cacd2f96..3b18a872 100644
--- a/Makefile
+++ b/Makefile
@@ -152,14 +152,19 @@ PY_SRC := flowsint-core/src flowsint-core/tests \
# regression here is new debt — no reason to let it in. ruff replaces
# black+isort+flake8 (one tool, one config — see [tool.ruff] in the root
# pyproject.toml, which every package's ruff invocation inherits by walking
-# up the directory tree to find it).
+# up the directory tree to find it). Frontend prettier/eslint are just as
+# clean today (0 errors — eslint's ~130 remaining findings are all
+# warnings, e.g. no-explicit-any, not failures), so they're blocking here
+# too rather than living only in flowsint-app's own yarn scripts.
lint:
uv run ruff format --check $(PY_SRC)
uv run ruff check $(PY_SRC)
+ cd flowsint-app && yarn format:check && yarn lint:check
lint-fix:
uv run ruff format $(PY_SRC)
uv run ruff check --fix $(PY_SRC)
+ cd flowsint-app && yarn format && yarn lint
# mypy has ~2200 pre-existing errors across the workspace (real, not fixed
# blindly in one pass — see CI notes). Gating full-repo would be a