Skip to content

A modern platform for visual, flexible, and extensible graph-based investigations. For cybersecurity analysts and investigators.

fix(frontend): resolve all react-hooks/rules-of-hooks violations

dextmorgna620635c02ab
diff --git a/flowsint-app/src/components/flows/enricher-item.tsx b/flowsint-app/src/components/flows/enricher-item.tsx
index 31da3026..d694b2d3 100644
--- a/flowsint-app/src/components/flows/enricher-item.tsx
+++ b/flowsint-app/src/components/flows/enricher-item.tsx
@@ -13,6 +13,14 @@ import { Link } from '@tanstack/react-router'
import { FileCode2, Calendar } from 'lucide-react'
import { memo, useMemo } from 'react'
+function CategoryBadge({ category }: { category: string }) {
+ const color = useNodesDisplaySettings(
+ (state) => state.colors[category as keyof typeof state.colors] || '#000000'
+ )
+ const bgColor = useMemo(() => hexToRgba(color, 0.3), [color])
+ return <Badge style={{ backgroundColor: bgColor }}>{category}</Badge>
+}
+
export const EnricherItem = memo(({ enricher }: { enricher: any }) => {
const formattedDate = enricher.created_at
? new Date(enricher.created_at).toLocaleDateString('en-US', {
@@ -56,17 +64,9 @@ export const EnricherItem = memo(({ enricher }: { enricher: any }) => {
</div>
)}
<div className="flex gap-2 items-center flex-wrap">
- {enricher.category.map((category: string) => {
- const color = useNodesDisplaySettings(
- (state) => state.colors[category as keyof typeof state.colors] || '#000000'
- )
- const bgColor = useMemo(() => hexToRgba(color, 0.3), [color])
- return (
- <Badge key={category} style={{ backgroundColor: bgColor }}>
- {category}
- </Badge>
- )
- })}
+ {enricher.category.map((category: string) => (
+ <CategoryBadge key={category} category={category} />
+ ))}
</div>
</div>
</CardFooter>
diff --git a/flowsint-app/src/components/flows/enricher-list-item.tsx b/flowsint-app/src/components/flows/enricher-list-item.tsx
index 37facf27..dde40e67 100644
--- a/flowsint-app/src/components/flows/enricher-list-item.tsx
+++ b/flowsint-app/src/components/flows/enricher-list-item.tsx
@@ -32,12 +32,13 @@ const EnricherItem = memo(({ enricher, category }: EnricherItemProps) => {
const colors = useNodesDisplaySettings((s) => s.colors)
const borderInputColor = colors[enricher.inputs.type.toLowerCase()]
const borderOutputColor = colors[enricher.outputs.type.toLowerCase()]
- const Icon =
- enricher.type === 'type'
- ? useIcon(enricher.outputs.type.toLowerCase() as string)
- : enricher.icon
- ? useIcon(enricher.icon)
- : null
+ // useIcon must be called unconditionally (Rules of Hooks) — resolve the icon
+ // key first, then decide whether to use the result.
+ const wantsIcon = enricher.type === 'type' || Boolean(enricher.icon)
+ const iconType =
+ enricher.type === 'type' ? (enricher.outputs.type.toLowerCase() as string) : enricher.icon || ''
+ const iconRenderer = useIcon(iconType)
+ const Icon = wantsIcon ? iconRenderer : null
const [isDialogOpen, setIsDialogOpen] = useState(false)
diff --git a/flowsint-app/src/components/flows/enricher-node.tsx b/flowsint-app/src/components/flows/enricher-node.tsx
index 67febc4b..ed3467bf 100644
--- a/flowsint-app/src/components/flows/enricher-node.tsx
+++ b/flowsint-app/src/components/flows/enricher-node.tsx
@@ -51,12 +51,13 @@ const EnricherNode = memo(({ data, isConnectable }: EnricherNodeProps) => {
const outputColor = colors[data.outputs.type.toLowerCase()]
const opacity = data.computationState === 'pending' ? 0.5 : 1
const setOpenFlowSheet = useFlowStore((state) => state.setOpenFlowSheet)
- const Icon =
- data.type === 'type'
- ? useIcon(data.outputs.type.toLowerCase() as string)
- : data.icon
- ? useIcon(data.icon)
- : null
+ // useIcon must be called unconditionally (Rules of Hooks) — resolve the icon
+ // key first, then decide whether to use the result.
+ const wantsIcon = data.type === 'type' || Boolean(data.icon)
+ const iconType =
+ data.type === 'type' ? (data.outputs.type.toLowerCase() as string) : data.icon || ''
+ const iconRenderer = useIcon(iconType)
+ const Icon = wantsIcon ? iconRenderer : null
const handleAddConnector = useCallback(() => {
setOpenFlowSheet(true, data as unknown as FlowNode)
diff --git a/flowsint-app/src/components/flows/flow-sheet.tsx b/flowsint-app/src/components/flows/flow-sheet.tsx
index bba19f77..930adfd1 100644
--- a/flowsint-app/src/components/flows/flow-sheet.tsx
+++ b/flowsint-app/src/components/flows/flow-sheet.tsx
@@ -173,12 +173,13 @@ const EnricherItem = memo(({ enricher, onClick }: { enricher: Enricher; onClick:
const colors = useNodesDisplaySettings((s) => s.colors)
const borderInputColor = colors[enricher.inputs.type.toLowerCase()]
const borderOutputColor = colors[enricher.outputs.type.toLowerCase()]
- const Icon =
- enricher.type === 'type'
- ? useIcon(enricher.outputs.type.toLowerCase() as string)
- : enricher.icon
- ? useIcon(enricher.icon)
- : null
+ // useIcon must be called unconditionally (Rules of Hooks) — resolve the icon
+ // key first, then decide whether to use the result.
+ const wantsIcon = enricher.type === 'type' || Boolean(enricher.icon)
+ const iconType =
+ enricher.type === 'type' ? (enricher.outputs.type.toLowerCase() as string) : enricher.icon || ''
+ const iconRenderer = useIcon(iconType)
+ const Icon = wantsIcon ? iconRenderer : null
return (
<TooltipProvider>
diff --git a/flowsint-app/src/components/table/columns.tsx b/flowsint-app/src/components/table/columns.tsx
index 61e58299..3ec0fbe6 100644
--- a/flowsint-app/src/components/table/columns.tsx
+++ b/flowsint-app/src/components/table/columns.tsx
@@ -94,6 +94,78 @@ const getConfidenceColor = (confidence: number) => {
return 'text-red-600 dark:text-red-400'
}
+// `header`/`cell` are plain functions invoked by flexRender, not React
+// components — calling hooks directly inside them violates Rules of Hooks
+// (no stable per-cell Fiber to track hook order against). Extracted as real
+// components below so the hooks they need get a proper component instance.
+
+function SelectAllHeaderCell() {
+ const setSelectedNodes = useGraphStore((s) => s.setSelectedNodes)
+ const nodes = useGraphStore((s) => s.nodes)
+ const handleToggleCheckAll = useCallback(
+ (checked: boolean) => {
+ if (!checked) {
+ setSelectedNodes([])
+ return
+ } else setSelectedNodes(nodes)
+ },
+ [nodes, setSelectedNodes]
+ )
+ return (
+ <div className="flex items-center h-full">
+ <Checkbox onCheckedChange={handleToggleCheckAll} />
+ </div>
+ )
+}
+
+function SelectRowCell({ row }: { row: { original: GraphNode } }) {
+ const toggleNodeSelection = useGraphStore((s) => s.toggleNodeSelection)
+ const selectedNodes = useGraphStore((s) => s.selectedNodes)
+ const toggleNode = useCallback(
+ () => toggleNodeSelection(row.original, true),
+ [row.original, toggleNodeSelection]
+ )
+ const isNodeChecked = useCallback(
+ (nodeId: string) => {
+ return selectedNodes.some((node) => node.id === nodeId)
+ },
+ [selectedNodes]
+ )
+ return (
+ <div className="flex items-center">
+ <Checkbox checked={isNodeChecked(row.original.id)} onCheckedChange={toggleNode} />
+ </div>
+ )
+}
+
+// `data.label` here doesn't match the `GraphNode` type (which declares
+// `nodeLabel`) — pre-existing mismatch, invisible before because `row` was
+// implicitly `any`. This file has no consumers in the app (dead code, see
+// data-table.tsx), so left as-is rather than guessing the intended fix.
+function NodeLabelCell({ row }: { row: { original: any } }) {
+ const setCurrentNodeId = useGraphStore((s) => s.setCurrentNodeId)
+ const setOpenNodeEditorModal = useGraphStore((s) => s.setOpenNodeEditorModal)
+ const openEdit = useCallback(
+ (e: React.MouseEvent) => {
+ e.stopPropagation()
+ setCurrentNodeId(row.original.id)
+ setOpenNodeEditorModal(true)
+ },
+ [row.original, setCurrentNodeId, setOpenNodeEditorModal]
+ )
+
+ return (
+ <button
+ onClick={openEdit}
+ className="text-left font-medium flex items-center gap-2 h-full truncate text-ellipsis w-full rounded-md p-2 transition-colors duration-500"
+ >
+ <span className="hover:text-primary truncate text-[.9rem] block font-medium transition-colors duration-500">
+ {row.original.data.label}
+ </span>
+ </button>
+ )
+}
+
export const columns: ColumnDef<GraphNode>[] = [
{
size: 50,
@@ -101,40 +173,8 @@ export const columns: ColumnDef<GraphNode>[] = [
maxSize: 50,
enableResizing: false,
accessorKey: 'icon',
- header: () => {
- const setSelectedNodes = useGraphStore((s) => s.setSelectedNodes)
- const nodes = useGraphStore((s) => s.nodes)
- const handleToggleCheckAll = useCallback(
- (checked: boolean) => {
- if (!checked) {
- setSelectedNodes([])
- return
- } else setSelectedNodes(nodes)
- },
- [nodes, setSelectedNodes]
- )
- return (
- <div className="flex items-center h-full">
- <Checkbox onCheckedChange={handleToggleCheckAll} />
- </div>
- )
- },
- cell: ({ row }) => {
- const toggleNodeSelection = useGraphStore((s) => s.toggleNodeSelection)
- const selectedNodes = useGraphStore((s) => s.selectedNodes)
- const toggleNode = useCallback(() => toggleNodeSelection(row.original, true), [])
- const isNodeChecked = useCallback(
- (nodeId: string) => {
- return selectedNodes.some((node) => node.id === nodeId)
- },
- [selectedNodes]
- )
- return (
- <div className="flex items-center">
- <Checkbox checked={isNodeChecked(row.original.id)} onCheckedChange={toggleNode} />
- </div>
- )
- }
+ header: () => <SelectAllHeaderCell />,
+ cell: ({ row }) => <SelectRowCell row={row} />
},
{
enableResizing: true,
@@ -154,33 +194,7 @@ export const columns: ColumnDef<GraphNode>[] = [
</Button>
)
},
- cell: ({ row }) => {
- const setCurrentNodeId = useGraphStore((s) => s.setCurrentNodeId)
- // const IconComponent = useIcon(row.original.nodeType)
- const setOpenNodeEditorModal = useGraphStore((s) => s.setOpenNodeEditorModal)
- const openEdit = useCallback(
- (e: React.MouseEvent) => {
- e.stopPropagation()
- setCurrentNodeId(row.original.id)
- setOpenNodeEditorModal(true)
- },
- [row.original, setCurrentNodeId, setOpenNodeEditorModal]
- )
-
- return (
- <button
- onClick={openEdit}
- className="text-left font-medium flex items-center gap-2 h-full truncate text-ellipsis w-full rounded-md p-2 transition-colors duration-500"
- >
- {/* <div className="shrink-0">
- <IconComponent size={16} />
- </div> */}
- <span className="hover:text-primary truncate text-[.9rem] block font-medium transition-colors duration-500">
- {row.original.data.label}
- </span>
- </button>
- )
- }
+ cell: ({ row }) => <NodeLabelCell row={row} />
},
{
enableResizing: true,
diff --git a/flowsint-app/src/routes/__root.tsx b/flowsint-app/src/routes/__root.tsx
index 6bec186b..edcded61 100644
--- a/flowsint-app/src/routes/__root.tsx
+++ b/flowsint-app/src/routes/__root.tsx
@@ -9,14 +9,16 @@ export interface MyRouterContext {
queryClient: QueryClient
}
+function RootComponent() {
+ const { theme } = useTheme()
+ return (
+ <TutorialProvider>
+ <Toaster offset={{ top: '90px' }} theme={theme} position="top-center" />
+ <Outlet />
+ </TutorialProvider>
+ )
+}
+
export const Route = createRootRouteWithContext<MyRouterContext>()({
- component: () => {
- const { theme } = useTheme()
- return (
- <TutorialProvider>
- <Toaster offset={{ top: '90px' }} theme={theme} position="top-center" />
- <Outlet />
- </TutorialProvider>
- )
- }
+ component: RootComponent
})