Use Claude Code, Codex, VSCode, Pi, and OpenCode (and 6 other harnesses) for free (1.3B+ free tokens) from your terminal, app, IDE, or phone, and now from the browser with native browser sessions (multi-harness + multi-model) like OpenClaw (voice supported + ToS friendly)
Python
Reject invalid provider proxy settings (#1585)
Ali Khokharaf417c43bfec
diff --git a/pyproject.toml b/pyproject.tomlindex c0008ebe..2047eda6 100644--- a/pyproject.toml+++ b/pyproject.toml@@ -4,7 +4,7 @@ build-backend = "hatchling.build"[project]name = "free-claude-code"-version = "5.15.0"+version = "5.15.1"description = "Local proxy connecting coding agents to OpenAI-compatible AI providers"readme = "README.md"requires-python = ">=3.14.0"diff --git a/src/free_claude_code/config/admin/persistence.py b/src/free_claude_code/config/admin/persistence.pyindex fbeedca6..014be7b4 100644--- a/src/free_claude_code/config/admin/persistence.py+++ b/src/free_claude_code/config/admin/persistence.py@@ -4,6 +4,8 @@ from collections.abc import Mappingfrom dataclasses import dataclassfrom pathlib import Path+import httpx+from free_claude_code.config.env_files import (FCC_CONFIG_SCHEMA_ENV,dotenv_values_from_file,@@ -15,6 +17,7 @@ from free_claude_code.config.env_migrations import (render_managed_config,)from free_claude_code.config.paths import managed_env_path+from free_claude_code.config.provider_catalog import PROVIDER_CATALOGfrom free_claude_code.config.settings import Settingsfrom free_claude_code.core.json_types import JsonObject@@ -23,6 +26,21 @@ from .state import ConfigInputValuefrom .validation import settings_from_valuesfrom .values import MASKED_SECRET, is_locked_source, load_value_state, normalize_for_env+_PROVIDER_PROXY_ATTRS = frozenset(+ descriptor.proxy_attr+ for descriptor in PROVIDER_CATALOG.values()+ if descriptor.proxy_attr is not None+)+_PROVIDER_PROXY_KEYS = tuple(+ field.key+ for field in FIELD_BY_KEY.values()+ if field.settings_attr in _PROVIDER_PROXY_ATTRS+)+_PROVIDER_PROXY_ERROR = (+ "must be a proxy URL with a supported scheme and host "+ "(for example http://127.0.0.1:8080 or socks5://127.0.0.1:1080)"+)+@dataclass(frozen=True, slots=True)class PreparedAdminUpdate:@@ -142,7 +160,11 @@ def prepare_admin_update(update_errors = _update_protocol_errors(updates)target_values = target_values_with_updates(updates)settings, settings_errors = settings_from_values(target_values)- errors = (*update_errors, *settings_errors)+ errors = (+ *update_errors,+ *settings_errors,+ *_provider_proxy_errors(target_values),+ )pending_fields = (tuple(changed_pending_fields(updates, settings=settings))if settings is not None and not errors@@ -187,6 +209,22 @@ def _update_protocol_errors(return tuple(errors)+def _provider_proxy_errors(values: Mapping[str, str]) -> tuple[str, ...]:+ errors: list[str] = []+ for key in _PROVIDER_PROXY_KEYS:+ value = values.get(key)+ if not value:+ continue+ try:+ proxy = httpx.Proxy(value)+ except httpx.InvalidURL, ValueError:+ errors.append(f"{key}: {_PROVIDER_PROXY_ERROR}")+ continue+ if not proxy.url.host:+ errors.append(f"{key}: {_PROVIDER_PROXY_ERROR}")+ return tuple(errors)++def _active_voice_credential(settings: Settings) -> str | None:if not settings.voice_note_enabled:return Nonediff --git a/tests/api/test_admin.py b/tests/api/test_admin.pyindex 996e7bac..5d6d392d 100644--- a/tests/api/test_admin.py+++ b/tests/api/test_admin.py@@ -61,6 +61,23 @@ def _clear_process_config(monkeypatch) -> None:"CLAUDE_CLI_BIN",):monkeypatch.delenv(key, raising=False)+ for descriptor in PROVIDER_CATALOG.values():+ if descriptor.proxy_attr is None:+ continue+ alias = Settings.model_fields[descriptor.proxy_attr].validation_alias+ if alias is not None:+ monkeypatch.delenv(str(alias), raising=False)+++def _catalog_proxy_env_keys() -> tuple[str, ...]:+ keys: list[str] = []+ for descriptor in PROVIDER_CATALOG.values():+ if descriptor.proxy_attr is None:+ continue+ alias = Settings.model_fields[descriptor.proxy_attr].validation_alias+ if alias is not None:+ keys.append(str(alias))+ return tuple(keys)def test_admin_page_is_loopback_only(monkeypatch, tmp_path):@@ -818,6 +835,180 @@ def test_admin_validate_rejects_duplicate_model_fallbacks(monkeypatch, tmp_path)assert any("duplicate" in error.lower() for error in body["errors"])[email protected]("proxy_key", _catalog_proxy_env_keys())+def test_admin_validate_rejects_invalid_catalog_provider_proxy(+ monkeypatch,+ tmp_path,+ proxy_key,+):+ _set_home(monkeypatch, tmp_path)+ _clear_process_config(monkeypatch)+ invalid_proxy = "not-a-proxy://user:[email protected]:8080"++ response = _local_client(create_test_app()).post(+ "/admin/api/config/validate",+ json={"values": {proxy_key: invalid_proxy}},+ )++ assert response.status_code == 200+ body = response.json()+ assert body["valid"] is False+ assert body["errors"] == [+ (+ f"{proxy_key}: must be a proxy URL with a supported scheme and host "+ "(for example http://127.0.0.1:8080 or socks5://127.0.0.1:1080)"+ )+ ]+ assert invalid_proxy not in response.text+ assert "leaked-secret" not in response.text+++ "proxy",+ (+ "http://user:[email protected]:8080",+ "https://proxy.example:8443",+ "socks5://127.0.0.1:1080",+ "socks5h://proxy.example:1080",+ " http://127.0.0.1:8080 ",+ ),+)+def test_admin_validate_accepts_httpx_provider_proxy(monkeypatch, tmp_path, proxy):+ _set_home(monkeypatch, tmp_path)+ _clear_process_config(monkeypatch)++ response = _local_client(create_test_app()).post(+ "/admin/api/config/validate",+ json={"values": {"OPENAI_PROXY": proxy}},+ )++ assert response.status_code == 200+ assert response.json()["valid"] is True+++ "proxy",+ (+ "copied Admin page text",+ "socks://127.0.0.1:1080",+ "http://",+ "http:///path",+ "http://proxy.example:notaport",+ ),+)+def test_admin_validate_rejects_unusable_provider_proxy(monkeypatch, tmp_path, proxy):+ _set_home(monkeypatch, tmp_path)+ _clear_process_config(monkeypatch)++ response = _local_client(create_test_app()).post(+ "/admin/api/config/validate",+ json={"values": {"OPENAI_PROXY": proxy}},+ )++ assert response.status_code == 200+ body = response.json()+ assert body["valid"] is False+ assert len(body["errors"]) == 1+ assert body["errors"][0].startswith("OPENAI_PROXY: must be a proxy URL")+ assert "OPENAI_PROXY=********" in body["env_preview"]+++def test_admin_apply_rejects_invalid_provider_proxy_without_side_effects(+ monkeypatch,+ tmp_path,+):+ _set_home(monkeypatch, tmp_path)+ _clear_process_config(monkeypatch)+ env_file = tmp_path / ".fcc" / ".env"+ env_file.parent.mkdir(parents=True)+ env_file.write_text("MODEL=open_router/test-model\n", encoding="utf-8")+ callbacks: list[str] = []++ async def restart_callback() -> None:+ callbacks.append("restart")++ app = create_test_app(restart_callback=restart_callback)+ _local_client(app).get("/admin/api/config")+ baseline = env_file.read_bytes()+ invalid_proxy = "invalid://user:[email protected]:8080"++ response = _local_client(app).post(+ "/admin/api/config/apply",+ json={"values": {"OPENAI_PROXY": invalid_proxy}},+ )++ assert response.status_code == 200+ body = response.json()+ assert body["valid"] is False+ assert body["applied"] is False+ assert body["pending_fields"] == []+ assert env_file.read_bytes() == baseline+ assert callbacks == []+ assert invalid_proxy not in response.text+ assert "leaked-secret" not in response.text+++def test_admin_apply_validates_retained_proxy_and_allows_removal(+ monkeypatch,+ tmp_path,+):+ _set_home(monkeypatch, tmp_path)+ _clear_process_config(monkeypatch)+ env_file = tmp_path / ".fcc" / ".env"+ env_file.parent.mkdir(parents=True)+ invalid_proxy = "invalid://proxy.example:8080"+ original = f"GROQ_PROXY={invalid_proxy}\n"+ env_file.write_text(original, encoding="utf-8")+ app = create_test_app()+ _local_client(app).get("/admin/api/config")+ baseline = env_file.read_bytes()++ rejected = _local_client(app).post(+ "/admin/api/config/apply",+ json={"values": {"MODEL": "open_router/test-model"}},+ )++ assert rejected.status_code == 200+ assert rejected.json()["applied"] is False+ assert env_file.read_bytes() == baseline++ removed = _local_client(app).post(+ "/admin/api/config/apply",+ json={"values": {"GROQ_PROXY": None}},+ )++ assert removed.status_code == 200+ assert removed.json()["applied"] is True+ assert "GROQ_PROXY=" not in env_file.read_text(encoding="utf-8")++[email protected]("submitted", (MASKED_SECRET, "", " "))+def test_admin_validate_preserves_valid_stored_proxy_secret(+ monkeypatch,+ tmp_path,+ submitted,+):+ _set_home(monkeypatch, tmp_path)+ _clear_process_config(monkeypatch)+ env_file = tmp_path / ".fcc" / ".env"+ env_file.parent.mkdir(parents=True)+ env_file.write_text(+ "OPENAI_PROXY=http://user:[email protected]:8080\n",+ encoding="utf-8",+ )++ response = _local_client(create_test_app()).post(+ "/admin/api/config/validate",+ json={"values": {"OPENAI_PROXY": submitted}},+ )++ assert response.status_code == 200+ body = response.json()+ assert body["valid"] is True+ assert "OPENAI_PROXY=********" in body["env_preview"]+ assert "password" not in response.text++def test_admin_apply_writes_complete_managed_env_and_masks_preview(monkeypatch, tmp_path):diff --git a/uv.lock b/uv.lockindex f2c5c0f3..1ac8ecb5 100644--- a/uv.lock+++ b/uv.lock@@ -607,7 +607,7 @@ wheels = [[[package]]name = "free-claude-code"-version = "5.15.0"+version = "5.15.1"source = { editable = "." }dependencies = [{ name = "aiohttp" },