Use Claude Code, Codex, VSCode, Pi, and OpenCode (and 6 other harnesses) for free (1.3B+ free tokens) from your terminal, app, IDE, or phone, and now from the browser with native browser sessions (multi-harness + multi-model) like OpenClaw (voice supported + ToS friendly)
Python
Move installer checks to the opt-in smoke suite (#1908)
Ali Khokharba4b93414785
diff --git a/smoke/README.md b/smoke/README.mdindex d6c7c285..ceb24312 100644--- a/smoke/README.md+++ b/smoke/README.md@@ -1,11 +1,13 @@# Product E2E Smoke Tests`smoke/` is local-only. It can launch subprocesses, call real providers, touch-local model servers, and optionally send/delete bot messages. Hermetic contracts-belong under `tests/` and must stay green with plain `uv run pytest`.+local model servers, and optionally send/delete bot messages. Installer checks+also live here as an opt-in suite. Regular CI collects only `tests/` and `e2e/`.## Taxonomy+- `smoke/installers/`: installer, uninstaller, and harness lifecycle checks with+ isolated files and simulated downloads. These do not install real tools.- `smoke/prereq/`: liveness checks that prove the server, routes, auth, CLIscripts, provider pings, local `/models`, and bot permissions are reachable.These are prerequisites only.@@ -24,6 +26,13 @@ uv run pytest smoke -n 0 -s --tb=shortThe second command skips everything unless `FCC_LIVE_SMOKE=1` is set, but stillwrites skip entries to `.smoke-results/`.+Run only the installer checks:++```powershell+$env:FCC_LIVE_SMOKE = "1"+uv run pytest smoke/installers+```+## Product Smoke Run```powershelldiff --git a/tests/installers/AGENTS.md b/smoke/installers/AGENTS.mdsimilarity index 88%rename from tests/installers/AGENTS.mdrename to smoke/installers/AGENTS.mdindex 55bf8e7f..61c0f8e1 100644--- a/tests/installers/AGENTS.md+++ b/smoke/installers/AGENTS.md@@ -9,7 +9,7 @@ These rules apply to installer, uninstaller, and harness lifecycle tests here.and abort ordering between installation phases. Preserve those assertions whenmaking tests faster. Prepare unrelated prerequisites as already installed.- Keep coverage for both Windows PowerShell and PowerShell 7, plus the applicable- POSIX paths. Do not skip coverage or move it out of CI to hide slow tests.+ POSIX paths. This suite is opt-in and does not run in regular CI.- Stub downloads and external installers. Never install real harnesses, use liveproviders, or modify the user's installed tools and configuration in these tests.- Give every scenario private files, configuration, PATH, and cache storage. Use@@ -22,7 +22,7 @@ These rules apply to installer, uninstaller, and harness lifecycle tests here.or user configuration to save startup time. Clean up processes you launch.- Diagnose slowness with per-test durations and timings inside subprocesses. Do notincrease timeouts or add sleeps without identifying the operation being delayed.-- Use `scripts/ci.ps1` for local verification. `PYTEST_ADDOPTS` can select focused- cases and enable duration reporting. Run the full relevant suite before pushing.+- Run these checks explicitly with `FCC_LIVE_SMOKE=1` and+ `uv run pytest smoke/installers`. Select focused cases when checking a component.- Reuse pytest's capture handler for logs. Do not create a logging cycle betweenPython logging and Loguru while adding diagnostics.diff --git a/tests/installers/_pty_runner.py b/smoke/installers/_pty_runner.pysimilarity index 100%rename from tests/installers/_pty_runner.pyrename to smoke/installers/_pty_runner.pydiff --git a/tests/installers/conftest.py b/smoke/installers/conftest.pysimilarity index 100%rename from tests/installers/conftest.pyrename to smoke/installers/conftest.pydiff --git a/tests/installers/fixtures/.gitattributes b/smoke/installers/fixtures/.gitattributessimilarity index 100%rename from tests/installers/fixtures/.gitattributesrename to smoke/installers/fixtures/.gitattributesdiff --git a/tests/installers/fixtures/README.md b/smoke/installers/fixtures/README.mdsimilarity index 100%rename from tests/installers/fixtures/README.mdrename to smoke/installers/fixtures/README.mddiff --git a/tests/installers/fixtures/rtk-LICENSE b/smoke/installers/fixtures/rtk-LICENSEsimilarity index 100%rename from tests/installers/fixtures/rtk-LICENSErename to smoke/installers/fixtures/rtk-LICENSEdiff --git a/tests/installers/fixtures/rtk-opencode-v1.ts b/smoke/installers/fixtures/rtk-opencode-v1.tssimilarity index 100%rename from tests/installers/fixtures/rtk-opencode-v1.tsrename to smoke/installers/fixtures/rtk-opencode-v1.tsdiff --git a/tests/installers/test_installers.py b/smoke/installers/test_installers.pysimilarity index 100%rename from tests/installers/test_installers.pyrename to smoke/installers/test_installers.pydiff --git a/tests/installers/test_muse_windows_lifecycle.py b/smoke/installers/test_muse_windows_lifecycle.pysimilarity index 100%rename from tests/installers/test_muse_windows_lifecycle.pyrename to smoke/installers/test_muse_windows_lifecycle.pydiff --git a/tests/installers/test_powershell_cache.py b/smoke/installers/test_powershell_cache.pysimilarity index 100%rename from tests/installers/test_powershell_cache.pyrename to smoke/installers/test_powershell_cache.pydiff --git a/tests/installers/test_uninstallers.py b/smoke/installers/test_uninstallers.pysimilarity index 100%rename from tests/installers/test_uninstallers.pyrename to smoke/installers/test_uninstallers.py