Skip to content

7.4 billion tokens per month. 34 free LLM providers. 635 free model endpoints. All behind one /v1 endpoint, plus any custom OpenAI-compatible endpoint. Smart routing, automatic failover, encrypted keys. Personal experimentation only.

TypeScript

fix(google): guard SSE JSON.parse so a bad chunk doesn't kill the stream (#47)

Praveen Kumar Pranjal10bcfe25efbc
diff --git a/server/src/__tests__/providers/google.test.ts b/server/src/__tests__/providers/google.test.ts
index 1fe06e9e..31984dc4 100644
--- a/server/src/__tests__/providers/google.test.ts
+++ b/server/src/__tests__/providers/google.test.ts
@@ -230,4 +230,83 @@ describe('GoogleProvider', () => {
expect(assistantEntry.parts[0].thoughtSignature).toBe('sig_123');
expect(assistantEntry.parts[0].functionCall.name).toBe('get_weather');
});
+
+ // ── Streaming ──────────────────────────────────────────────────────────────
+ // Build a Response-shaped object backed by a ReadableStream so the provider's
+ // `res.body.getReader()` path executes for real (Node 20+ has both globally).
+ function sseResponse(frames: string[]): any {
+ const stream = new ReadableStream<Uint8Array>({
+ start(controller) {
+ const encoder = new TextEncoder();
+ for (const f of frames) controller.enqueue(encoder.encode(f));
+ controller.close();
+ },
+ });
+ return { ok: true, body: stream };
+ }
+
+ async function collect<T>(gen: AsyncGenerator<T>): Promise<T[]> {
+ const out: T[] = [];
+ for await (const c of gen) out.push(c);
+ return out;
+ }
+
+ it('streams text deltas and emits a final stop chunk', async () => {
+ vi.spyOn(global, 'fetch').mockResolvedValueOnce(sseResponse([
+ 'data: {"candidates":[{"content":{"parts":[{"text":"Hel"}]}}]}\n\n',
+ 'data: {"candidates":[{"content":{"parts":[{"text":"lo"}]}}]}\n\n',
+ 'data: {"candidates":[{"content":{"parts":[]},"finishReason":"STOP"}]}\n\n',
+ ]));
+
+ const chunks = await collect(provider.streamChatCompletion(
+ 'test-key',
+ [{ role: 'user', content: 'Hi' }],
+ 'gemini-2.5-pro',
+ ));
+
+ const text = chunks.map(c => c.choices[0].delta.content ?? '').join('');
+ expect(text).toBe('Hello');
+ expect(chunks[chunks.length - 1].choices[0].finish_reason).toBe('stop');
+ });
+
+ it('skips a malformed SSE frame instead of aborting the whole stream', async () => {
+ // Regression: previously an unguarded JSON.parse would propagate, killing
+ // the stream after a single bad chunk. Other providers (openai-compat,
+ // cohere, cloudflare) already protect this path with try/catch.
+ vi.spyOn(global, 'fetch').mockResolvedValueOnce(sseResponse([
+ 'data: {"candidates":[{"content":{"parts":[{"text":"Hel"}]}}]}\n\n',
+ 'data: {oops not json\n\n',
+ 'data: {"candidates":[{"content":{"parts":[{"text":"lo"}]}}]}\n\n',
+ 'data: [DONE]\n\n',
+ ]));
+
+ const chunks = await collect(provider.streamChatCompletion(
+ 'test-key',
+ [{ role: 'user', content: 'Hi' }],
+ 'gemini-2.5-pro',
+ ));
+
+ const text = chunks.map(c => c.choices[0].delta.content ?? '').join('');
+ expect(text).toBe('Hello');
+ expect(chunks[chunks.length - 1].choices[0].finish_reason).toBe('stop');
+ });
+
+ it('streams functionCall parts as tool_calls with finish_reason=tool_calls', async () => {
+ vi.spyOn(global, 'fetch').mockResolvedValueOnce(sseResponse([
+ 'data: {"candidates":[{"content":{"parts":[{"functionCall":{"id":"call_1","name":"get_weather","args":{"city":"Karachi"}}}]}}]}\n\n',
+ 'data: {"candidates":[{"content":{"parts":[]},"finishReason":"STOP"}]}\n\n',
+ ]));
+
+ const chunks = await collect(provider.streamChatCompletion(
+ 'test-key',
+ [{ role: 'user', content: 'Weather?' }],
+ 'gemini-2.5-pro',
+ ));
+
+ const toolDeltas = chunks.flatMap(c => c.choices[0].delta.tool_calls ?? []);
+ expect(toolDeltas).toHaveLength(1);
+ expect(toolDeltas[0].function.name).toBe('get_weather');
+ expect(toolDeltas[0].function.arguments).toBe('{"city":"Karachi"}');
+ expect(chunks[chunks.length - 1].choices[0].finish_reason).toBe('tool_calls');
+ });
});
diff --git a/server/src/providers/google.ts b/server/src/providers/google.ts
index ba5722b7..532d18d6 100644
--- a/server/src/providers/google.ts
+++ b/server/src/providers/google.ts
@@ -346,7 +346,15 @@ export class GoogleProvider extends BaseProvider {
return;
}
- const chunk = JSON.parse(raw) as GeminiResponse;
+ // Skip malformed SSE frames instead of aborting the whole stream.
+ // Matches the defensive parse in openai-compat / cohere / cloudflare:
+ // a single corrupt chunk shouldn't take down the rest of the response.
+ let chunk: GeminiResponse;
+ try {
+ chunk = JSON.parse(raw) as GeminiResponse;
+ } catch {
+ continue;
+ }
const candidate = chunk.candidates?.[0];
const parts = candidate?.content?.parts ?? [];